Skip to content

Commit d8feb31

Browse files
authored
refactor: bootstrap (#203)
1 parent b8e9f14 commit d8feb31

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

lib/redis_client/cluster/command.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ class Command
2222

2323
class << self
2424
def load(nodes)
25-
errors = []
26-
cmd = nil
27-
nodes&.each do |node|
28-
break unless cmd.nil?
25+
cmd = errors = nil
2926

27+
nodes&.each do |node|
3028
reply = node.call('COMMAND')
3129
commands = parse_command_reply(reply)
3230
cmd = ::RedisClient::Cluster::Command.new(commands)
31+
break
3332
rescue ::RedisClient::Error => e
33+
errors ||= []
3434
errors << e
3535
end
3636

lib/redis_client/cluster/node.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,10 @@ def load_info(options, **kwargs) # rubocop:disable Metrics/AbcSize, Metrics/Cycl
121121
raise ::RedisClient::Cluster::InitialSetupError, errors if node_info_list.nil?
122122

123123
grouped = node_info_list.compact.group_by do |info_list|
124-
info_list
125-
.sort_by(&:id)
126-
.map { |i| "#{i.id}#{i.node_key}#{i.role}#{i.primary_id}#{i.config_epoch}" }
127-
.join
124+
info_list.sort_by!(&:id)
125+
info_list.each_with_object(String.new(capacity: 128 * info_list.size)) do |e, a|
126+
a << e.id << e.node_key << e.role << e.primary_id << e.config_epoch
127+
end
128128
end
129129

130130
grouped.max_by { |_, v| v.size }[1].first

0 commit comments

Comments
 (0)