Skip to content

Commit 09dfce7

Browse files
Change TimeStamp from DateTime to Millisecond Instead of Ticks (#127)
* Change TimeStamp from DateTime to Millisecond Instead of Ticks * Assert.Equal the Values * Update src/NRedisStack/TimeSeries/DataTypes/TimeStamp.cs Co-authored-by: Steve Lorello <[email protected]> * update tests --------- Co-authored-by: Steve Lorello <[email protected]>
1 parent 6f1290d commit 09dfce7

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

src/NRedisStack/TimeSeries/DataTypes/TimeStamp.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class TimeStamp
2323
/// Build a TimeStamp from DateTime.
2424
/// </summary>
2525
/// <param name="dateTime">DateTime value</param>
26-
public TimeStamp(DateTime dateTime) => Value = dateTime.Ticks;
26+
public TimeStamp(DateTime dateTime) => Value = new DateTimeOffset(dateTime).ToUnixTimeMilliseconds();
2727

2828
/// <summary>
2929
/// Build a TimeStamp from one of the strings "-", "+", "*".

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestAdd.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,8 @@ public void TestOldAdd()
210210
ts.Create(key);
211211
ts.Add(key, new_dt, 1.1);
212212
// Adding old event
213-
Assert.Equal(old_dt, ts.Add(key, old_dt, 1.1));
213+
var res = ts.Add(key, old_dt, 1.1);
214+
Assert.Equal(old_dt.Value, res.Value);
214215
}
215216

216217
[Fact]

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestAddAsync.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,8 @@ public async Task TestOldAdd()
228228
await ts.CreateAsync(key);
229229
await ts.AddAsync(key, newTimeStamp, 1.1);
230230
// Adding old event
231-
Assert.Equal(oldTimeStamp, await ts.AddAsync(key, oldTimeStamp, 1.1));
231+
var res = await ts.AddAsync(key, oldTimeStamp, 1.1);
232+
Assert.Equal(oldTimeStamp.Value, res.Value);
232233
}
233234

234235
[Fact]

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestMADD.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void TestSuccessfulMADD()
7676
Assert.Equal(timestamps.Count, response.Count);
7777
for (int i = 0; i < response.Count; i++)
7878
{
79-
Assert.Equal<DateTime>(timestamps[i], response[i]);
79+
Assert.Equal(new DateTimeOffset(timestamps[i]).ToUnixTimeMilliseconds(), response[i].Value);
8080
}
8181
}
8282

@@ -117,7 +117,7 @@ public void TestOverrideMADD()
117117
Assert.Equal(oldTimeStamps.Count, response.Count);
118118
for (int i = 0; i < response.Count; i++)
119119
{
120-
Assert.Equal<DateTime>(oldTimeStamps[i], response[i]);
120+
Assert.Equal(new DateTimeOffset(oldTimeStamps[i]).ToUnixTimeMilliseconds(), response[i].Value);
121121
}
122122
}
123123
}

tests/NRedisStack.Tests/TimeSeries/TestAPI/TestMAddAsync.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public async Task TestSuccessfulMAdd()
6969
Assert.Equal(timestamps.Count, response.Count);
7070
for (var i = 0; i < response.Count; i++)
7171
{
72-
Assert.Equal<DateTime>(timestamps[i], response[i]);
72+
Assert.Equal(new DateTimeOffset(timestamps[i]).ToUnixTimeMilliseconds(), response[i].Value);
7373
}
7474
}
7575

@@ -112,7 +112,7 @@ public async Task TestOverrideMAdd()
112112
Assert.Equal(oldTimeStamps.Count, response.Count);
113113
for (int i = 0; i < response.Count; i++)
114114
{
115-
Assert.Equal<DateTime>(oldTimeStamps[i], response[i]);
115+
Assert.Equal(new DateTimeOffset(oldTimeStamps[i]).ToUnixTimeMilliseconds(), response[i].Value);
116116
}
117117
}
118118
}

tests/NRedisStack.Tests/TimeSeries/TestDataTypes/TestTimeStamp.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public void TestTimeStampImplicitCast()
2525

2626
DateTime now = DateTime.UtcNow;
2727
ts = now;
28-
Assert.Equal<DateTime>(now, ts);
28+
Assert.Equal(new DateTimeOffset(now).ToUnixTimeMilliseconds(), ts.Value);
2929

3030
}
3131
}

0 commit comments

Comments
 (0)