Skip to content

Commit 26f5dd8

Browse files
Anuj Modimgravell
Anuj Modi
authored and
mgravell
committed
Breaking changes (combined):
- absorb strong-naming from #417 - fix embarrassing tyop
1 parent ed92c34 commit 26f5dd8

File tree

6 files changed

+33
-31
lines changed

6 files changed

+33
-31
lines changed

‎Directory.Build.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
2424
<SuppressTfmSupportBuildErrors>true</SuppressTfmSupportBuildErrors>
2525
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
26+
<AssemblyOriginatorKeyFile>../../NRedisStack.snk</AssemblyOriginatorKeyFile>
27+
<SignAssembly>True</SignAssembly>
2628
<NoWarn>$(NoWarn);CS1591</NoWarn>
2729
<IsWindows>$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::get_Windows())))</IsWindows>
2830
</PropertyGroup>

‎NRedisStack.snk

596 Bytes
Binary file not shown.

‎src/NRedisStack/PublicAPI/PublicAPI.Shipped.txt

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1352,7 +1352,7 @@ virtual NRedisStack.Search.Aggregation.Reducer.AddOwnArgs(System.Collections.Gen
13521352
virtual NRedisStack.Search.Aggregation.Reducer.GetOwnArgsCount() -> int
13531353
NRedisStack.Search.Schema.AddFlatVectorField(NRedisStack.Search.FieldName! name, NRedisStack.Search.Schema.VectorField.VectorType type, int dimensions, NRedisStack.Search.Schema.VectorField.VectorDistanceMetric distanceMetric, System.Collections.Generic.Dictionary<string!, object!>? attributes = null, bool missingIndex = false) -> NRedisStack.Search.Schema!
13541354
NRedisStack.Search.Schema.AddHnswVectorField(NRedisStack.Search.FieldName! name, NRedisStack.Search.Schema.VectorField.VectorType type, int dimensions, NRedisStack.Search.Schema.VectorField.VectorDistanceMetric distanceMetric, int maxOutgoingConnections = 16, int maxConnectedNeighbors = 200, int maxTopCandidates = 10, double boundaryFactor = 0.01, System.Collections.Generic.Dictionary<string!, object!>? attributes = null, bool missingIndex = false) -> NRedisStack.Search.Schema!
1355-
NRedisStack.Search.Schema.AddSvsVanamaVectorField(NRedisStack.Search.FieldName! name, NRedisStack.Search.Schema.VectorField.VectorType type, int dimensions, NRedisStack.Search.Schema.VectorField.VectorDistanceMetric distanceMetric, NRedisStack.Search.Schema.VectorField.VectorCompressionAlgorithm compressionAlgorithm = NRedisStack.Search.Schema.VectorField.VectorCompressionAlgorithm.NotSpecified, int constructionWindowSize = 200, int graphMaxDegree = 32, int searchWindowSize = 10, double rangeSearchApproximationFactor = 0.01, int trainingThreshold = 0, int reducedDimensions = 0, System.Collections.Generic.Dictionary<string!, object!>? attributes = null, bool missingIndex = false) -> NRedisStack.Search.Schema!
1355+
NRedisStack.Search.Schema.AddSvsVamanaVectorField(NRedisStack.Search.FieldName! name, NRedisStack.Search.Schema.VectorField.VectorType type, int dimensions, NRedisStack.Search.Schema.VectorField.VectorDistanceMetric distanceMetric, NRedisStack.Search.Schema.VectorField.VectorCompressionAlgorithm compressionAlgorithm = NRedisStack.Search.Schema.VectorField.VectorCompressionAlgorithm.NotSpecified, int constructionWindowSize = 200, int graphMaxDegree = 32, int searchWindowSize = 10, double rangeSearchApproximationFactor = 0.01, int trainingThreshold = 0, int reducedDimensions = 0, System.Collections.Generic.Dictionary<string!, object!>? attributes = null, bool missingIndex = false) -> NRedisStack.Search.Schema!
13561356
NRedisStack.Search.Schema.FlatVectorField
13571357
NRedisStack.Search.Schema.FlatVectorField.FlatVectorField(NRedisStack.Search.FieldName! name, NRedisStack.Search.Schema.VectorField.VectorType type, int dimensions, NRedisStack.Search.Schema.VectorField.VectorDistanceMetric distanceMetric, System.Collections.Generic.Dictionary<string!, object!>? attributes = null, bool missingIndex = false) -> void
13581358
NRedisStack.Search.Schema.HnswVectorField
@@ -1365,22 +1365,22 @@ NRedisStack.Search.Schema.HnswVectorField.MaxOutgoingConnections.get -> int
13651365
NRedisStack.Search.Schema.HnswVectorField.MaxOutgoingConnections.set -> void
13661366
NRedisStack.Search.Schema.HnswVectorField.MaxTopCandidates.get -> int
13671367
NRedisStack.Search.Schema.HnswVectorField.MaxTopCandidates.set -> void
1368-
NRedisStack.Search.Schema.SvsVanamaVectorField
1369-
NRedisStack.Search.Schema.SvsVanamaVectorField.CompressionAlgorithm.get -> NRedisStack.Search.Schema.VectorField.VectorCompressionAlgorithm
1370-
NRedisStack.Search.Schema.SvsVanamaVectorField.CompressionAlgorithm.set -> void
1371-
NRedisStack.Search.Schema.SvsVanamaVectorField.ConstructionWindowSize.get -> int
1372-
NRedisStack.Search.Schema.SvsVanamaVectorField.ConstructionWindowSize.set -> void
1373-
NRedisStack.Search.Schema.SvsVanamaVectorField.GraphMaxDegree.get -> int
1374-
NRedisStack.Search.Schema.SvsVanamaVectorField.GraphMaxDegree.set -> void
1375-
NRedisStack.Search.Schema.SvsVanamaVectorField.RangeSearchApproximationFactor.get -> double
1376-
NRedisStack.Search.Schema.SvsVanamaVectorField.RangeSearchApproximationFactor.set -> void
1377-
NRedisStack.Search.Schema.SvsVanamaVectorField.ReducedDimensions.get -> int
1378-
NRedisStack.Search.Schema.SvsVanamaVectorField.ReducedDimensions.set -> void
1379-
NRedisStack.Search.Schema.SvsVanamaVectorField.SearchWindowSize.get -> int
1380-
NRedisStack.Search.Schema.SvsVanamaVectorField.SearchWindowSize.set -> void
1381-
NRedisStack.Search.Schema.SvsVanamaVectorField.SvsVanamaVectorField(NRedisStack.Search.FieldName! name, NRedisStack.Search.Schema.VectorField.VectorType type, int dimensions, NRedisStack.Search.Schema.VectorField.VectorDistanceMetric distanceMetric, System.Collections.Generic.Dictionary<string!, object!>? attributes = null, bool missingIndex = false) -> void
1382-
NRedisStack.Search.Schema.SvsVanamaVectorField.TrainingThreshold.get -> int
1383-
NRedisStack.Search.Schema.SvsVanamaVectorField.TrainingThreshold.set -> void
1368+
NRedisStack.Search.Schema.SvsVamanaVectorField
1369+
NRedisStack.Search.Schema.SvsVamanaVectorField.CompressionAlgorithm.get -> NRedisStack.Search.Schema.VectorField.VectorCompressionAlgorithm
1370+
NRedisStack.Search.Schema.SvsVamanaVectorField.CompressionAlgorithm.set -> void
1371+
NRedisStack.Search.Schema.SvsVamanaVectorField.ConstructionWindowSize.get -> int
1372+
NRedisStack.Search.Schema.SvsVamanaVectorField.ConstructionWindowSize.set -> void
1373+
NRedisStack.Search.Schema.SvsVamanaVectorField.GraphMaxDegree.get -> int
1374+
NRedisStack.Search.Schema.SvsVamanaVectorField.GraphMaxDegree.set -> void
1375+
NRedisStack.Search.Schema.SvsVamanaVectorField.RangeSearchApproximationFactor.get -> double
1376+
NRedisStack.Search.Schema.SvsVamanaVectorField.RangeSearchApproximationFactor.set -> void
1377+
NRedisStack.Search.Schema.SvsVamanaVectorField.ReducedDimensions.get -> int
1378+
NRedisStack.Search.Schema.SvsVamanaVectorField.ReducedDimensions.set -> void
1379+
NRedisStack.Search.Schema.SvsVamanaVectorField.SearchWindowSize.get -> int
1380+
NRedisStack.Search.Schema.SvsVamanaVectorField.SearchWindowSize.set -> void
1381+
NRedisStack.Search.Schema.SvsVamanaVectorField.SvsVamanaVectorField(NRedisStack.Search.FieldName! name, NRedisStack.Search.Schema.VectorField.VectorType type, int dimensions, NRedisStack.Search.Schema.VectorField.VectorDistanceMetric distanceMetric, System.Collections.Generic.Dictionary<string!, object!>? attributes = null, bool missingIndex = false) -> void
1382+
NRedisStack.Search.Schema.SvsVamanaVectorField.TrainingThreshold.get -> int
1383+
NRedisStack.Search.Schema.SvsVamanaVectorField.TrainingThreshold.set -> void
13841384
NRedisStack.Search.Schema.VectorField.Dimensions.get -> int
13851385
NRedisStack.Search.Schema.VectorField.Dimensions.set -> void
13861386
NRedisStack.Search.Schema.VectorField.DistanceMetric.get -> NRedisStack.Search.Schema.VectorField.VectorDistanceMetric

‎src/NRedisStack/PublicAPI/PublicAPI.Unshipped.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
#nullable enable
1+
#nullable enable

‎src/NRedisStack/Search/Schema.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ internal override void AddDirectAttributes(List<object> args)
533533
/// <summary>
534534
/// A <see cref="VectorField"/> that uses the <see cref="VectorField.VectorAlgo.SVS_VAMANA"/> algorithm.
535535
/// </summary>
536-
public class SvsVanamaVectorField(
536+
public class SvsVamanaVectorField(
537537
FieldName name,
538538
VectorType type,
539539
int dimensions,
@@ -890,17 +890,17 @@ public Schema AddHnswVectorField(FieldName name, VectorType type, int dimensions
890890
/// Add a <see href="VectorAlgo.SVS_VAMANA"/> vector to the schema.
891891
/// </summary>
892892
/// <remarks>Note that <c>reducedDimensions</c> is only applicable when using LeanVec compression.</remarks>
893-
public Schema AddSvsVanamaVectorField(FieldName name, VectorType type, int dimensions, VectorDistanceMetric distanceMetric,
893+
public Schema AddSvsVamanaVectorField(FieldName name, VectorType type, int dimensions, VectorDistanceMetric distanceMetric,
894894
VectorCompressionAlgorithm compressionAlgorithm = VectorCompressionAlgorithm.NotSpecified,
895-
int constructionWindowSize = SvsVanamaVectorField.DEFAULT_CONSTRUCTION_WINDOW_SIZE,
896-
int graphMaxDegree = SvsVanamaVectorField.DEFAULT_GRAPH_MAX_DEGREE,
897-
int searchWindowSize = SvsVanamaVectorField.DEFAULT_SEARCH_WINDOW_SIZE,
898-
double rangeSearchApproximationFactor = SvsVanamaVectorField.DEFAULT_EPSILON,
895+
int constructionWindowSize = SvsVamanaVectorField.DEFAULT_CONSTRUCTION_WINDOW_SIZE,
896+
int graphMaxDegree = SvsVamanaVectorField.DEFAULT_GRAPH_MAX_DEGREE,
897+
int searchWindowSize = SvsVamanaVectorField.DEFAULT_SEARCH_WINDOW_SIZE,
898+
double rangeSearchApproximationFactor = SvsVamanaVectorField.DEFAULT_EPSILON,
899899
int trainingThreshold = 0,
900900
int reducedDimensions = 0,
901901
Dictionary<string, object>? attributes = null, bool missingIndex = false)
902902
{
903-
Fields.Add(new SvsVanamaVectorField(name, type, dimensions, distanceMetric, attributes, missingIndex)
903+
Fields.Add(new SvsVamanaVectorField(name, type, dimensions, distanceMetric, attributes, missingIndex)
904904
{
905905
CompressionAlgorithm = compressionAlgorithm,
906906
ConstructionWindowSize = constructionWindowSize,

‎tests/NRedisStack.Tests/Search/IndexCreationTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -316,9 +316,9 @@ public void TestCreate_Float16_Int32_VectorField_Svs(string endpointId)
316316
IDatabase db = GetCleanDatabase(endpointId);
317317
// ReSharper disable once RedundantArgumentDefaultValue
318318
var ft = db.FT(2);
319-
var schema = new Schema().AddSvsVanamaVectorField("v", Schema.VectorField.VectorType.FLOAT16, 5,
319+
var schema = new Schema().AddSvsVamanaVectorField("v", Schema.VectorField.VectorType.FLOAT16, 5,
320320
Schema.VectorField.VectorDistanceMetric.EuclideanDistance)
321-
.AddSvsVanamaVectorField("v2", Schema.VectorField.VectorType.FLOAT32, 4,
321+
.AddSvsVamanaVectorField("v2", Schema.VectorField.VectorType.FLOAT32, 4,
322322
Schema.VectorField.VectorDistanceMetric.EuclideanDistance);
323323

324324
var cmd = SearchCommandBuilder.Create("idx", FTCreateParams.CreateParams(), schema).ToString();
@@ -350,10 +350,10 @@ public void TestCreate_Float16_Int32_VectorField_Svs_WithCompression(string endp
350350
IDatabase db = GetCleanDatabase(endpointId);
351351
// ReSharper disable once RedundantArgumentDefaultValue
352352
var ft = db.FT(2);
353-
var schema = new Schema().AddSvsVanamaVectorField("v", Schema.VectorField.VectorType.FLOAT16, 5,
353+
var schema = new Schema().AddSvsVamanaVectorField("v", Schema.VectorField.VectorType.FLOAT16, 5,
354354
Schema.VectorField.VectorDistanceMetric.EuclideanDistance,
355355
reducedDimensions: 2, compressionAlgorithm: Schema.VectorField.VectorCompressionAlgorithm.LeanVec4x8)
356-
.AddSvsVanamaVectorField("v2", Schema.VectorField.VectorType.FLOAT32, 4,
356+
.AddSvsVamanaVectorField("v2", Schema.VectorField.VectorType.FLOAT32, 4,
357357
Schema.VectorField.VectorDistanceMetric.EuclideanDistance,
358358
compressionAlgorithm: Schema.VectorField.VectorCompressionAlgorithm.LVQ4);
359359

@@ -387,7 +387,7 @@ public void TestIndexingCreation_Default()
387387
Schema.VectorField.VectorDistanceMetric.EuclideanDistance, missingIndex: true)
388388
.AddHnswVectorField("vector2", Schema.VectorField.VectorType.FLOAT64, 3,
389389
Schema.VectorField.VectorDistanceMetric.CosineDistance, missingIndex: false)
390-
.AddSvsVanamaVectorField("vector3", Schema.VectorField.VectorType.FLOAT16, 4,
390+
.AddSvsVamanaVectorField("vector3", Schema.VectorField.VectorType.FLOAT16, 4,
391391
Schema.VectorField.VectorDistanceMetric.InnerProduct, missingIndex: true);
392392

393393
var ftCreateParams = FTCreateParams.CreateParams();
@@ -430,7 +430,7 @@ public void TestIndexingCreation_Custom_Everything()
430430
Schema.VectorField.VectorDistanceMetric.CosineDistance,
431431
maxOutgoingConnections: 10, maxConnectedNeighbors: 20, maxTopCandidates: 30, boundaryFactor: 0.7,
432432
missingIndex: false)
433-
.AddSvsVanamaVectorField("vector3", Schema.VectorField.VectorType.FLOAT16, 4,
433+
.AddSvsVamanaVectorField("vector3", Schema.VectorField.VectorType.FLOAT16, 4,
434434
Schema.VectorField.VectorDistanceMetric.InnerProduct,
435435
compressionAlgorithm: Schema.VectorField.VectorCompressionAlgorithm.LeanVec4x8,
436436
constructionWindowSize: 35, graphMaxDegree: 17, searchWindowSize: 30,

0 commit comments

Comments
 (0)