Fix cluster routing of various commands (#445)

* - fix cluster routing
  - many operations were working by following `-MOVED`, which is inefficient (and causes a topology fetch for every miss, due to panic)
- change tests to disable `-MOVED` redirection; in tests, failure is preferable

* missed an endpointid in CI

* skip more FT.* ops in pre-8 cluster

* more FT.* pre-8 skips

Author: mgravell

src/NRedisStack/Auxiliary.cs

@@ -61,26 +61,31 @@ internal static void SetInfoInPipeline(this IDatabase db)
         }
     }
 
+#if DEBUG
+    private const CommandFlags Flags = CommandFlags.NoRedirect; // disable redirect, so we spot -MOVED in tests
+#else
+    private const CommandFlags Flags = CommandFlags.None;
+#endif
     public static RedisResult Execute(this IDatabase db, SerializedCommand command)
     {
         db.SetInfoInPipeline();
-        return db.Execute(command.Command, command.Args);
+        return db.Execute(command.Command, command.Args, flags: Flags);
     }
 
     internal static RedisResult Execute(this IServer server, int? db, SerializedCommand command)
     {
-        return server.Execute(db, command.Command, command.Args);
+        return server.Execute(db, command.Command, command.Args, flags: Flags);
     }
 
     public static async Task<RedisResult> ExecuteAsync(this IDatabaseAsync db, SerializedCommand command)
     {
         ((IDatabase)db).SetInfoInPipeline();
-        return await db.ExecuteAsync(command.Command, command.Args);
+        return await db.ExecuteAsync(command.Command, command.Args, flags: Flags);
     }
 
     internal static async Task<RedisResult> ExecuteAsync(this IServer server, int? db, SerializedCommand command)
     {
-        return await server.ExecuteAsync(db, command.Command, command.Args);
+        return await server.ExecuteAsync(db, command.Command, command.Args, flags: Flags);
     }
 
     public static List<RedisResult> ExecuteBroadcast(this IDatabase db, string command)

src/NRedisStack/Json/JsonCommandBuilder.cs

@@ -71,8 +71,8 @@ public static SerializedCommand Type(RedisKey key, string? path = null)
     public static SerializedCommand DebugMemory(string key, string? path = null)
     {
         return (path != null)
-            ? new(JSON.DEBUG, JSON.MEMORY, key, path)
-            : new SerializedCommand(JSON.DEBUG, JSON.MEMORY, key);
+            ? new(JSON.DEBUG, JSON.MEMORY, (RedisKey)key, path)
+            : new SerializedCommand(JSON.DEBUG, JSON.MEMORY, (RedisKey)key);
     }
 
     public static SerializedCommand ArrAppend(RedisKey key, string? path = null, params object[] values)

src/NRedisStack/Search/SearchCommandBuilder.cs

@@ -196,20 +196,20 @@ public static SerializedCommand SpellCheck(string indexName, string query, FTSpe
 
     public static SerializedCommand SugAdd(string key, string str, double score, bool increment = false, string? payload = null)
     {
-        var args = new List<object> { key, str, score };
+        var args = new List<object> { (RedisKey)key, str, score };
         if (increment) { args.Add(SearchArgs.INCR); }
         if (payload != null) { args.Add(SearchArgs.PAYLOAD); args.Add(payload); }
         return new(FT.SUGADD, args);
     }
 
     public static SerializedCommand SugDel(string key, string str)
     {
-        return new(FT.SUGDEL, key, str);
+        return new(FT.SUGDEL, (RedisKey)key, str);
     }
 
     public static SerializedCommand SugGet(string key, string prefix, bool fuzzy = false, bool withScores = false, bool withPayloads = false, int? max = null)
     {
-        var args = new List<object> { key, prefix };
+        var args = new List<object> { (RedisKey)key, prefix };
         if (fuzzy) { args.Add(SearchArgs.FUZZY); }
         if (withScores) { args.Add(SearchArgs.WITHSCORES); }
         if (withPayloads) { args.Add(SearchArgs.WITHPAYLOADS); }
@@ -219,7 +219,7 @@ public static SerializedCommand SugGet(string key, string prefix, bool fuzzy = f
 
     public static SerializedCommand SugLen(string key)
     {
-        return new(FT.SUGLEN, key);
+        return new(FT.SUGLEN, (RedisKey)key);
     }
 
     public static SerializedCommand SynDump(string indexName)

src/NRedisStack/Tdigest/TdigestCommandBuilder.cs

@@ -8,12 +8,11 @@ public static class TdigestCommandBuilder
 {
     public static SerializedCommand Add(RedisKey key, params double[] values)
     {
-        if (values.Length < 0) throw new ArgumentOutOfRangeException(nameof(values));
-        var args = new string[values.Length + 1];
-        args[0] = key.ToString();
+        var args = new object[values.Length + 1];
+        args[0] = key;
         for (int i = 0; i < values.Length; i++)
         {
-            args[i + 1] = values[i].ToString();
+            args[i + 1] = values[i];
         }
 
         return new(TDIGEST.ADD, args);

src/NRedisStack/TimeSeries/DataTypes/TSParameters.cs

@@ -1,5 +1,6 @@
 using NRedisStack.DataTypes;
 using NRedisStack.Literals.Enums;
+using StackExchange.Redis;
 
 namespace NRedisStack;
 
@@ -17,7 +18,7 @@ internal TsBaseParams(IList<object> parameters)
         this.parameters = parameters;
     }
 
-    internal object[] ToArray(string key)
+    internal object[] ToArray(RedisKey key)
     {
         parameters.Insert(0, key);
         return parameters.ToArray();