- remove cancelled

- assert ttl
- run till key disappears from search result

Author: atakavci

tests/NRedisStack.Tests/Search/SearchTests.cs

@@ -3443,31 +3443,30 @@ public async void TestDocumentLoadWithDB_Issue352(string endpointId)
         IDatabase db = GetCleanDatabase(endpointId);
         var ft = db.FT();
 
-        Schema sc = new Schema().AddTextField("first", 1.0).AddTextField("last", 1.0).AddNumericField("age");
+        Schema sc = new Schema().AddTextField("firstText", 1.0).AddTextField("lastText", 1.0).AddNumericField("ageNumeric");
         Assert.True(ft.Create(index, FTCreateParams.CreateParams(), sc));
 
         Document droppedDocument = null;
         int numberOfAttempts = 0;
-
         do
         {
             // try until succesfully create the key and set the TTL
             bool ttlRefreshed = false;
-            Int32 completed = 0;
-
             do
             {
-                db.HashSet("student:1111", new HashEntry[] { new("first", "Joe"), new("last", "Dod"), new("age", 18) });
-                ttlRefreshed = db.KeyExpire("student:1111", TimeSpan.FromMilliseconds(500));
+                db.HashSet("student:22222", new HashEntry[] { new("firstText", "Joe"), new("lastText", "Dod"), new("ageNumeric", 18) });
+                ttlRefreshed = db.KeyExpire("student:22222", TimeSpan.FromMilliseconds(500));
             } while (!ttlRefreshed);
 
-            Boolean cancelled = false;
+            Int32 completed = 0;
+
             Action checker = () =>
             {
-                for (int i = 0; i < 100000 && !cancelled; i++)
+                for (int i = 0; i < 1000000; i++)
                 {
                     SearchResult result = ft.Search(index, new Query());
                     List<Document> docs = result.Documents;
+
                     // check if doc is already dropped before search and load;
                     // if yes then its already late and we missed the window that 
                     // doc would show up in search result with no fields 
@@ -3477,30 +3476,28 @@ public async void TestDocumentLoadWithDB_Issue352(string endpointId)
                         break;
                     }
                     // if we get a document with no fields then we know that the key 
-                    // expired while the query is running, and we are able to catch the state
-                    // so we can break the loop
+                    // is going to be expired while the query is running, and we are able to catch the state
+                    // but key itself might not be expired yet
                     else if (docs[0].GetProperties().Count() == 0)
                     {
                         droppedDocument = docs[0];
-                        Interlocked.Increment(ref completed);
-                        break;
                     }
                 }
             };
 
             List<Task> tasks = new List<Task>();
             // try with 3 different tasks simultaneously to increase the chance of hitting it
-            for (int i = 0; i < 3; i++)
-            {
-                tasks.Add(Task.Run(checker));
-            }
+            for (int i = 0; i < 3; i++) { tasks.Add(Task.Run(checker)); }
             Task checkTask = Task.WhenAll(tasks);
-            await Task.WhenAny(checkTask, Task.Delay(1500));
+            await Task.WhenAny(checkTask, Task.Delay(1000));
+            var keyTtl = db.KeyTimeToLive("student:22222");
+            Assert.Equal(0, keyTtl.HasValue ? keyTtl.Value.Milliseconds : 0);
             Assert.Equal(3, completed);
-            cancelled = true;
         } while (droppedDocument == null && numberOfAttempts++ < 5);
-        // we wont do an actual assert here since 
+        // we won't do an actual assert here since 
         // it is not guaranteed that window stays open wide enough to catch it.
-        // instead we attempt 5 times 
+        // instead we attempt 5 times.
+        // Without fix for Issue352, document load in this case fails %100 with my local test runs,, and %100 success with fixed version.
+        // The results in pipeline should be the same.
     }
 }