Skip to content

Commit 6e39fcc

Browse files
authored
Merge branch 'master' into marc/build-cleanup
2 parents 44a4758 + 31373dd commit 6e39fcc

File tree

3 files changed

+20
-10
lines changed

3 files changed

+20
-10
lines changed

.github/actions/run-tests/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ runs:
5353
5454
# Mapping of redis version to stack version
5555
declare -A redis_stack_version_mapping=(
56-
["7.4.1"]="rs-7.4.0-v1"
57-
["7.2.6"]="rs-7.2.0-v13"
56+
["7.4.1"]="rs-7.4.0-v5"
57+
["7.2.6"]="rs-7.2.0-v17"
5858
["6.2.16"]="rs-6.2.6-v17"
5959
)
6060

.github/workflows/integration.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ concurrency:
1717

1818
env:
1919
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
20-
CURRENT_REDIS_VERSION: '7.4.1'
20+
CURRENT_REDIS_VERSION: '8.0.2'
2121

2222
jobs:
2323
redis_version:
@@ -37,8 +37,8 @@ jobs:
3737
max-parallel: 15
3838
fail-fast: false
3939
matrix:
40-
redis-version: [ '8.0-RC2-pre', '${{ needs.redis_version.outputs.CURRENT }}', '7.2.6', '6.2.16']
41-
dotnet-version: [ '8.0', '9.0']
40+
redis-version: [ '8.2-rc2-pre', '${{ needs.redis_version.outputs.CURRENT }}', '7.4.1', '7.2.6', '6.2.16']
41+
dotnet-version: ['8.0', '9.0']
4242
env:
4343
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
4444
name: Redis ${{ matrix.redis-version }}; .NET ${{ matrix.dotnet-version }};
@@ -59,7 +59,7 @@ jobs:
5959
strategy:
6060
fail-fast: false
6161
matrix:
62-
redis-stack-version: ['6.2.6-v18', '7.2.0-v14', '7.4.0-v2']
62+
redis-stack-version: ['6.2.6-v18', '7.2.0-v17', '7.4.0-v6']
6363
env:
6464
redis_stack_version: ${{matrix.redis-stack-version}}
6565
USER_NAME: ${{ secrets.USER_NAME }}

tests/NRedisStack.Tests/Core Commands/CoreTests.cs

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,14 @@ public void TestSetInfoNull(string endpointId)
104104
int infoAfterLibNameIndex = infoAfter.IndexOf("lib-name=");
105105
int infoBeforeLibNameIndex = infoBefore.IndexOf("lib-name=");
106106

107+
int infoAfterLibVerIndex = infoAfter.IndexOf(" ", infoAfter!.IndexOf("lib-ver="));
108+
infoAfterLibVerIndex = infoAfterLibVerIndex == -1 ? infoAfter.Length : infoAfterLibVerIndex;
109+
int infoBeforeLibVerIndex = infoBefore!.IndexOf(" ", infoBefore!.IndexOf("lib-ver="));
110+
infoBeforeLibVerIndex = infoBeforeLibVerIndex == -1 ? infoBefore.Length : infoBeforeLibVerIndex;
111+
107112
// Extract the sub-strings starting from "lib-name="
108-
string infoAfterLibNameToEnd = infoAfter.Substring(infoAfterLibNameIndex);
109-
string infoBeforeLibNameToEnd = infoBefore.Substring(infoBeforeLibNameIndex);
113+
string infoAfterLibNameToEnd = infoAfter.Substring(infoAfterLibNameIndex, infoAfterLibVerIndex - infoAfterLibNameIndex);
114+
string infoBeforeLibNameToEnd = infoBefore.Substring(infoBeforeLibNameIndex, infoBeforeLibVerIndex - infoBeforeLibNameIndex);
110115

111116
// Assert that the extracted sub-strings are equal
112117
Assert.Equal(infoAfterLibNameToEnd, infoBeforeLibNameToEnd);
@@ -127,9 +132,14 @@ public async Task TestSetInfoNullAsync(string endpointId)
127132
int infoAfterLibNameIndex = infoAfter.IndexOf("lib-name=");
128133
int infoBeforeLibNameIndex = infoBefore.IndexOf("lib-name=");
129134

135+
int infoAfterLibVerIndex = infoAfter.IndexOf(" ", infoAfter!.IndexOf("lib-ver="));
136+
infoAfterLibVerIndex = infoAfterLibVerIndex == -1 ? infoAfter.Length : infoAfterLibVerIndex;
137+
int infoBeforeLibVerIndex = infoBefore.IndexOf(" ", infoBefore!.IndexOf("lib-ver="));
138+
infoBeforeLibVerIndex = infoBeforeLibVerIndex == -1 ? infoBefore.Length : infoBeforeLibVerIndex;
139+
130140
// Extract the sub-strings starting from "lib-name="
131-
string infoAfterLibNameToEnd = infoAfter.Substring(infoAfterLibNameIndex);
132-
string infoBeforeLibNameToEnd = infoBefore.Substring(infoBeforeLibNameIndex);
141+
string infoAfterLibNameToEnd = infoAfter.Substring(infoAfterLibNameIndex, infoAfterLibVerIndex - infoAfterLibNameIndex);
142+
string infoBeforeLibNameToEnd = infoBefore.Substring(infoBeforeLibNameIndex, infoBeforeLibVerIndex - infoBeforeLibNameIndex);
133143

134144
// Assert that the extracted sub-strings are equal
135145
Assert.Equal(infoAfterLibNameToEnd, infoBeforeLibNameToEnd);

0 commit comments

Comments
 (0)