ensure integration tests use the VectorData API

Author: mgravell

src/NRedisStack/PublicAPI/PublicAPI.Unshipped.txt

@@ -1,5 +1,6 @@
 NRedisStack.Search.Parameters
 static NRedisStack.Search.Parameters.From<T>(T obj) -> System.Collections.Generic.IReadOnlyDictionary<string!, object!>!
+[NRS001]abstract NRedisStack.Search.VectorData.AsRedisValue() -> StackExchange.Redis.RedisValue
 [NRS001]abstract NRedisStack.Search.VectorData<T>.Dispose() -> void
 [NRS001]abstract NRedisStack.Search.VectorData<T>.Span.get -> System.Span<T>
 [NRS001]const NRedisStack.Search.HybridSearchQuery.Fields.Key = "@__key" -> string!

src/NRedisStack/Search/VectorData.cs

@@ -18,7 +18,6 @@ internal sealed class VectorBytesData(int byteLength) : VectorData<T>
     {
         private byte[]? _oversized = ArrayPool<byte>.Shared.Rent(byteLength);
         public override Span<T> Span => MemoryMarshal.Cast<byte, T>(Array.AsSpan(0, byteLength));
-        internal override object GetSingleArg() => (RedisValue)new ReadOnlyMemory<byte>(Array,  0, byteLength);
 
         private byte[] Array => _oversized ?? ThrowDisposed();
         static byte[] ThrowDisposed() => throw new ObjectDisposedException(nameof(VectorData));
@@ -28,6 +27,7 @@ public override void Dispose()
             _oversized = null;
             if (tmp is not null) ArrayPool<byte>.Shared.Return(tmp);
         }
+        public override RedisValue AsRedisValue() => (RedisValue)new ReadOnlyMemory<byte>(Array,  0, byteLength);
     }
 
     public abstract void Dispose();
@@ -38,7 +38,8 @@ public abstract class VectorData
 {
     /// <summary>
     /// Lease a vector that can hold values of <typeparamref name="T"/>.
-    /// No quantization occurs - the data is transmitted as the raw bytes of the corresponding size.
+    /// No quantization occurs - the data is transmitted as the raw bytes of the corresponding size; for
+    /// example, to use FLOAT16 encoding, the <c>Half</c> type might be used.
     /// </summary>
     /// <param name="dimension">The number of values to be held.</param>
     /// <typeparam name="T">The data type to be represented</typeparam>
@@ -65,6 +66,11 @@ private protected VectorData()
     {
     }
 
+    /// <summary>
+    /// Gets the underlying payload of this vector as a <see cref="RedisValue"/>.
+    /// </summary>
+    public abstract RedisValue AsRedisValue();
+
     /// <summary>
     /// A raw vector payload.
     /// </summary>
@@ -88,14 +94,14 @@ private protected VectorData()
     /// <inheritdoc cref="Parameter"/>
     public static implicit operator VectorData(string name) => new VectorParameter(name);
 
-    internal abstract object GetSingleArg();
+    internal virtual object GetSingleArg() => AsRedisValue();
 
     /// <inheritdoc/>
     public override string ToString() => GetType().Name;
 
     private sealed class VectorDataRaw(ReadOnlyMemory<byte> bytes) : VectorData
     {
-        internal override object GetSingleArg() => (RedisValue)bytes;
+        public override RedisValue AsRedisValue() => (RedisValue)bytes;
     }
 
     private sealed class VectorParameter : VectorData
@@ -110,7 +116,8 @@ public VectorParameter(string name)
         }
 
         public override string ToString() => name;
-        internal override object GetSingleArg() => name;
+        internal override object GetSingleArg() => name; // note type is string, not RedisValue
+        public override RedisValue AsRedisValue() => name;
     }
 
     private protected static void ThrowBigEndian() =>

tests/NRedisStack.Tests/Search/HybridSearchIntegrationTests.cs

@@ -54,29 +54,25 @@ private async Task<Api> CreateIndexAsync(string endpointId, [CallerMemberName] s
         if (populate)
         {
 #if NET
-            Task last = Task.CompletedTask;
             var rand = new Random(12345);
             string[] tags = ["foo", "bar", "blap"];
+            using var vectorData = VectorData.Lease<Half>(V1DIM);
             for (int i = 0; i < 16; i++)
             {
-                byte[] vec = new byte[V1DIM * sizeof(ushort)];
-                var halves = MemoryMarshal.Cast<byte, Half>(vec);
-                for (int j = 1; j < V1DIM; j++)
+                foreach (ref Half val in vectorData.Span)
                 {
-                    halves[j] = (Half)rand.NextDouble();
+                    val = (Half)rand.NextDouble();
                 }
 
                 HashEntry[] entry =
                 [
                     new("text1", $"Search entry {i}"),
                     new("tag1", tags[rand.Next(tags.Length)]),
                     new("numeric1", rand.Next(0, 32)),
-                    new("vector1", vec)
+                    new("vector1", vectorData.AsRedisValue())
                 ];
-                last = db.HashSetAsync($"{index}_entry{i}", entry);
+                await db.HashSetAsync($"{index}_entry{i}", entry);
             }
-
-            await last;
 #else
             // throw SkipException.ForSkip("FP16 not supported");
             return default;