Skip to content

Commit 0146d80

Browse files
committed
Merge branch 'main' into build/mac_apple_store
# Conflicts: # redisinsight/ui/src/packages/clients-list/yarn.lock # redisinsight/ui/src/packages/redisgraph/src/styles/styles.less # redisinsight/ui/src/packages/redistimeseries-app/src/index.html
2 parents f25661d + c941cf6 commit 0146d80

File tree

9 files changed

+45
-29
lines changed

9 files changed

+45
-29
lines changed

.circleci/config.yml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,22 @@ jobs:
700700
- run:
701701
name: Build Docker image (API + UI)
702702
command: |
703-
docker build --build-arg NODE_ENV=<< parameters.env >> --build-arg SERVER_TLS_CERT="$SERVER_TLS_CERT" --build-arg SERVER_TLS_KEY="$SERVER_TLS_KEY" -t riv2:latest .
703+
TELEMETRY=$SEGMENT_WRITE_KEY_DEV
704+
705+
if [ << parameters.env >> == 'production' ]; then
706+
TELEMETRY=$SEGMENT_WRITE_KEY
707+
fi
708+
709+
if [ << parameters.env >> == 'staging' ]; then
710+
TELEMETRY=$SEGMENT_WRITE_KEY_STAGE
711+
fi
712+
713+
docker build --build-arg NODE_ENV=<< parameters.env >> \
714+
--build-arg SERVER_TLS_CERT="$SERVER_TLS_CERT" \
715+
--build-arg SERVER_TLS_KEY="$SERVER_TLS_KEY" \
716+
--build-arg SEGMENT_WRITE_KEY="$TELEMETRY" \
717+
-t riv2:latest .
718+
704719
mkdir -p docker-release
705720
docker image save -o docker-release/docker.tar riv2
706721
- persist_to_workspace:

Dockerfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ COPY redisinsight ./redisinsight
1313
RUN yarn --cwd redisinsight/api
1414
ARG SERVER_TLS_CERT
1515
ARG SERVER_TLS_KEY
16+
ARG SEGMENT_WRITE_KEY
1617
ENV SERVER_TLS_CERT=${SERVER_TLS_CERT}
1718
ENV SERVER_TLS_KEY=${SERVER_TLS_KEY}
19+
ENV SEGMENT_WRITE_KEY=${SEGMENT_WRITE_KEY}
1820
RUN yarn build:web
1921
RUN yarn build:statics
2022

@@ -61,8 +63,10 @@ RUN dbus-uuidgen > /var/lib/dbus/machine-id
6163
ARG NODE_ENV=production
6264
ARG SERVER_TLS_CERT
6365
ARG SERVER_TLS_KEY
66+
ARG SEGMENT_WRITE_KEY
6467
ENV SERVER_TLS_CERT=${SERVER_TLS_CERT}
6568
ENV SERVER_TLS_KEY=${SERVER_TLS_KEY}
69+
ENV SEGMENT_WRITE_KEY=${SEGMENT_WRITE_KEY}
6670
ENV NODE_ENV=${NODE_ENV}
6771
ENV SERVER_STATIC_CONTENT=true
6872
ENV BUILD_TYPE='DOCKER_ON_PREMISE'

redisinsight/ui/src/packages/clients-list/yarn.lock

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -994,9 +994,9 @@
994994
integrity sha512-BdZ5BCCvho3EIXw6wUCXHe7rS53AIDPLE+JzwgT+OsJk53oBfbSmZZ7CX4VaRoN78N+TJpFi9QPlfIVNmJYWxQ==
995995

996996
"@types/mdast@^3.0.0":
997-
version "3.0.10"
998-
resolved "https://registry.yarnpkg.com/@types/mdast/-/mdast-3.0.10.tgz#4724244a82a4598884cbbe9bcfd73dff927ee8af"
999-
integrity sha512-W864tg/Osz1+9f4lrGTZpCSO5/z4608eUp19tbozkq2HJK6i3z1kT0H9tlADXuYIb1YYOBByU4Jsqkk75q48qA==
997+
version "3.0.11"
998+
resolved "https://registry.yarnpkg.com/@types/mdast/-/mdast-3.0.11.tgz#dc130f7e7d9306124286f6d6cee40cf4d14a3dc0"
999+
integrity sha512-Y/uImid8aAwrEA24/1tcRZwpxX3pIFTSilcNDKSPn+Y2iDywSEachzRuvgAYYLR3wpGXAsMbv5lvKLDZLeYPAw==
10001000
dependencies:
10011001
"@types/unist" "*"
10021002

@@ -1031,9 +1031,9 @@
10311031
integrity sha512-JCB8C6SnDoQf0cNycqd/35A7MjcnK+ZTqE7judS6o7utxUCg6imJg3QK2qzHKszlTjcj2cn+NwMB2i96ubpj7w==
10321032

10331033
"@types/react-beautiful-dnd@^13.0.0":
1034-
version "13.1.3"
1035-
resolved "https://registry.yarnpkg.com/@types/react-beautiful-dnd/-/react-beautiful-dnd-13.1.3.tgz#9812f6086c4b77ce08c83120788d92084a26db0f"
1036-
integrity sha512-BNdmvONKtsrZq3AGrujECQrIn8cDT+fZsxBLXuX3YWY/nHfZinUFx4W88eS0rkcXzuLbXpKOsu/1WCMPMLEpPg==
1034+
version "13.1.4"
1035+
resolved "https://registry.yarnpkg.com/@types/react-beautiful-dnd/-/react-beautiful-dnd-13.1.4.tgz#bcec72da719c18c0d8b4a7cb00e7fb443211d6d7"
1036+
integrity sha512-4bIBdzOr0aavN+88q3C7Pgz+xkb7tz3whORYrmSj77wfVEMfiWiooIwVWFR7KM2e+uGTe5BVrXqSfb0aHeflJA==
10371037
dependencies:
10381038
"@types/react" "*"
10391039

@@ -1239,9 +1239,9 @@ callsites@^3.0.0:
12391239
integrity sha512-P8BjAsXvZS+VIDUI11hHCQEv74YT67YUi5JJFNWIqL235sBmjX4+qx9Muvls5ivyNENctx46xQLQ3aTuE7ssaQ==
12401240

12411241
caniuse-lite@^1.0.30001449:
1242-
version "1.0.30001468"
1243-
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001468.tgz#0101837c6a4e38e6331104c33dcfb3bdf367a4b7"
1244-
integrity sha512-zgAo8D5kbOyUcRAgSmgyuvBkjrGk5CGYG5TYgFdpQv+ywcyEpo1LOWoG8YmoflGnh+V+UsNuKYedsoYs0hzV5A==
1242+
version "1.0.30001469"
1243+
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001469.tgz#3dd505430c8522fdc9f94b4a19518e330f5c945a"
1244+
integrity sha512-Rcp7221ScNqQPP3W+lVOYDyjdR6dC+neEQCttoNr5bAyz54AboB4iwpnWgyi8P4YUsPybVzT4LgWiBbI3drL4g==
12451245

12461246
ccount@^1.0.0:
12471247
version "1.1.0"
@@ -1536,9 +1536,9 @@ dotenv@^7.0.0:
15361536
integrity sha512-M3NhsLbV1i6HuGzBUH8vXrtxOk+tWmzWKDMbAVSUp3Zsjm7ywFeuwrUXhmhQyRK1q5B5GGy7hcXPbj3bnfZg2g==
15371537

15381538
electron-to-chromium@^1.4.284:
1539-
version "1.4.333"
1540-
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.333.tgz#ebb21f860f8a29923717b06ec0cb54e77ed34c04"
1541-
integrity sha512-YyE8+GKyGtPEP1/kpvqsdhD6rA/TP1DUFDN4uiU/YI52NzDxmwHkEb3qjId8hLBa5siJvG0sfC3O66501jMruQ==
1539+
version "1.4.335"
1540+
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.335.tgz#69c08baa608bbb58e290d83320190fa82c835efe"
1541+
integrity sha512-l/eowQqTnrq3gu+WSrdfkhfNHnPgYqlKAwxz7MTOj6mom19vpEDHNXl6dxDxyTiYuhemydprKr/HCrHfgk+OfQ==
15421542

15431543
emoji-regex@^8.0.0:
15441544
version "8.0.0"
@@ -2817,7 +2817,7 @@ term-size@^2.2.1:
28172817
resolved "https://registry.yarnpkg.com/term-size/-/term-size-2.2.1.tgz#2a6a54840432c2fb6320fea0f415531e90189f54"
28182818
integrity sha512-wK0Ri4fOGjv/XPy8SBHZChl8CM7uMc5VML7SqiQ0zG7+J5Vr+RMQDoHa2CNT6KHUnTGIXH34UDMkPzAUyapBZg==
28192819

2820-
terser@^5.16.8, terser@^5.2.0:
2820+
terser@^5.16.6, terser@^5.2.0:
28212821
version "5.16.6"
28222822
resolved "https://registry.yarnpkg.com/terser/-/terser-5.16.6.tgz#f6c7a14a378ee0630fbe3ac8d1f41b4681109533"
28232823
integrity sha512-IBZ+ZQIA9sMaXmRZCUMDjNH0D5AQQfdn4WUjHL0+1lF4TP1IHRJbrhb6fNaXWikrYQTSkb7SLxkeXAiy1p7mbg==

redisinsight/ui/src/packages/redistimeseries-app/src/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
<meta name="viewport" content="width=device-width, initial-scale=1.0">
77
<title>Client list plugin</title>
88
<script type="module" src="./main.tsx"></script>
9-
<!-- <link rel="stylesheet" href="../../../../../../vendor/global_styles.css" />
10-
<link rel="stylesheet" href="../../../../../../vendor/dark_theme.css" /> -->
9+
<!-- <link rel="stylesheet" href="../../../../../../vendor/global_styles.css" /> -->
10+
<!-- <link rel="stylesheet" href="../../../../../../vendor/dark_theme.css" /> -->
1111
<!-- <link rel="stylesheet" href="../../../../../../vendor/light_theme.css" /> -->
1212
<link rel="stylesheet" href="./styles/styles.scss" />
1313

redisinsight/ui/src/services/apiService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import axios, { AxiosRequestConfig } from 'axios'
2+
import { isNumber } from 'lodash'
23
import { sessionStorageService } from 'uiSrc/services'
34
import { BrowserStorageItem } from 'uiSrc/constants'
4-
import { isNumber } from 'lodash'
55

66
const baseApiUrl = process.env.BASE_API_URL
77
const apiPort = process.env.API_PORT
@@ -20,7 +20,7 @@ const axiosInstance = axios.create({
2020

2121
export const requestInterceptor = (config: AxiosRequestConfig) => {
2222
if (config?.headers) {
23-
const [instanceId] = (/(?<=databases\/)(.*?)(?=\/)/gi).exec(config.url || '') || []
23+
const instanceId = /databases\/([\w-]+)\/?.*/.exec(config.url || '')?.[1]
2424

2525
if (instanceId) {
2626
const dbIndex = sessionStorageService.get(`${BrowserStorageItem.dbIndex}${instanceId}`)

redisinsight/ui/src/services/tests/apiService.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1+
import { AxiosRequestConfig } from 'axios'
12
import { sessionStorageService } from 'uiSrc/services'
23
import { requestInterceptor } from 'uiSrc/services/apiService'
3-
import { AxiosRequestConfig } from 'axios'
44

55
describe('requestInterceptor', () => {
66
it('should properly set db-index to headers', () => {
77
sessionStorageService.get = jest.fn().mockReturnValue(5)
88

99
const config: AxiosRequestConfig = {
1010
headers: {},
11-
url: 'http://localhost:8080/databases/instanceId/endpoint'
11+
url: 'http://localhost:8080/databases/123-215gg-23/endpoint'
1212
}
1313

1414
requestInterceptor(config)
@@ -20,7 +20,7 @@ describe('requestInterceptor', () => {
2020

2121
const config: AxiosRequestConfig = {
2222
headers: {},
23-
url: 'http://localhost:8080/settings/instanceId/endpoint'
23+
url: 'http://localhost:8080/settings/123-215gg-23/endpoint'
2424
}
2525

2626
requestInterceptor(config)

tests/e2e/tests/critical-path/workbench/default-scripts-area.e2e.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,8 @@ test
5151
await t.click(workbenchPage.internalLinkWorkingWithHashes);
5252

5353
// Verify that telemetry event 'WORKBENCH_ENABLEMENT_AREA_GUIDE_OPENED' sent and has all expected properties
54-
// unskip after closing https://redislabs.atlassian.net/browse/RI-4281
55-
// await telemetry.verifyEventHasProperties(telemetryEvent, expectedProperties, logger);
56-
// await telemetry.verifyEventPropertyValue(telemetryEvent, 'path', telemetryPath, logger);
54+
await telemetry.verifyEventHasProperties(telemetryEvent, expectedProperties, logger);
55+
await telemetry.verifyEventPropertyValue(telemetryEvent, 'path', telemetryPath, logger);
5756

5857
await t.click(workbenchPage.preselectIndexInformation);
5958
// Replace the {index} with indexName value in script and send

tests/e2e/tests/smoke/browser/edit-key-name.e2e.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,8 @@ test
4141
await t.expect(keyNameFromDetails).contains(keyNameBefore, 'The String Key Name not correct before editing');
4242

4343
// Verify that telemetry event 'BROWSER_KEY_VALUE_VIEWED' sent and has all expected properties
44-
// unskip after closing https://redislabs.atlassian.net/browse/RI-4281
45-
// await telemetry.verifyEventHasProperties(telemetryEvent, expectedProperties, logger);
46-
// await telemetry.verifyEventPropertyValue(telemetryEvent, 'keyType', 'string', logger);
44+
await telemetry.verifyEventHasProperties(telemetryEvent, expectedProperties, logger);
45+
await telemetry.verifyEventPropertyValue(telemetryEvent, 'keyType', 'string', logger);
4746

4847
await browserPage.editKeyName(keyNameAfter);
4948
keyNameFromDetails = await browserPage.keyNameFormDetails.textContent;

tests/e2e/tests/smoke/database/add-standalone-db.e2e.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ test
7272
await myRedisDatabasePage.clickOnDBByName(ossStandaloneConfig.databaseName);
7373

7474
// Verify that telemetry event 'CONFIG_DATABASES_OPEN_DATABASE' sent and has all expected properties
75-
// // unskip after closing https://redislabs.atlassian.net/browse/RI-4281
76-
// await telemetry.verifyEventHasProperties(telemetryEvent, expectedProperties, logger);
75+
await telemetry.verifyEventHasProperties(telemetryEvent, expectedProperties, logger);
7776

7877
await t.click(browserPage.myRedisDbIcon);
7978
// Verify that user can't see an indicator of databases that were opened

0 commit comments

Comments
 (0)