Skip to content

Commit 05a398e

Browse files
author
Artem
committed
#RI-5447 fix timeout overwritten during connection [skip ci]
1 parent 7730ef7 commit 05a398e

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

redisinsight/api/src/modules/database/database-connection.service.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ export class DatabaseConnectionService {
3535
const toUpdate: Partial<Database> = {
3636
new: false,
3737
lastConnection: new Date(),
38-
timeout: client.options.connectTimeout,
3938
modules: await this.databaseInfoProvider.determineDatabaseModules(client),
4039
version: await this.databaseInfoProvider.determineDatabaseServer(client),
4140
};

redisinsight/api/src/modules/database/models/database.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import { SentinelMaster } from 'src/modules/redis-sentinel/models/sentinel-maste
2121
import { Endpoint } from 'src/common/models';
2222
import { AdditionalRedisModule } from 'src/modules/database/models/additional.redis.module';
2323
import { SshOptions } from 'src/modules/ssh/models/ssh-options';
24-
import { Default } from 'src/common/decorators';
2524
import { CloudDatabaseDetails } from 'src/modules/cloud/database/models/cloud-database-details';
2625

2726
const CONNECTIONS_CONFIG = config.get('connections');
@@ -110,7 +109,6 @@ export class Database {
110109
@Min(1_000)
111110
@Max(1_000_000_000)
112111
@IsInt({ always: true })
113-
@Default(CONNECTIONS_CONFIG.timeout)
114112
timeout?: number = CONNECTIONS_CONFIG.timeout;
115113

116114
@ApiProperty({

redisinsight/api/src/modules/database/repositories/local.database.repository.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,13 @@ export class LocalDatabaseRepository extends DatabaseRepository {
128128
*/
129129
public async update(id: string, database: Partial<Database>): Promise<Database> {
130130
const oldEntity = await this.decryptEntity((await this.repository.findOneBy({ id })), true);
131+
console.log('___ oldEntity', oldEntity)
131132
const newEntity = classToClass(DatabaseEntity, await this.populateCertificates(database as Database));
132133

134+
console.log('___ newEntity', newEntity)
135+
133136
const mergeResult = this.repository.merge(oldEntity, newEntity);
137+
console.log('___ mergeResult', mergeResult)
134138

135139
if (newEntity.caCert === null) {
136140
mergeResult.caCert = null;
@@ -146,6 +150,7 @@ export class LocalDatabaseRepository extends DatabaseRepository {
146150

147151
const encrypted = await this.encryptEntity(mergeResult);
148152

153+
console.log('___ encrypted', encrypted)
149154
await this.repository.save(encrypted);
150155

151156
// workaround for one way cascade deletion

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10642,11 +10642,6 @@ minipass@^3.0.0, minipass@^3.1.0, minipass@^3.1.1, minipass@^3.1.3, minipass@^3.
1064210642
dependencies:
1064310643
yallist "^4.0.0"
1064410644

10645-
minipass@^4.0.0:
10646-
version "4.2.8"
10647-
resolved "https://registry.yarnpkg.com/minipass/-/minipass-4.2.8.tgz#f0010f64393ecfc1d1ccb5f582bcaf45f48e1a3a"
10648-
integrity sha512-fNzuVyifolSLFL4NzpF+wEF4qrgqaaKX0haXPQEdQ7NKAN+WecoKMHV09YcuL/DHxrUsYQOK3MiuDf7Ip2OXfQ==
10649-
1065010645
minipass@^5.0.0:
1065110646
version "5.0.0"
1065210647
resolved "https://registry.yarnpkg.com/minipass/-/minipass-5.0.0.tgz#3e9788ffb90b694a5d0ec94479a45b5d8738133d"

0 commit comments

Comments
 (0)