Skip to content

Commit 05cb043

Browse files
authored
Merge pull request #1660 from RedisInsight/release/2.18.0
Release/2.18.0 into main
2 parents 559b589 + 163b145 commit 05cb043

File tree

6 files changed

+1648
-1541
lines changed

6 files changed

+1648
-1541
lines changed

redisinsight/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "redisinsight",
33
"productName": "RedisInsight",
44
"private": true,
5-
"version": "2.16.0",
5+
"version": "2.18.0",
66
"description": "RedisInsight",
77
"main": "./main.prod.js",
88
"author": {

tests/e2e/helpers/keys.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export async function deleteKeysViaCli(keyData: KeyData): Promise<void> {
8282
* @param keyArguments The arguments of key
8383
*/
8484
export async function populateDBWithHashes(host: string, port: string, keyArguments: AddKeyArguments): Promise<void> {
85-
const dbConf = { host, port: Number(port) };
85+
const dbConf = { port: Number.parseInt(port), host, username: 'default' };
8686
const client = createClient(dbConf);
8787

8888
await client.on('error', async function (error: string) {
@@ -110,7 +110,7 @@ export async function populateDBWithHashes(host: string, port: string, keyArgume
110110
* @param keyArguments The arguments of key and its fields
111111
*/
112112
export async function populateHashWithFields(host: string, port: string, keyArguments: AddKeyArguments): Promise<void> {
113-
const dbConf = { host, port: Number(port) };
113+
const dbConf = { port: Number.parseInt(port), host, username: 'default' };
114114
const client = createClient(dbConf);
115115
const fields: string[] = [];
116116

@@ -141,7 +141,7 @@ export async function populateHashWithFields(host: string, port: string, keyArgu
141141
* @param keyArguments The arguments of key and its members
142142
*/
143143
export async function populateListWithElements(host: string, port: string, keyArguments: AddKeyArguments): Promise<void> {
144-
const dbConf = { host, port: Number(port) };
144+
const dbConf = { port: Number.parseInt(port), host, username: 'default' };
145145
const client = createClient(dbConf);
146146
const elements: string[] = [];
147147

@@ -171,7 +171,7 @@ export async function populateListWithElements(host: string, port: string, keyAr
171171
* @param keyArguments The arguments of key and its members
172172
*/
173173
export async function populateSetWithMembers(host: string, port: string, keyArguments: AddKeyArguments): Promise<void> {
174-
const dbConf = { host, port: Number(port) };
174+
const dbConf = { port: Number.parseInt(port), host, username: 'default' };
175175
const client = createClient(dbConf);
176176
const members: string[] = [];
177177

@@ -201,7 +201,7 @@ export async function populateSetWithMembers(host: string, port: string, keyArgu
201201
* @param keyArguments The arguments of key and its members
202202
*/
203203
export async function populateZSetWithMembers(host: string, port: string, keyArguments: AddKeyArguments): Promise<void> {
204-
const dbConf = { host, port: Number(port) };
204+
const dbConf = { port: Number.parseInt(port), host, username: 'default' };
205205
let minScoreValue: -10;
206206
let maxScoreValue: 10;
207207
const client = createClient(dbConf);
@@ -233,7 +233,7 @@ export async function populateSetWithMembers(host: string, port: string, keyArgu
233233
* @param port The port of database
234234
*/
235235
export async function deleteAllKeysFromDB(host: string, port: string): Promise<void> {
236-
const dbConf = { host, port: Number(port) };
236+
const dbConf = { port: Number.parseInt(port), host, username: 'default' };
237237
const client = createClient(dbConf);
238238

239239
await client.on('error', async function (error: string) {

tests/e2e/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"eslint": "7.32.0",
3939
"eslint-plugin-import": "2.24.2",
4040
"sqlite3": "5.0.10",
41-
"redis": "^3.0.2",
41+
"redis": "3.0.2",
4242
"supertest": "^4.0.2",
4343
"testcafe": "1.14.2",
4444
"testcafe-browser-provider-electron": "0.0.18",

tests/e2e/tests/critical-path/browser/bulk-delete.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ test('Verify that user can access the bulk actions screen in the Browser', async
5656
});
5757
test('Verify that user can see summary of scanned level', async t => {
5858
const expectedAmount = new RegExp('Expected amount: ~(9|10) \\d{3} keys');
59-
const scannedKeys = new RegExp('Scanned (5|10)% \\((500|1000)/10 \\d{3}\\) and found \\d{3,5} keys');
59+
const scannedKeys = new RegExp('Scanned (5|10)% \\((500|1 000)/10 \\d{3}\\) and found \\d{3,5} keys');
6060
const messageTitle = 'No pattern or key type set';
6161
const messageText = 'To perform a bulk action, set the pattern or select the key type';
6262

tests/e2e/tests/regression/monitor/monitor.e2e.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
ossStandaloneNoPermissionsConfig
1515
} from '../../../helpers/conf';
1616
import { rte } from '../../../helpers/constants';
17-
import { addNewStandaloneDatabaseApi, deleteStandaloneDatabaseApi } from '../../../helpers/api/api-database';
17+
import { addNewStandaloneDatabaseApi, deleteStandaloneDatabaseApi, deleteStandaloneDatabasesApi } from '../../../helpers/api/api-database';
1818
import { Common } from '../../../helpers/common';
1919

2020
const myRedisDatabasePage = new MyRedisDatabasePage();
@@ -115,25 +115,27 @@ test
115115
await t.expect(previousTimestamp).notEql(nextTimestamp, 'Monitor results not correct');
116116
}
117117
});
118-
test
118+
// Skipped due to redis issue https://redislabs.atlassian.net/browse/RI-4111
119+
test.skip
119120
.before(async t => {
120121
await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig, ossStandaloneConfig.databaseName);
121122
await cliPage.sendCommandInCli('acl setuser noperm nopass on +@all ~* -monitor');
122123
// Check command result in CLI
123124
await t.click(cliPage.cliExpandButton);
124125
await t.expect(cliPage.cliOutputResponseSuccess.textContent).eql('"OK"', 'Command from autocomplete was not found & executed');
125126
await t.click(cliPage.cliCollapseButton);
126-
await deleteStandaloneDatabaseApi(ossStandaloneConfig);
127127
await t.click(myRedisDatabasePage.myRedisDBButton);
128128
await addNewStandaloneDatabaseApi(ossStandaloneNoPermissionsConfig);
129129
await common.reloadPage();
130130
await myRedisDatabasePage.clickOnDBByName(ossStandaloneNoPermissionsConfig.databaseName);
131131
})
132-
.after(async() => {
132+
.after(async t => {
133133
// Delete created user
134+
await t.click(myRedisDatabasePage.myRedisDBButton);
135+
await myRedisDatabasePage.clickOnDBByName(ossStandaloneConfig.databaseName);
134136
await cliPage.sendCommandInCli('acl DELUSER noperm');
135137
// Delete database
136-
await deleteStandaloneDatabaseApi(ossStandaloneNoPermissionsConfig);
138+
await deleteStandaloneDatabasesApi([ossStandaloneConfig, ossStandaloneNoPermissionsConfig]);
137139
})('Verify that if user doesn\'t have permissions to run monitor, user can see error message', async t => {
138140
// Expand the Profiler
139141
await t.click(monitorPage.expandMonitor);

0 commit comments

Comments
 (0)