Skip to content

Commit 07709bf

Browse files
authored
Merge pull request #2189 from RedisInsight/e2e/bugfix/nightly-tests-fixes
e2e/nightly tests fixes
2 parents d5b4033 + c4aab50 commit 07709bf

File tree

6 files changed

+12
-13
lines changed

6 files changed

+12
-13
lines changed

tests/e2e/pageObjects/pub-sub-page.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,11 @@ export class PubSubPage extends InstancePage {
3434
* @param message The message
3535
*/
3636
async publishMessage(channel: string, message: string): Promise<void> {
37-
await t
38-
.click(this.channelNameInput)
39-
.typeText(this.channelNameInput, channel, { replace: true, paste: true })
40-
.click(this.messageInput)
41-
.typeText(this.messageInput, message, { replace: true, paste: true })
42-
.click(this.publishButton);
37+
await t.click(this.channelNameInput);
38+
await t.typeText(this.channelNameInput, channel, { replace: true, paste: true });
39+
await t.click(this.messageInput);
40+
await t.typeText(this.messageInput, message, { replace: true, paste: true });
41+
await t.click(this.publishButton);
4342
}
4443

4544
/**
@@ -50,6 +49,6 @@ export class PubSubPage extends InstancePage {
5049
async subsribeToChannelAndPublishMessage(channel: string, message: string): Promise<void> {
5150
await t.click(this.subscribeButton);
5251
await this.publishMessage(channel, message);
53-
await t.expect(this.pubSubPageContainer.find('[data-testid^=row]').withText('message').exists).ok('Message is not displayed');
52+
await t.expect((this.pubSubPageContainer.find('[data-testid^=row]').withText('message')).exists).ok('Message is not displayed');
5453
}
5554
}

tests/e2e/static-server.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:latest
1+
FROM node:16.15.1-alpine
22

33
WORKDIR /app
44

tests/e2e/test-data/features-configs/insights-default-remote.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": 0.9,
2+
"version": 1.9,
33
"features": {
44
"insightsRecommendations": {
55
"flag": true,

tests/e2e/tests/critical-path/browser/search-capabilities.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ test
149149
await deleteStandaloneDatabaseApi(ossStandaloneV5Config);
150150
})('No RediSearch module message', async t => {
151151
const noRedisearchMessage = 'Looks like RediSearch is not available for this database';
152-
const externalPageLink = 'https://redis.com/try-free/?utm_source=redis&utm_medium=app&utm_campaign=redisinsight_browser_search';
152+
const externalPageLink = 'https://redis.com/try-free/?utm_source=redisinsight&utm_medium=app&utm_campaign=redisinsight_browser_search';
153153

154154
await t.click(browserPage.redisearchModeBtn);
155155
// Verify that user can see message in the dialog when he doesn't have RediSearch module

tests/e2e/tests/critical-path/memory-efficiency/recommendations.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,5 +175,5 @@ test
175175
await t.click(memoryEfficiencyPage.getToTutorialBtnByRecomName(searchJsonRecommendation));
176176
await t.expect(workbenchPage.preselectArea.visible).ok('Workbench Enablement area not opened');
177177
// Verify that REDIS FOR TIME SERIES tutorial expanded
178-
await t.expect((await workbenchPage.getTutorialByName('INTRODUCTION')).visible).ok('INTRODUCTION tutorial is not expanded');
178+
await t.expect(workbenchPage.getTutorialByName('INTRODUCTION').visible).ok('INTRODUCTION tutorial is not expanded');
179179
});

tests/e2e/tests/regression/insights/feature-flag.e2e.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ test('Verify that default config applied when remote config version is lower', a
4545

4646
const featureVersion = await JSON.parse(await getColumnValueFromTableInDB(featuresConfigTable, 'data')).version;
4747

48-
await t.expect(featureVersion).eql(1, 'Config with lowest version applied');
48+
await t.expect(featureVersion).eql(2, 'Config with lowest version applied');
4949
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).notOk('Insights panel displayed when disabled in default config');
5050
});
5151
test('Verify that invaid remote config not applied even if its version is higher than in the default config', async t => {
@@ -55,7 +55,7 @@ test('Verify that invaid remote config not applied even if its version is higher
5555

5656
const featureVersion = await JSON.parse(await getColumnValueFromTableInDB(featuresConfigTable, 'data')).version;
5757

58-
await t.expect(featureVersion).eql(1, 'Config highest version not applied');
58+
await t.expect(featureVersion).eql(2, 'Config highest version not applied');
5959
await t.expect(browserPage.InsightsPanel.insightsBtn.exists).notOk('Insights panel displayed when disabled in default config');
6060
});
6161
test

0 commit comments

Comments
 (0)