RI-7094: Recalculate provider on db connect (#4542)

* Enhance the db connect logic to update the provider if it is not available in the predefined Hosting Provider list

Author: dantovska

redisinsight/api/src/modules/database/database-connection.service.spec.ts

@@ -25,13 +25,18 @@ import { DatabaseConnectionService } from 'src/modules/database/database-connect
 import { RECOMMENDATION_NAMES } from 'src/constants';
 import { DatabaseClientFactory } from 'src/modules/database/providers/database.client.factory';
 import { FeatureService } from 'src/modules/feature/feature.service';
+import { getHostingProvider } from 'src/utils/hosting-provider-helper';
+import { HostingProvider } from 'src/modules/database/entities/database.entity';
+
+jest.mock('src/utils/hosting-provider-helper');
 
 describe('DatabaseConnectionService', () => {
   let service: DatabaseConnectionService;
   let analytics: MockType<DatabaseAnalytics>;
   let recommendationService: MockType<DatabaseRecommendationService>;
   let databaseInfoProvider: MockType<DatabaseInfoProvider>;
   let featureService: MockType<FeatureService>;
+  let repository: MockType<DatabaseRepository>;
 
   beforeEach(async () => {
     jest.clearAllMocks();
@@ -76,6 +81,7 @@ describe('DatabaseConnectionService', () => {
     recommendationService = module.get(DatabaseRecommendationService);
     databaseInfoProvider = module.get(DatabaseInfoProvider);
     featureService = module.get(FeatureService);
+    repository = module.get(DatabaseRepository);
 
     featureService.getByName.mockResolvedValue({
       flag: false,
@@ -107,6 +113,33 @@ describe('DatabaseConnectionService', () => {
       );
     });
 
+    it('should recalculate provider if not available in the list of providers', async () => {
+      const testHost = 'localhost';
+      repository.get.mockResolvedValue({
+        host: testHost,
+        provider: 'not-in-providers-enum',
+      });
+
+      (getHostingProvider as jest.Mock).mockResolvedValue(
+        HostingProvider.REDIS_STACK,
+      );
+
+      await service.connect(mockCommonClientMetadata);
+
+      expect(getHostingProvider).toHaveBeenCalledWith(
+        expect.any(Object),
+        testHost,
+      );
+
+      expect(repository.update).toHaveBeenCalledWith(
+        mockCommonClientMetadata.sessionMetadata,
+        mockCommonClientMetadata.databaseId,
+        expect.objectContaining({
+          provider: HostingProvider.REDIS_STACK,
+        }),
+      );
+    });
+
     it('should call check try rdi recommendation', async () => {
       featureService.getByName.mockResolvedValueOnce({
         flag: true,

redisinsight/api/src/modules/database/database-connection.service.ts

@@ -2,6 +2,7 @@ import { Injectable, Logger } from '@nestjs/common';
 import { RECOMMENDATION_NAMES } from 'src/constants';
 import { DatabaseRepository } from 'src/modules/database/repositories/database.repository';
 import { DatabaseAnalytics } from 'src/modules/database/database.analytics';
+import { HostingProvider } from 'src/modules/database/entities/database.entity';
 import { DatabaseInfoProvider } from 'src/modules/database/providers/database-info.provider';
 import { DatabaseRecommendationService } from 'src/modules/database-recommendation/database-recommendation.service';
 import { Database } from 'src/modules/database/models/database';
@@ -13,6 +14,7 @@ import {
 } from 'src/modules/redis/client';
 import { FeatureService } from 'src/modules/feature/feature.service';
 import { KnownFeatures } from 'src/modules/feature/constants';
+import { getHostingProvider } from 'src/utils/hosting-provider-helper';
 
 @Injectable()
 export class DatabaseConnectionService {
@@ -28,7 +30,8 @@ export class DatabaseConnectionService {
   ) {}
 
   /**
-   * Connects to database and updates modules list and last connected time
+   * Connects to database and updates modules list, last connected time
+   * and provider if not available in the list of providers
    * @param clientMetadata
    */
   async connect(clientMetadata: ClientMetadata): Promise<void> {
@@ -45,6 +48,15 @@ export class DatabaseConnectionService {
       version: await this.databaseInfoProvider.determineDatabaseServer(client),
     };
 
+    const { host, provider } = await this.repository.get(
+      clientMetadata.sessionMetadata,
+      clientMetadata.databaseId,
+    );
+
+    if (!HostingProvider[provider]) {
+      toUpdate.provider = await getHostingProvider(client, host);
+    }
+
     const connectionType = client?.getConnectionType();
     // Update cluster nodes db record
     if (connectionType === RedisClientConnectionType.CLUSTER) {