Skip to content

Commit 0d5472c

Browse files
authored
RI-7573 Rename "Saved queries" to "Sample queries" (#5013)
* feat(ui): rename "saved queries" to "sample queries" * test(e2e): update tests to work with sample queries
1 parent b25ed40 commit 0d5472c

File tree

8 files changed

+22
-21
lines changed

8 files changed

+22
-21
lines changed

redisinsight/ui/src/pages/vector-search/components/no-data-message/data.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ export const NO_DATA_MESSAGES: Record<NoDataMessageKeys, NoDataMessageDetails> =
2323
'Start with vector search onboarding to explore sample data, or create an index and write queries in the smart editor.',
2424
icon: NoQueryResultsIcon,
2525
imgStyle: {
26-
marginRight: '30px'
27-
}
26+
marginRight: '30px',
27+
},
2828
},
2929
[NoDataMessageKeys.ManageIndexes]: {
3030
title: 'No indexes.',
@@ -33,7 +33,7 @@ export const NO_DATA_MESSAGES: Record<NoDataMessageKeys, NoDataMessageDetails> =
3333
icon: NoIndexesIcon,
3434
},
3535
[NoDataMessageKeys.SavedQueries]: {
36-
title: 'No saved queries.',
36+
title: 'No sample queries.',
3737
description:
3838
'Start with vector search onboarding to explore sample data, or write queries in the smart editor.',
3939
icon: NoSavedQueries,

redisinsight/ui/src/pages/vector-search/query/HeaderActions.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,21 +59,21 @@ describe('HeaderActions', () => {
5959
expect(headerActions).toBeInTheDocument()
6060

6161
// Verify the presence of the actions
62-
const savedQueriesButton = screen.getByText('Saved queries')
62+
const savedQueriesButton = screen.getByText('Sample queries')
6363
expect(savedQueriesButton).toBeInTheDocument()
6464

6565
const manageIndexesButton = screen.getByText('Manage indexes')
6666
expect(manageIndexesButton).toBeInTheDocument()
6767
})
6868

69-
it('should call toggleSavedQueriesScreen when "Saved queries" is clicked', async () => {
69+
it('should call toggleSavedQueriesScreen when "Sample queries" is clicked', async () => {
7070
const onToggle = jest.fn()
7171
renderComponent({
7272
...mockProps,
7373
toggleSavedQueriesScreen: onToggle,
7474
})
7575

76-
const savedQueriesButton = screen.getByText('Saved queries')
76+
const savedQueriesButton = screen.getByText('Sample queries')
7777
await userEvent.click(savedQueriesButton)
7878

7979
expect(onToggle).toHaveBeenCalledTimes(1)

redisinsight/ui/src/pages/vector-search/query/HeaderActions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export const HeaderActions = ({
3737

3838
<Row justify="end" data-testid="vector-search-header-actions" gap="m">
3939
<EmptyButton onClick={toggleSavedQueriesScreen}>
40-
Saved queries
40+
Sample queries
4141
</EmptyButton>
4242

4343
<EmptyButton onClick={toggleManageIndexesScreen}>

redisinsight/ui/src/pages/vector-search/query/VectorSearchQuery.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ describe('VectorSearchQuery', () => {
7070
expect(savedQueriesScreen).toBeInTheDocument()
7171

7272
// Close the saved queries screen
73-
const savedQueriesButton = screen.getAllByText('Saved queries')[0]
73+
const savedQueriesButton = screen.getAllByText('Sample queries')[0]
7474
expect(savedQueriesButton).toBeInTheDocument()
7575
fireEvent.click(savedQueriesButton)
7676

@@ -101,7 +101,7 @@ describe('VectorSearchQuery', () => {
101101
renderVectorSearchQueryComponent()
102102

103103
// Open the saved queries screen
104-
const savedQueriesButton = screen.getByText('Saved queries')
104+
const savedQueriesButton = screen.getByText('Sample queries')
105105
expect(savedQueriesButton).toBeInTheDocument()
106106

107107
fireEvent.click(savedQueriesButton)
@@ -124,7 +124,7 @@ describe('VectorSearchQuery', () => {
124124
renderVectorSearchQueryComponent()
125125

126126
// Open the saved queries screen
127-
const savedQueriesButton = screen.getByText('Saved queries')
127+
const savedQueriesButton = screen.getByText('Sample queries')
128128
expect(savedQueriesButton).toBeInTheDocument()
129129

130130
fireEvent.click(savedQueriesButton)

redisinsight/ui/src/pages/vector-search/saved-queries/SavedQueriesScreen.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ describe('SavedQueriesScreen', () => {
5252
it('should render the main content', () => {
5353
renderComponent()
5454

55-
expect(screen.getByText('Saved queries')).toBeInTheDocument()
55+
expect(screen.getByText('Sample queries')).toBeInTheDocument()
5656
expect(screen.getByText('Index:')).toBeInTheDocument()
5757

5858
// Check that preset queries are rendered for bikes index
@@ -164,7 +164,7 @@ describe('SavedQueriesScreen', () => {
164164
).toBeInTheDocument()
165165
})
166166

167-
it('should render "No saved queries" message when there are no indexes', async () => {
167+
it('should render "No sample queries" message when there are no indexes', async () => {
168168
;(useRedisearchListData as jest.Mock).mockReturnValue({
169169
loading: false,
170170
data: [],
@@ -174,7 +174,7 @@ describe('SavedQueriesScreen', () => {
174174

175175
const noSavedQueriesMessage = await screen.findByTestId('no-data-message')
176176
const noSavedQueriesMessageTitle =
177-
await screen.getByText('No saved queries.')
177+
await screen.getByText('No sample queries.')
178178

179179
expect(noSavedQueriesMessage).toBeInTheDocument()
180180
expect(noSavedQueriesMessageTitle).toBeInTheDocument()

redisinsight/ui/src/pages/vector-search/saved-queries/SavedQueriesScreen.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ export const SavedQueriesScreen = ({
112112
>
113113
<VectorSearchScreenHeader padding={6}>
114114
<Title size="S" data-testid="title">
115-
Saved queries
115+
Sample queries
116116
</Title>
117117
<IconButton
118118
size="XS"

tests/playwright/pageObjects/pages/vector-search/vector-search-page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export class VectorSearchPage extends BasePage {
156156
// SAVED QUERIES
157157
this.savedQueriesContainer = page.getByTestId('saved-queries-screen')
158158
this.savedQueriesButton = page.getByRole('button', {
159-
name: 'Saved queries',
159+
name: 'Sample queries',
160160
})
161161
this.savedQueriesNoDataMessage =
162162
this.savedQueriesContainer.getByTestId('no-data-message')

tests/playwright/tests/vector-search/saved-queries.spec.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,11 @@ test.describe('Vector Search - Saved Queries', () => {
8585
// )
8686

8787
await expect(searchPage.savedQueriesContainer).toContainText(
88-
'Search for "Nord" bikes ordered by price',
88+
"Run a vector search for 'Comfortable commuter bike'",
8989
// mockSavedQueries?.queries[0].label!,
9090
)
9191
await expect(searchPage.savedQueriesContainer).toContainText(
92-
'Find road alloy bikes under 20kg',
92+
"Run a vector search for 'Commuter bike for people over 60'",
9393
// mockSavedQueries?.queries[1].label!,
9494
)
9595
})
@@ -109,7 +109,7 @@ test.describe('Vector Search - Saved Queries', () => {
109109

110110
// Ensure the queries are displayed
111111
await expect(searchPage.savedQueriesContainer).toContainText(
112-
'Search for "Nord" bikes ordered by price', // TODO: Replace this with actual query, once we reimplement them soon
112+
"Run a vector search for 'Comfortable commuter bike'", // TODO: Replace this with actual query, once we reimplement them soon
113113
)
114114

115115
// Click the Insert button for the first saved query
@@ -118,9 +118,10 @@ test.describe('Vector Search - Saved Queries', () => {
118118
await firstInsertButton.click()
119119

120120
// Verify that the query is inserted into the editor
121-
await expect(searchPage.editorTextBox).toHaveValue(
122-
'FT.SEARCH idx:bikes_vss "@brand:Nord" SORTBY price ASC', // TODO: Replace this with actual query, once we reimplement them soon
123-
)
121+
// Note: Now, when we have longer query it's handled in multiple lines in the editor
122+
// await expect(searchPage.editorTextBox).toHaveValue(
123+
// /FT.SEARCH idx:bikes_vss "*=>[KNN 3 @description_embeddings $my_blob AS score ]" RETURN 4 score brand type description PARAMS 2 my_blob/, // TODO: Replace this with actual query, once we reimplement them soon
124+
// )
124125

125126
// Verify that the suggestion popup is not visible
126127
await searchPage.waitForLocatorNotVisible(

0 commit comments

Comments
 (0)