#RI-3992 - fix redistack for empty list of modules

Author: rsergeenko

redisinsight/ui/src/utils/redistack.ts

@@ -10,11 +10,15 @@ export const REDISTACK_MODULES: Array<string | Array<string>> = [
   RedisDefaultModules.TimeSeries,
 ]
 
-const checkRediStackModules = (modules: any[]) => map(modules, 'name')
-  .sort()
-  .every((m, index) => (isArray(REDISTACK_MODULES[index])
-    ? (REDISTACK_MODULES[index] as Array<string>).some((rm) => rm === m)
-    : REDISTACK_MODULES[index] === m))
+const checkRediStackModules = (modules: any[]) => {
+  if (!modules.length || modules.length !== REDISTACK_MODULES.length) return false
+
+  return map(modules, 'name')
+    .sort()
+    .every((m, index) => (isArray(REDISTACK_MODULES[index])
+      ? (REDISTACK_MODULES[index] as Array<string>).some((rm) => rm === m)
+      : REDISTACK_MODULES[index] === m))
+}
 
 const checkRediStack = (instances: Instance[]): Instance[] => {
   let isRediStackCheck = false

redisinsight/ui/src/utils/tests/redistack.spec.ts

@@ -46,6 +46,18 @@ const getOutputCheckRediStackTests: any[] = [
     [{ port: 12000, modules: unmapWithName(['bf', 'timeseries', 'ReJSON', 'searchlight', 'graph']) }],
     [{ port: 12000, modules: unmapWithName(['bf', 'timeseries', 'ReJSON', 'searchlight', 'graph']), isRediStack: true }]
   ],
+  [
+    [{ port: 12000, modules: [] }],
+    [{ port: 12000, modules: [], isRediStack: false }]
+  ],
+  [
+    [{ port: 12000, modules: unmapWithName(['ReJSON']) }],
+    [{ port: 12000, modules: unmapWithName(['ReJSON']), isRediStack: false }]
+  ],
+  [
+    [{ port: 12000, modules: unmapWithName(['bf', 'timeseries', 'ReJSON', 'searchlight', 'graph', 'custom']) }],
+    [{ port: 12000, modules: unmapWithName(['bf', 'timeseries', 'ReJSON', 'searchlight', 'graph', 'custom']), isRediStack: false }]
+  ],
 ]
 
 describe('checkRediStack', () => {