Skip to content

Commit 0fcc236

Browse files
authored
Merge pull request #1328 from RedisInsight/fe/bugfix/RI-3725_Redisearch_light_module_not_loaded
#RI-3725 - Module is not found when RediSearch Light is loaded
2 parents d2fc109 + 7ba7cc0 commit 0fcc236

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

redisinsight/ui/src/pages/databaseAnalysis/components/analysis-data-view/AnalysisDataView.spec.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ describe('AnalysisDataView', () => {
153153

154154
const expirationGroup = mockedData.expirationGroups[1]
155155

156-
fireEvent.mouseEnter(screen.getByTestId(`circle-${expirationGroup.threshold}-${expirationGroup.total * 2}`))
157-
expect(screen.getByTestId('area-tooltip-circle')).toHaveTextContent(`~${formatBytes(expirationGroup.total * 2, 3)}`)
156+
fireEvent.mouseEnter(screen.getByTestId(`bar-${expirationGroup.threshold}-${expirationGroup.total * 2}`))
157+
expect(screen.getByTestId('bar-tooltip')).toHaveTextContent(`~${formatBytes(expirationGroup.total * 2, 3)}`)
158158
})
159159

160160
it('should render properly not extrapolated data for ttl chart after switching off', () => {
@@ -173,8 +173,8 @@ describe('AnalysisDataView', () => {
173173

174174
const expirationGroup = mockedData.expirationGroups[1]
175175

176-
fireEvent.mouseEnter(screen.getByTestId(`circle-${expirationGroup.threshold}-${expirationGroup.total}`))
177-
expect(screen.getByTestId('area-tooltip-circle')).toHaveTextContent(`${formatBytes(expirationGroup.total, 3)}`)
176+
fireEvent.mouseEnter(screen.getByTestId(`bar-${expirationGroup.threshold}-${expirationGroup.total}`))
177+
expect(screen.getByTestId('bar-tooltip')).toHaveTextContent(`${formatBytes(expirationGroup.total, 3)}`)
178178
})
179179

180180
it('should render properly extrapolated data for top namespaces table', () => {
@@ -240,8 +240,8 @@ describe('AnalysisDataView', () => {
240240

241241
const expirationGroup = mockedData.expirationGroups[1]
242242

243-
fireEvent.mouseEnter(screen.getByTestId(`circle-${expirationGroup.threshold}-${expirationGroup.total}`))
244-
expect(screen.getByTestId('area-tooltip-circle')).toHaveTextContent(`${formatBytes(expirationGroup.total, 3)}`)
243+
fireEvent.mouseEnter(screen.getByTestId(`bar-${expirationGroup.threshold}-${expirationGroup.total}`))
244+
expect(screen.getByTestId('bar-tooltip')).toHaveTextContent(`${formatBytes(expirationGroup.total, 3)}`)
245245

246246
const nspTopKeyItem = mockedData.topKeysNsp[0]
247247
expect(screen.getByTestId(`nsp-usedMemory-value=${nspTopKeyItem.memory}`))

redisinsight/ui/src/slices/interfaces/instances.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,12 +144,14 @@ export enum RedisCustomModulesName {
144144
IpTables = 'iptables-input-filter',
145145
}
146146

147-
const RediSearchModulesText = [
147+
export const REDISEARCH_MODULES: string[] = [
148148
RedisDefaultModules.Search,
149149
RedisDefaultModules.SearchLight,
150150
RedisDefaultModules.FT,
151-
RedisDefaultModules.FTL
152-
].reduce((prev, next) => ({ ...prev, [next]: 'RediSearch' }), {})
151+
RedisDefaultModules.FTL,
152+
]
153+
154+
const RediSearchModulesText = [...REDISEARCH_MODULES].reduce((prev, next) => ({ ...prev, [next]: 'RediSearch' }), {})
153155

154156
// Enums don't allow to use dynamic key
155157
export const DATABASE_LIST_MODULES_TEXT = Object.freeze({

redisinsight/ui/src/utils/cliHelper.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { resetOutput, updateCliCommandHistory } from 'uiSrc/slices/cli/cli-outpu
88
import { BrowserStorageItem, ICommands } from 'uiSrc/constants'
99
import { ModuleCommandPrefix } from 'uiSrc/pages/workbench/constants'
1010
import { SelectCommand } from 'uiSrc/constants/cliOutput'
11-
import { ClusterNode, RedisDefaultModules } from 'uiSrc/slices/interfaces'
11+
import { ClusterNode, RedisDefaultModules, REDISEARCH_MODULES } from 'uiSrc/slices/interfaces'
1212

1313
import { RedisModuleDto } from 'apiSrc/modules/instances/dto/database-instance.dto'
1414
import { Nullable } from './types'
@@ -146,6 +146,9 @@ const checkUnsupportedModuleCommand = (loadedModules: RedisModuleDto[], commandL
146146
}
147147

148148
const isModuleLoaded = loadedModules?.some(({ name }) => name === commandModule)
149+
// Redisearch has 4 names, need check all
150+
|| loadedModules?.some(({ name }) =>
151+
REDISEARCH_MODULES.some((search) => name === search))
149152

150153
if (isModuleLoaded) {
151154
return null

0 commit comments

Comments
 (0)