Skip to content

Commit 10967ff

Browse files
committed
RI-6067 renamed stop/start/reset action callbacks to be consistent throught slice
1 parent 22e23de commit 10967ff

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

redisinsight/ui/src/slices/rdi/pipeline.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -399,8 +399,8 @@ export function getPipelineStatusAction(
399399

400400
export function stopPipelineAction(
401401
rdiInstanceId: string,
402-
successCallback: (result: IActionPipelineResultProps) => void,
403-
errorCallback: (result: IActionPipelineResultProps) => void,
402+
onSuccessAction?: (result: IActionPipelineResultProps) => void,
403+
onErrorAction?: (result: IActionPipelineResultProps) => void,
404404
) {
405405
return async (dispatch: AppDispatch) => {
406406
try {
@@ -411,7 +411,7 @@ export function stopPipelineAction(
411411

412412
if (isStatusSuccessful(status)) {
413413
dispatch(triggerPipelineActionSuccess())
414-
successCallback?.({ success: true, error: null })
414+
onSuccessAction?.({ success: true, error: null })
415415
}
416416
} catch (_err) {
417417
const error = _err as AxiosError
@@ -420,15 +420,15 @@ export function stopPipelineAction(
420420

421421
dispatch(addErrorNotification(parsedError))
422422
dispatch(triggerPipelineActionFailure(errorMessage))
423-
errorCallback?.({ success: false, error: errorMessage })
423+
onErrorAction?.({ success: false, error: errorMessage })
424424
}
425425
}
426426
}
427427

428428
export function startPipelineAction(
429429
rdiInstanceId: string,
430-
successCallback: (result: IActionPipelineResultProps) => void,
431-
errorCallback: (result: IActionPipelineResultProps) => void,
430+
onSuccessAction?: (result: IActionPipelineResultProps) => void,
431+
onErrorAction?: (result: IActionPipelineResultProps) => void,
432432
) {
433433
return async (dispatch: AppDispatch) => {
434434
try {
@@ -439,7 +439,7 @@ export function startPipelineAction(
439439

440440
if (isStatusSuccessful(status)) {
441441
dispatch(triggerPipelineActionSuccess())
442-
successCallback?.({ success: true, error: null })
442+
onSuccessAction?.({ success: true, error: null })
443443
}
444444
} catch (_err) {
445445
const error = _err as AxiosError
@@ -448,15 +448,15 @@ export function startPipelineAction(
448448

449449
dispatch(addErrorNotification(parsedError))
450450
dispatch(triggerPipelineActionFailure(errorMessage))
451-
errorCallback?.({ success: false, error: errorMessage })
451+
onErrorAction?.({ success: false, error: errorMessage })
452452
}
453453
}
454454
}
455455

456456
export function resetPipelineAction(
457457
rdiInstanceId: string,
458-
successCallback: (result: IActionPipelineResultProps) => void,
459-
errorCallback: (result: IActionPipelineResultProps) => void,
458+
onSuccessAction?: (result: IActionPipelineResultProps) => void,
459+
onErrorAction?: (result: IActionPipelineResultProps) => void,
460460
) {
461461
return async (dispatch: AppDispatch) => {
462462
try {
@@ -468,7 +468,7 @@ export function resetPipelineAction(
468468
if (isStatusSuccessful(status)) {
469469
dispatch(triggerPipelineActionSuccess())
470470
dispatch(addMessageNotification(successMessages.SUCCESS_RESET_PIPELINE()))
471-
successCallback?.({ success: true, error: null })
471+
onSuccessAction?.({ success: true, error: null })
472472
}
473473
} catch (_err) {
474474
const error = _err as AxiosError
@@ -477,7 +477,7 @@ export function resetPipelineAction(
477477

478478
dispatch(addErrorNotification(parsedError))
479479
dispatch(triggerPipelineActionFailure(errorMessage))
480-
errorCallback?.({ success: false, error: errorMessage })
480+
onErrorAction?.({ success: false, error: errorMessage })
481481
}
482482
}
483483
}

0 commit comments

Comments
 (0)