add cloneDeep for redis.connectToInstance method to not mutate object. Fix UTests

Author: Artem

redisinsight/api/src/__mocks__/databases.ts

@@ -6,7 +6,7 @@ import { EncryptionStrategy } from 'src/modules/encryption/models';
 import { mockIORedisClient } from 'src/__mocks__/redis';
 import { mockSentinelMasterDto } from 'src/__mocks__/redis-sentinel';
 import { pick } from 'lodash';
-import { mockRedisGeneralInfo } from 'src/modules/database/providers/database-info.provider.spec';
+import { RedisDatabaseInfoResponse } from 'src/modules/database/dto/redis-info.dto';
 import { ClientMetadata } from 'src/modules/redis/models/client-metadata';
 import { AppTool } from 'src/models';
 import { DatabaseOverview } from 'src/modules/database/models/database-overview';
@@ -134,6 +134,27 @@ export const mockDatabaseOverview: DatabaseOverview = {
   cpuUsagePercentage: null,
 };
 
+export const mockRedisServerInfoDto = {
+  redis_version: '6.0.5',
+  redis_mode: 'standalone',
+  os: 'Linux 4.15.0-1087-gcp x86_64',
+  arch_bits: '64',
+  tcp_port: '11113',
+  uptime_in_seconds: '1000',
+};
+
+export const mockRedisGeneralInfo: RedisDatabaseInfoResponse = {
+  version: mockRedisServerInfoDto.redis_version,
+  databases: 16,
+  role: 'master',
+  server: mockRedisServerInfoDto,
+  usedMemory: 1000000,
+  totalKeys: 1,
+  connectedClients: 1,
+  uptimeInSeconds: 1000,
+  hitRatio: 1,
+};
+
 export const mockDatabaseRepository = jest.fn(() => ({
   exists: jest.fn().mockResolvedValue(true),
   get: jest.fn().mockResolvedValue(mockDatabase),

redisinsight/api/src/modules/database/database-info.service.spec.ts

@@ -3,13 +3,13 @@ import {
   mockDatabase,
   mockDatabaseConnectionService,
   mockDatabaseInfoProvider, mockDatabaseOverview, mockDatabaseOverviewProvider,
+  mockRedisGeneralInfo,
 } from 'src/__mocks__';
 import { DatabaseInfoProvider } from 'src/modules/database/providers/database-info.provider';
 import { DatabaseConnectionService } from 'src/modules/database/database-connection.service';
 import { AppTool } from 'src/models';
 import { DatabaseInfoService } from 'src/modules/database/database-info.service';
 import { DatabaseOverviewProvider } from 'src/modules/database/providers/database-overview.provider';
-import { mockRedisGeneralInfo } from 'src/modules/database/providers/database-info.provider.spec';
 
 describe('DatabaseConnectionService', () => {
   let service: DatabaseInfoService;

redisinsight/api/src/modules/database/database.analytics.spec.ts

@@ -4,11 +4,11 @@ import { EventEmitter2 } from '@nestjs/event-emitter';
 import {
   mockDatabase,
   mockDatabaseWithTlsAuth,
+  mockRedisGeneralInfo,
 } from 'src/__mocks__';
 import { TelemetryEvents } from 'src/constants';
 import { DEFAULT_SUMMARY as DEFAULT_REDIS_MODULES_SUMMARY } from 'src/utils/redis-modules-summary';
 import { DatabaseAnalytics } from 'src/modules/database/database.analytics';
-import { mockRedisGeneralInfo } from 'src/modules/database/providers/database-info.provider.spec';
 import { HostingProvider } from 'src/modules/database/entities/database.entity';
 
 describe('DatabaseAnalytics', () => {

redisinsight/api/src/modules/database/database.service.spec.ts

@@ -3,10 +3,9 @@ import { Test, TestingModule } from '@nestjs/testing';
 import { EventEmitter2 } from '@nestjs/event-emitter';
 import {
   mockDatabase, mockDatabaseAnalytics, mockDatabaseFactory, mockDatabaseInfoProvider, mockDatabaseRepository,
-  mockRedisService, MockType,
+  mockRedisService, MockType, mockRedisGeneralInfo,
 } from 'src/__mocks__';
 import { DatabaseAnalytics } from 'src/modules/database/database.analytics';
-import { mockRedisGeneralInfo } from 'src/modules/database/providers/database-info.provider.spec';
 import { DatabaseService } from 'src/modules/database/database.service';
 import { DatabaseRepository } from 'src/modules/database/repositories/database.repository';
 import { RedisService } from 'src/modules/redis/redis.service';

redisinsight/api/src/modules/database/providers/database-info.provider.spec.ts

@@ -46,7 +46,7 @@ const mockRedisServerInfoDto = {
   uptime_in_seconds: '1000',
 };
 
-export const mockRedisGeneralInfo: RedisDatabaseInfoResponse = {
+const mockRedisGeneralInfo: RedisDatabaseInfoResponse = {
   version: mockRedisServerInfoDto.redis_version,
   databases: 16,
   role: 'master',

redisinsight/api/src/modules/redis/redis.service.ts

@@ -11,6 +11,7 @@ import { CONNECTION_NAME_GLOBAL_PREFIX } from 'src/constants';
 import { IRedisClusterNodeAddress } from 'src/models/redis-cluster';
 import { ConnectionType } from 'src/modules/database/entities/database.entity';
 import { Database } from 'src/modules/database/models/database';
+import { cloneClassInstance } from 'src/utils';
 
 const REDIS_CLIENTS_CONFIG = apiConfig.get('redis_clients');
 
@@ -170,7 +171,7 @@ export class RedisService {
     tool = AppTool.Common,
     connectionName?,
   ): Promise<Redis | Cluster> {
-    const database = databaseDto;
+    const database = cloneClassInstance(databaseDto);
     Object.keys(database).forEach((key: string) => {
       if (database[key] === null) {
         delete database[key];