Skip to content

Commit 1359f38

Browse files
committed
#4399 - rename feature
1 parent b236a5d commit 1359f38

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
export enum FeatureFlags {
2-
liveRecommendations = 'liveRecommendations'
2+
insightsRecommendations = 'insightsRecommendations'
33
}

redisinsight/ui/src/pages/instance/InstancePage.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jest.mock('uiSrc/services', () => ({
2121
jest.mock('uiSrc/slices/app/features', () => ({
2222
...jest.requireActual('uiSrc/slices/app/features'),
2323
appFeatureFlagsFeaturesSelector: jest.fn().mockReturnValue({
24-
liveRecommendations: {
24+
insightsRecommendations: {
2525
flag: false
2626
}
2727
}),
@@ -72,7 +72,7 @@ describe('InstancePage', () => {
7272

7373
it('should render LiveTimeRecommendations Component with feature flag', () => {
7474
(appFeatureFlagsFeaturesSelector as jest.Mock).mockReturnValueOnce({
75-
liveRecommendations: {
75+
insightsRecommendations: {
7676
flag: true
7777
}
7878
})

redisinsight/ui/src/pages/instance/InstancePage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ const InstancePage = ({ routes = [] }: Props) => {
128128

129129
return (
130130
<>
131-
<FeatureFlagComponent name={FeatureFlags.liveRecommendations}>
131+
<FeatureFlagComponent name={FeatureFlags.insightsRecommendations}>
132132
<LiveTimeRecommendations />
133133
</FeatureFlagComponent>
134134
<EuiResizableContainer

redisinsight/ui/src/slices/app/features.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { createSlice, PayloadAction } from '@reduxjs/toolkit'
22
import { remove } from 'lodash'
3-
import { ApiEndpoints, BrowserStorageItem } from 'uiSrc/constants'
3+
import { ApiEndpoints, BrowserStorageItem, FeatureFlags } from 'uiSrc/constants'
44
import { BUILD_FEATURES } from 'uiSrc/constants/featuresHighlighting'
55
import { apiService, localStorageService } from 'uiSrc/services'
66
import { StateAppFeatures } from 'uiSrc/slices/interfaces'
@@ -23,7 +23,7 @@ export const initialState: StateAppFeatures = {
2323
featureFlags: {
2424
loading: false,
2525
features: {
26-
liveRecommendations: {
26+
[FeatureFlags.insightsRecommendations]: {
2727
flag: false
2828
}
2929
}

redisinsight/ui/src/slices/tests/app/features.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ describe('slices', () => {
397397
it('should properly set state', () => {
398398
const payload = {
399399
features: {
400-
liveRecommendations: {
400+
insightsRecommendations: {
401401
flag: true
402402
}
403403
}
@@ -521,7 +521,7 @@ describe('slices', () => {
521521
describe('fetchFeatureFlags', () => {
522522
it('succeed to fetch data', async () => {
523523
// Arrange
524-
const data = { features: { liveRecommendations: true } }
524+
const data = { features: { insightsRecommendations: true } }
525525
const responsePayload = { data, status: 200 }
526526

527527
apiService.get = jest.fn().mockResolvedValue(responsePayload)

0 commit comments

Comments
 (0)