#RI-4567 - resolve pr comments

Author: egor-zalenski

redisinsight/api/src/constants/custom-error-codes.ts

@@ -1,3 +1,3 @@
 export enum CustomErrorCodes {
-  WindowUnauthorized = 'WindowUnauthorizedException',
+  WindowUnauthorized = 10_001,
 }

redisinsight/api/src/modules/auth/window-auth/middleware/window.auth.middleware.ts

@@ -13,7 +13,7 @@ export class WindowAuthMiddleware implements NestMiddleware {
 
   async use(req: Request, res: Response, next: NextFunction): Promise<any> {
     const { windowId } = WindowAuthMiddleware.getWindowIdFromReq(req);
-    const isAuthorized = (await this.windowAuthService.getStrategy()?.isAuthorized(windowId)) ?? false;
+    const isAuthorized = await this.windowAuthService.isAuthorized(windowId);
 
     if (!isAuthorized) {
       this.throwError(req, ERROR_MESSAGES.UNDEFINED_WINDOW_ID);

redisinsight/api/src/modules/auth/window-auth/window-auth.service.spec.ts

@@ -4,7 +4,7 @@ import { AbstractWindowAuthStrategy } from './strategies/abstract.window.auth.st
 
 export class TestAuthStrategy extends AbstractWindowAuthStrategy {
   async isAuthorized(): Promise<boolean> {
-    return false;
+    return true;
   }
 }
 
@@ -21,8 +21,8 @@ describe('WindowAuthService', () => {
 
     windowAuthService = module.get<WindowAuthService>(WindowAuthService);
   });
-  it('Should set strategy to window auth manager and get it back', () => {
+  it('Should set strategy to window auth service and call it', async () => {
     windowAuthService.setStrategy(testStrategy);
-    expect(windowAuthService.getStrategy()).toEqual(testStrategy);
+    expect(await windowAuthService.isAuthorized('')).toEqual(true);
   });
 });

redisinsight/api/src/modules/auth/window-auth/window-auth.service.ts

@@ -13,7 +13,7 @@ export class WindowAuthService {
     this.strategy = strategy;
   }
 
-  getStrategy(): AbstractWindowAuthStrategy {
-    return this.strategy;
+  isAuthorized(id: string = ''): Promise<boolean> {
+    return this.strategy?.isAuthorized?.(id);
   }
 }