Skip to content

Commit 1f0dd9e

Browse files
authored
Merge pull request #3003 from RedisInsight/bugfix/release-2.42
#RI-5372 - fix message showing
2 parents 1eda856 + 9e922ac commit 1f0dd9e

File tree

10 files changed

+46
-55
lines changed

10 files changed

+46
-55
lines changed

redisinsight/ui/src/components/database-side-panels/panels/enablement-area/EnablementArea/components/CodeButtonBlock/CodeButtonBlock.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ const CodeButtonBlock = (props: Props) => {
8282

8383
const handleRunClicked = () => {
8484
if (!instanceId || notLoadedModule || (!isNotShowConfirmation && isButtonHasConfirmation)) {
85-
setIsPopoverOpen(true)
85+
setIsPopoverOpen((v) => !v)
8686
return
8787
}
8888

redisinsight/ui/src/components/onboarding-features/OnboardingFeatures.spec.tsx

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@ import { DatabaseAnalysisViewTab } from 'uiSrc/slices/interfaces/analytics'
1717
import { fetchRedisearchListAction, loadList } from 'uiSrc/slices/browser/redisearch'
1818
import { stringToBuffer } from 'uiSrc/utils'
1919
import { RedisResponseBuffer } from 'uiSrc/slices/interfaces'
20-
import { changeSelectedTab, toggleInsightsPanel } from 'uiSrc/slices/panels/insights'
20+
import {
21+
changeSelectedTab,
22+
resetExplorePanelSearch,
23+
setExplorePanelIsPageOpen,
24+
toggleInsightsPanel
25+
} from 'uiSrc/slices/panels/insights'
2126
import { InsightsPanelTabs } from 'uiSrc/slices/interfaces/insights'
2227
import { ONBOARDING_FEATURES } from './OnboardingFeatures'
2328

@@ -503,6 +508,19 @@ describe('ONBOARDING_FEATURES', () => {
503508
expect(clearStoreActions(store.getActions().slice(-2)))
504509
.toEqual(clearStoreActions(expectedActions))
505510
})
511+
512+
it('should call proper actions on next', () => {
513+
render(<OnboardingTour options={ONBOARDING_FEATURES.EXPLORE_REDIS}><span /></OnboardingTour>)
514+
fireEvent.click(screen.getByTestId('next-btn'))
515+
516+
const expectedActions = [
517+
resetExplorePanelSearch(),
518+
setExplorePanelIsPageOpen(false),
519+
setOnboardNextStep()
520+
]
521+
expect(clearStoreActions(store.getActions().slice(-3)))
522+
.toEqual(clearStoreActions(expectedActions))
523+
})
506524
})
507525

508526
describe('WORKBENCH_CUSTOM_TUTORIALS', () => {

redisinsight/ui/src/components/onboarding-features/OnboardingFeatures.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@ import { fetchRedisearchListAction } from 'uiSrc/slices/browser/redisearch'
2020
import { bufferToString, Nullable } from 'uiSrc/utils'
2121
import { CodeBlock } from 'uiSrc/components'
2222

23-
import { changeSelectedTab, toggleInsightsPanel } from 'uiSrc/slices/panels/insights'
23+
import {
24+
changeSelectedTab,
25+
resetExplorePanelSearch,
26+
setExplorePanelIsPageOpen,
27+
toggleInsightsPanel
28+
} from 'uiSrc/slices/panels/insights'
2429
import { InsightsPanelTabs } from 'uiSrc/slices/interfaces/insights'
2530
import styles from './styles.module.scss'
2631

@@ -281,7 +286,11 @@ const ONBOARDING_FEATURES = {
281286
dispatch(toggleInsightsPanel(false))
282287
sendBackTelemetryEvent(...telemetryArgs)
283288
},
284-
onNext: () => sendNextTelemetryEvent(...telemetryArgs)
289+
onNext: () => {
290+
dispatch(resetExplorePanelSearch())
291+
dispatch(setExplorePanelIsPageOpen(false))
292+
sendNextTelemetryEvent(...telemetryArgs)
293+
}
285294
}
286295
}
287296
},

redisinsight/ui/src/pages/autodiscover-cloud/redis-cloud-databases-result/styles.module.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
@import '@elastic/eui/src/global_styling/index';
44

55
:global(.homePage) :global(.cloudDatabaseListResult) {
6-
height: calc(100vh - 277px) !important;
6+
height: calc(100vh - 292px) !important;
77

88
@media (min-width: 1130px) {
9-
height: calc(100vh - 225px) !important;
9+
height: calc(100vh - 236px) !important;
1010
}
1111

1212
@media only screen and (max-width: 767px) {

redisinsight/ui/src/pages/autodiscover-cloud/redis-cloud-databases/styles.module.scss

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,10 @@
33
@import '@elastic/eui/src/global_styling/index';
44

55
:global(.homePage) :global(.cloudDatabaseList) {
6-
height: calc(100vh - 310px) !important;
6+
height: calc(100vh - 326px) !important;
77

88
@media (min-width: 1130px) {
9-
height: calc(100vh - 255px) !important;
10-
}
11-
12-
@media only screen and (max-width: 767px) {
13-
height: calc(100vh - 394px) !important;
9+
height: calc(100vh - 272px) !important;
1410
}
1511
}
1612

redisinsight/ui/src/pages/autodiscover-cloud/redis-cloud-subscriptions/styles.module.scss

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,10 @@
3232

3333
.cloudSubscriptions {
3434
overflow: hidden !important;
35-
height: calc(100vh - 275px) !important;
35+
height: calc(100vh - 292px) !important;
3636

3737
@media (min-width: 1230px) {
38-
height: calc(100vh - 225px) !important;
39-
}
40-
41-
@media only screen and (max-width: 767px) {
42-
height: calc(100vh - 360px) !important;
38+
height: calc(100vh - 238px) !important;
4339
}
4440
}
4541

redisinsight/ui/src/pages/autodiscover-sentinel/sentinel-databases-result/components/SentinelDatabasesResult/styles.module.scss

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,10 @@
33
@import '@elastic/eui/src/global_styling/index';
44

55
:global(.homePage) :global(.sentinelDatabaseListResult) {
6-
height: calc(100vh - 275px) !important;
6+
height: calc(100vh - 292px) !important;
77

88
@media (min-width: 1130px) {
9-
height: calc(100vh - 225px) !important;
10-
}
11-
12-
@media only screen and (max-width: 767px) {
13-
height: calc(100vh - 360px) !important;
9+
height: calc(100vh - 238px) !important;
1410
}
1511
}
1612

redisinsight/ui/src/pages/autodiscover-sentinel/styles.module.scss

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,10 @@
33
@import "@elastic/eui/src/global_styling/index";
44

55
:global(.homePage) :global(.sentinelDatabaseList) {
6-
height: calc(100vh - 340px) !important;
6+
height: calc(100vh - 356px) !important;
77

88
@media (min-width: 1180px) {
9-
height: calc(100vh - 280px) !important;
10-
}
11-
12-
@media only screen and (max-width: 767px) {
13-
height: calc(100vh - 440px) !important;
14-
}
15-
16-
@media (min-width: 768px) and (max-width: 870px) {
17-
height: calc(100vh - 360px) !important;
9+
height: calc(100vh - 292px) !important;
1810
}
1911
}
2012

redisinsight/ui/src/pages/home/components/databases-list-component/styles.module.scss

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,10 @@ $breakpoint-l: 1400px;
6666
.noSearchResults {
6767
display: flex;
6868

69-
height: calc(100vh - 315px);
69+
height: calc(100vh - 278px);
7070
align-items: center;
7171
flex-direction: column;
7272
justify-content: center;
73-
74-
@media (min-width: 768px) and (max-width: 1100px) {
75-
height: calc(100vh - 223px);
76-
}
77-
78-
@media (min-width: 1101px) {
79-
height: calc(100vh - 248px);
80-
}
8173
}
8274

8375
.tableMsgTitle {

redisinsight/ui/src/pages/redis-cluster/styles.module.scss

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,26 +13,18 @@ $breakpoint-to-wrap-buttons: 660px;
1313

1414
:global(.homePage) {
1515
:global(.clusterDatabaseList) {
16-
height: calc(100vh - 300px) !important;
16+
height: calc(100vh - 316px) !important;
1717

1818
@media (min-width: 1130px) {
19-
height: calc(100vh - 245px) !important;
20-
}
21-
22-
@media only screen and (max-width: 767px) {
23-
height: calc(100vh - 389px) !important;
19+
height: calc(100vh - 256px) !important;
2420
}
2521
}
2622

2723
:global(.clusterDatabaseListResult) {
28-
height: calc(100vh - 280px) !important;
24+
height: calc(100vh - 296px) !important;
2925

3026
@media (min-width: 1130px) {
31-
height: calc(100vh - 220px) !important;
32-
}
33-
34-
@media only screen and (max-width: 767px) {
35-
height: calc(100vh - 360px) !important;
27+
height: calc(100vh - 232px) !important;
3628
}
3729
}
3830
}

0 commit comments

Comments
 (0)