updates by comments

Author: vlad-dargel

tests/e2e/tests/regression/cli/cli-promote-workbench.ts

@@ -21,16 +21,6 @@ fixture `Promote workbench in CLI`
         // Delete database
         await deleteStandaloneDatabaseApi(ossStandaloneConfig);
     });
-// test('Verify that users can see workbench promotion message when they open CLI', async t => {
-//     // Open CLI
-//     await t.click(cliPage.cliExpandButton);
-//     await t.expect(cliPage.workbenchLink.parent().textContent).eql('Try Workbench, our advanced CLI. Check out our Quick Guides to learn more about Redis capabilities.', 'Wrong promotion message');
-//     // Verify that user is redirected to Workbench page clicking on workbench link in CLI
-//     await t.click(cliPage.workbenchLink);
-//     await t.expect(workbenchPage.expandArea.exists).ok('Workbench page is not opened');
-//     // Verify that CLI panel is minimized after redirection to workbench from CLI
-//     await t.expect(cliPage.cliPanel.visible).notOk('Closed CLI');
-// });
 test('Verify that user can see saved workbench context after redirection from CLI to workbench', async t => {
     // Open Workbench
     await t.click(myRedisDatabasePage.workbenchButton);

tests/e2e/tests/regression/database/redisstack.e2e.ts

@@ -1,8 +1,8 @@
 import { rte } from '../../../helpers/constants';
-import { acceptLicenseTermsAndAddDatabaseApi } from '../../../helpers/database';
+import { acceptLicenseTerms, acceptLicenseTermsAndAddDatabaseApi } from '../../../helpers/database';
 import { MyRedisDatabasePage, DatabaseOverviewPage } from '../../../pageObjects';
 import { commonUrl, ossStandaloneConfig } from '../../../helpers/conf';
-import { deleteStandaloneDatabaseApi } from '../../../helpers/api/api-database';
+import { addNewStandaloneDatabaseApi, deleteStandaloneDatabaseApi } from '../../../helpers/api/api-database';
 import { Common } from '../../../helpers/common';
 
 const myRedisDatabasePage = new MyRedisDatabasePage();
@@ -15,7 +15,8 @@ fixture `Redis Stack`
     .page(commonUrl)
     .beforeEach(async() => {
         // Add new databases using API
-        await acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig, ossStandaloneConfig.databaseName);
+        await acceptLicenseTerms();
+        await addNewStandaloneDatabaseApi(ossStandaloneConfig);
         // Reload Page
         await common.reloadPage();
     })

tests/e2e/tests/regression/tree-view/tree-view.e2e.ts

@@ -35,11 +35,6 @@ test
         await t.click(browserPage.treeViewButton);
         await t.expect(browserPage.keyListMessage.textContent).contains(message, 'The message is not displayed');
 
-        // Verify the default separator
-        await t.expect(browserPage.treeViewSeparator.textContent).eql(':', 'The “:” (colon) not used as a default separator for namespaces');
-        // Verify that user can see that “:” (colon) used as a default separator for namespaces and see the number of keys found per each namespace
-        await t.expect(browserPage.treeViewKeysNumber.visible).ok('The user can not see the number of keys');
-
         // Verify that workbench opened by clicking on "Use Workbench Guides and Tutorials" link
         await t.click(browserPage.workbenchLinkButton);
         await t.expect(workbenchPage.expandArea.visible).ok('Workbench page is not opened');
@@ -59,6 +54,12 @@ test('Verify that user can see the total number of keys, the number of keys scan
 test('Verify that when user deletes the key he can see the key is removed from the folder, the number of keys is reduced, the percentage is recalculated', async t => {
     // Open the first key in the tree view and remove
     await t.click(browserPage.treeViewButton);
+
+    // Verify the default separator
+    await t.expect(browserPage.treeViewSeparator.textContent).eql(':', 'The “:” (colon) not used as a default separator for namespaces');
+    // Verify that user can see that “:” (colon) used as a default separator for namespaces and see the number of keys found per each namespace
+    await t.expect(browserPage.treeViewKeysNumber.visible).ok('The user can not see the number of keys');
+
     await t.expect(browserPage.treeViewDeviceFolder.visible).ok('The key folder is not displayed', { timeout: 30000 });
     await t.click(browserPage.treeViewDeviceFolder);
     const numberOfKeys = await browserPage.treeViewDeviceKyesCount.textContent;

tests/e2e/tests/regression/workbench/autocomplete.e2e.ts

@@ -62,16 +62,6 @@ test('Verify that user can see static list of arguments is displayed when he ent
     // Verify that user can close the static list of arguments by pressing “ESC”
     await t.expect(workbenchPage.monacoHintWithArguments.visible).notOk('Hints with arguments are still displayed');
 });
-// test('Verify that user can close the static list of arguments by pressing “ESC”', async t => {
-//         const command = 'TS.DELETERULE '
-//         await t.typeText(workbenchPage.queryInput, command, { replace: true })
-//         //Check that hint with arguments are displayed
-//         await t.expect(workbenchPage.monacoHintWithArguments.visible).ok('Hints with arguments are not displayed')
-//         //Remove hints with arguments
-//         await t.pressKey('esc');
-//         //Check no hints are displayed
-//         await t.expect(workbenchPage.monacoHintWithArguments.visible).notOk('Hints with arguments are still displayed')
-//     });
 test('Verify that user can see the static list of arguments when he uses “Ctrl+Shift+Space” combination for already entered command for Windows', async t => {
     const command = 'JSON.ARRAPPEND';
     await t.typeText(workbenchPage.queryInput, command, { replace: true });

tests/e2e/tests/regression/workbench/scripting-area.e2e.ts

@@ -118,7 +118,7 @@ test
         // Check the result with sent command
         await t.expect(await workbenchPage.queryCardCommand.withExactText(command).exists).ok('The result of sent command is not displayed');
     });
-test.only('Verify that user can repeat commands by entering a number of repeats before the Redis command and see separate results per each command in Workbench', async t => {
+test('Verify that user can repeat commands by entering a number of repeats before the Redis command and see separate results per each command in Workbench', async t => {
     const command = 'FT._LIST';
     const command2 = 'select 13';
     const repeats = 5;