Add support for 1000 base which is used for network metrics

Author: GnaneshKunal

redisinsight/ui/src/components/database-overview/components/OverviewMetrics/OverviewMetrics.tsx

@@ -119,10 +119,11 @@ export const getOverviewMetrics = ({ theme, items, db = 0 }: Props): Array<IMetr
     },
   }
 
-  let [networkIn, networkInUnit] = formatBytes(networkInKbps, 3, true)
-  networkInUnit = `${networkInUnit.toLowerCase()}/s`
-  let [networkOut, networkOutUnit] = formatBytes(networkOutKbps, 3, true)
-  networkOutUnit = `${networkOutUnit.toLowerCase()}/s`
+  let [networkIn, networkInUnit] = formatBytes(networkInKbps * 1000, 3, true, 1000)
+  console.log(networkInKbps, networkIn, networkInUnit)
+  networkInUnit = networkInUnit ? `${networkInUnit.toLowerCase()}/s` : ''
+  let [networkOut, networkOutUnit] = formatBytes(networkOutKbps * 1000, 3, true, 1000)
+  networkOutUnit = networkOutUnit ? `${networkOutUnit.toLowerCase()}/s` : ''
 
   const networkInItem = {
     id: 'network-input',

redisinsight/ui/src/utils/tests/transformers/formatBytes.spec.ts

@@ -47,6 +47,11 @@ describe('formatBytes', () => {
     expect(formatBytes(1572864, 0, true)).toEqual([2, 'MB'])
     expect(formatBytes(1347545989, 3, true)).toEqual([1.255, 'GB'])
   })
+
+  it('should properly set the baseK', () => {
+    expect(formatBytes(1347545989, 3, true)).toEqual([1.255, 'GB']) // default uses 1024
+    expect(formatBytes(1347545989, 3, true, 1000)).toEqual([1.348, 'GB'])
+  })
 })
 
 const toBytesTests: any[] = [

redisinsight/ui/src/utils/transformers/formatBytes.ts

@@ -3,11 +3,12 @@ const SIZES = ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']
 export const formatBytes = (
   input: number,
   decimals: number = 3,
-  splitResult: boolean = false
+  splitResult: boolean = false,
+  baseK = 1024,
 ): string | [number, string] => {
   try {
     const bytes = parseFloat(String(input))
-    const k = 1024
+    const k = baseK
     const dm = decimals < 0 ? 0 : decimals
     if (Number.isNaN(bytes) || bytes < 0) return '-'
     if (bytes === 0) return `0 ${SIZES[0]}`