Skip to content

Commit 324fc7f

Browse files
add more telemetry events
1 parent 386b2b3 commit 324fc7f

File tree

2 files changed

+58
-5
lines changed

2 files changed

+58
-5
lines changed

tests/e2e/tests/web/critical-path/browser/search-capabilities.e2e.ts

Lines changed: 42 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { Selector, t } from 'testcafe';
22
import { DatabaseHelper } from '../../../../helpers/database';
33
import { BrowserPage, MyRedisDatabasePage } from '../../../../pageObjects';
4+
import { Telemetry } from '../../../../helpers/telemetry';
45
import {
56
commonUrl,
67
ossStandaloneBigConfig,
@@ -19,6 +20,32 @@ const myRedisDatabasePage = new MyRedisDatabasePage();
1920
const databaseHelper = new DatabaseHelper();
2021
const databaseAPIRequests = new DatabaseAPIRequests();
2122
const apiKeyRequests = new APIKeyRequests();
23+
const telemetry = new Telemetry();
24+
25+
const telemetryEvents = ['SEARCH_MODE_CHANGED', 'SEARCH_INDEX_ADD_BUTTON_CLICKED', 'SEARCH_INDEX_ADDED'];
26+
const logger = telemetry.createLogger();
27+
const expectedPropertiesMode = [
28+
'current',
29+
'databaseId',
30+
'previous',
31+
'provider',
32+
'view'
33+
];
34+
35+
const expectedPropertiesCreateIndex = [
36+
'databaseId',
37+
'provider',
38+
'view'
39+
];
40+
41+
const expectedPropertiesAddedIndex = [
42+
'countOfFieldNames',
43+
'countOfPrefixes',
44+
'dataType',
45+
'databaseId',
46+
'provider',
47+
'view'
48+
];
2249

2350
const patternModeTooltipText = 'Filter by Key Name or Pattern';
2451
const redisearchModeTooltipText = 'Search by Values of Keys';
@@ -167,7 +194,7 @@ test
167194
await Common.checkURLContainsText(externalPageLinkFirst);
168195
await Common.checkURLContainsText(externalPageLinkSecond);
169196
});
170-
test
197+
test.requestHooks(logger)
171198
.before(async() => {
172199
await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(ossStandaloneBigConfig);
173200
})
@@ -177,10 +204,17 @@ test
177204
})('Index creation', async t => {
178205
const createIndexLink = 'https://redis.io/docs/latest/commands/ft.create/?utm_source=redisinsight&utm_medium=app&utm_campaign=browser_search';
179206

180-
// Verify that user can cancel index creation
207+
// Verify that telemetry event 'SEARCH_MODE_CHANGED' sent
181208
await t.click(browserPage.redisearchModeBtn);
209+
await telemetry.verifyEventHasProperties(telemetryEvents[0], expectedPropertiesMode, logger);
210+
211+
// Verify that user can cancel index creation
182212
await t.click(browserPage.selectIndexDdn);
183213
await t.click(browserPage.createIndexBtn);
214+
215+
// Verify that telemetry event 'SEARCH_INDEX_ADD_BUTTON_CLICKED' sent
216+
await telemetry.verifyEventHasProperties(telemetryEvents[1], expectedPropertiesCreateIndex, logger);
217+
184218
await t.expect(browserPage.newIndexPanel.exists).ok('New Index panel is not displayed');
185219
await t.click(browserPage.cancelIndexCreationBtn);
186220
await t.expect(browserPage.newIndexPanel.exists).notOk('New Index panel is displayed');
@@ -197,8 +231,8 @@ test
197231
await goBackHistory();
198232

199233
// Verify that user can create an index with multiple prefixes
200-
// await t.click(browserPage.selectIndexDdn);
201-
// await t.click(browserPage.createIndexBtn);
234+
await t.click(browserPage.selectIndexDdn);
235+
await t.click(browserPage.createIndexBtn);
202236
await t.click(browserPage.indexNameInput);
203237
await t.typeText(browserPage.indexNameInput, indexName);
204238
await t.click(browserPage.prefixFieldInput);
@@ -214,6 +248,10 @@ test
214248
await t.click(browserPage.indexIdentifierInput);
215249
await t.typeText(browserPage.indexIdentifierInput, 'k0');
216250
await t.click(browserPage.confirmIndexCreationBtn);
251+
252+
await telemetry.verifyEventHasProperties(telemetryEvents[2], expectedPropertiesAddedIndex, logger);
253+
await telemetry.verifyEventPropertyValue(telemetryEvents[2], 'countOfPrefixes', '3', logger);
254+
217255
await t.expect(browserPage.newIndexPanel.exists).notOk('New Index panel is displayed');
218256
await t.click(browserPage.selectIndexDdn);
219257
await browserPage.selectIndexByName(indexName);

tests/e2e/tests/web/regression/browser/list-key.e2e.ts

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,27 @@ import { DatabaseAPIRequests } from '../../../../helpers/api/api-database';
66
import { populateListWithElements } from '../../../../helpers/keys';
77
import { Common } from '../../../../helpers/common';
88
import { APIKeyRequests } from '../../../../helpers/api/api-keys';
9+
import { Telemetry } from '../../../../helpers/telemetry';
910

1011
const browserPage = new BrowserPage();
1112
const databaseHelper = new DatabaseHelper();
1213
const databaseAPIRequests = new DatabaseAPIRequests();
1314
const apiKeyRequests = new APIKeyRequests();
15+
const telemetry = new Telemetry();
1416

1517
const dbParameters = { host: ossStandaloneConfig.host, port: ossStandaloneConfig.port };
1618
const keyName = `TestListKey-${ Common.generateWord(10) }`;
1719
const elementForSearch = `SearchField-${ Common.generateWord(5) }`;
1820
const keyToAddParameters = { elementsCount: 500000, keyName, elementStartWith: 'listElement' };
1921

22+
const telemetryEvent = 'LIST_VIEW_OPENED';
23+
const logger = telemetry.createLogger();
24+
25+
const expectedProperties = [
26+
'databaseId',
27+
'provider'
28+
];
29+
2030
fixture `List Key verification`
2131
.meta({ type: 'regression' })
2232
.page(commonUrl)
@@ -29,11 +39,16 @@ fixture `List Key verification`
2939
await apiKeyRequests.deleteKeyByNameApi(keyName, ossStandaloneConfig.databaseName);
3040
await databaseAPIRequests.deleteStandaloneDatabaseApi(ossStandaloneConfig);
3141
});
32-
test
42+
test.requestHooks(logger)
3343
.meta({ rte: rte.standalone })('Verify that user can search per exact element index in List key in DB with 1 million of fields', async t => {
3444
// Add 1000000 elements to the list key
3545
await populateListWithElements(dbParameters.host, dbParameters.port, keyToAddParameters);
3646
await populateListWithElements(dbParameters.host, dbParameters.port, keyToAddParameters);
47+
48+
// Verify that telemetry event 'TREE_VIEW_KEY_VALUE_VIEWED' sent
49+
await telemetry.verifyEventHasProperties(telemetryEvent, expectedProperties, logger);
50+
51+
await t.click(browserPage.browserViewButton);
3752
// Add custom element to the list key
3853
await browserPage.openKeyDetails(keyName);
3954
await browserPage.addElementToList(elementForSearch);

0 commit comments

Comments
 (0)