Refactoring some tests

Author: kchepikava

redisinsight/api/src/__mocks__/rdi.ts

@@ -23,7 +23,9 @@ export class MockRdiClient extends ApiRdiClient {
 
   public getPipeline = jest.fn();
 
-  public getTemplate = jest.fn();
+  public getConfigTemplate = jest.fn();
+
+  public getJobTemplate = jest.fn();
 
   public getStrategies = jest.fn();
 
@@ -118,3 +120,21 @@ export const mockRdiClientProvider = jest.fn(() => ({
 export const mockRdiClientFactory = jest.fn(() => ({
   createClient: jest.fn(),
 }));
+
+export const mockRdiClientStorage = jest.fn(() => ({
+  getByMetadata: jest.fn(),
+  set: jest.fn(),
+  delete: jest.fn(),
+  deleteManyByRdiId: jest.fn(),
+}));
+
+export const mockRdiPipelineAnalytics = jest.fn(() => ({
+  sendRdiPipelineFetched: jest.fn(),
+  sendRdiPipelineFetchFailed: jest.fn(),
+  sendRdiPipelineDeployed: jest.fn(),
+  sendRdiPipelineDeployFailed: jest.fn(),
+}));
+
+export const mockRdiAnalytics = jest.fn(() => ({
+  sendRdiInstanceDeleted: jest.fn(),
+}));

redisinsight/api/src/constants/custom-error-codes.ts

@@ -58,4 +58,5 @@ export enum CustomErrorCodes {
   RdiUnauthorized = 11_402,
   RdiInternalServerError = 11_403,
   RdiValidationError = 11_404,
+  RdiNotFound = 11_405,
 }

redisinsight/api/src/modules/rdi/client/api.rdi.client.spec.ts

@@ -117,8 +117,6 @@ describe('ApiRdiClient', () => {
       const expectedResponse = {
         transformations: {
           status: RdiDyRunJobStatus.Success,
-          // data: {},
-          // error: ''
         },
         commands: {
           status: RdiDyRunJobStatus.Success,

redisinsight/api/src/modules/rdi/exceptions/rdi-pipeline.not-found.exception.ts

@@ -11,7 +11,7 @@ export class RdiPipelineNotFoundException extends HttpException {
       message,
       statusCode: HttpStatus.NOT_FOUND,
       error: 'RdiNotFound',
-      errorCode: CustomErrorCodes.ConvAiNotFound,
+      errorCode: CustomErrorCodes.RdiNotFound,
       details: options?.details,
     };
     super(response, response.statusCode, options);

redisinsight/api/src/modules/rdi/exceptions/rdi-pipiline.error.handler.spec.ts

@@ -123,7 +123,7 @@ describe('wrapRdiPipelineError', () => {
       message: result.message,
       statusCode: HttpStatus.NOT_FOUND,
       error: 'RdiNotFound',
-      errorCode: CustomErrorCodes.ConvAiNotFound,
+      errorCode: CustomErrorCodes.RdiNotFound,
       details: errorDetails.details,
     });
   });

redisinsight/api/src/modules/rdi/providers/rdi.client.provider.spec.ts

@@ -6,7 +6,7 @@ import { NotFoundException } from '@nestjs/common';
 import { RdiClientMetadata } from 'src/modules/rdi/models';
 import { RdiClient } from 'src/modules/rdi/client/rdi.client';
 import {
-  MockType, generateMockRdiClient, mockRdi, mockRdiRepository,
+  MockType, generateMockRdiClient, mockRdi, mockRdiClientFactory, mockRdiClientStorage, mockRdiRepository,
 } from 'src/__mocks__';
 import { RdiClientProvider } from './rdi.client.provider';
 
@@ -26,18 +26,11 @@ describe('RdiClientProvider', () => {
         },
         {
           provide: RdiClientStorage,
-          useFactory: jest.fn(() => ({
-            getByMetadata: jest.fn(),
-            set: jest.fn(),
-            delete: jest.fn(),
-            deleteManyByRdiId: jest.fn(),
-          })),
+          useFactory: mockRdiClientStorage,
         },
         {
           provide: RdiClientFactory,
-          useFactory: jest.fn(() => ({
-            createClient: jest.fn(),
-          })),
+          useFactory: mockRdiClientFactory,
         },
       ],
     }).compile();