Skip to content

Commit 36434a4

Browse files
authored
Merge pull request #2220 from RedisInsight/build/feature/RI-4505_Node_18
#RI-4505 - Update Electron and nodeJS versions
2 parents e092ddf + f021f1a commit 36434a4

37 files changed

+1297
-2107
lines changed

.circleci/config.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ jobs:
183183
# Test jobs
184184
unit-tests-ui:
185185
docker:
186-
- image: cimg/node:16.15.1
186+
- image: cimg/node:18.15.0
187187
steps:
188188
- checkout
189189
- restore_cache:
@@ -227,7 +227,7 @@ jobs:
227227
- ./node_modules
228228
unit-tests-api:
229229
docker:
230-
- image: cimg/node:16.15.1
230+
- image: cimg/node:18.15.0
231231
steps:
232232
- checkout
233233
- restore_cache:
@@ -385,7 +385,7 @@ jobs:
385385
- checkout
386386
- attach_workspace:
387387
at: .
388-
- run: choco install nodejs --version=16.15.1
388+
- run: choco install nodejs --version=18.15.0
389389
- run:
390390
command: |
391391
cd tests/e2e && export TEST_FILES=$(circleci tests glob "tests/**/*.e2e.ts" | circleci tests split --split-by=timings) && cd ../..
@@ -534,7 +534,7 @@ jobs:
534534
steps:
535535
- checkout
536536
- node/install:
537-
node-version: '16.15.1'
537+
node-version: '18.15.0'
538538
- attach_workspace:
539539
at: .
540540
- run:
@@ -599,7 +599,7 @@ jobs:
599599
- release/redisstack
600600
macosx:
601601
macos:
602-
xcode: 14.3.0
602+
xcode: 14.2.0
603603
resource_class: macos.x86.medium.gen2
604604
parameters:
605605
env:
@@ -610,7 +610,7 @@ jobs:
610610
steps:
611611
- checkout
612612
- node/install:
613-
node-version: '16.15.1'
613+
node-version: '18.15.0'
614614
- attach_workspace:
615615
at: .
616616
- run:
@@ -684,7 +684,7 @@ jobs:
684684
- run:
685685
name: Build windows exe
686686
command: |
687-
choco install nodejs --version=16.15.1
687+
choco install nodejs --version=18.15.0
688688
# set ALL_REDIS_COMMANDS=$(curl $ALL_REDIS_COMMANDS_RAW_URL)
689689
yarn install
690690
yarn --cwd redisinsight/api/ install

Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:16.15.1-alpine as front
1+
FROM node:18.15.0-alpine as front
22
RUN apk update
33
RUN apk add --no-cache --virtual .gyp \
44
python3 \
@@ -20,7 +20,7 @@ ENV SEGMENT_WRITE_KEY=${SEGMENT_WRITE_KEY}
2020
RUN yarn build:web
2121
RUN yarn build:statics
2222

23-
FROM node:16.15.1-alpine as back
23+
FROM node:18.15.0-alpine as back
2424
WORKDIR /usr/src/app
2525
COPY redisinsight/api/package.json redisinsight/api/yarn.lock ./
2626
RUN yarn install
@@ -29,7 +29,7 @@ COPY --from=front /usr/src/app/redisinsight/api/static ./static
2929
COPY --from=front /usr/src/app/redisinsight/api/defaults ./defaults
3030
RUN yarn run build:prod
3131

32-
FROM node:16.15.1-slim
32+
FROM node:18.15.0-slim
3333
# Set up mDNS functionality, to play well with Redis Enterprise
3434
# clusters on the network.
3535
RUN set -ex \

api.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:16.15.1-alpine as build
1+
FROM node:18.15.0-alpine as build
22

33
RUN apk update && apk add bash libsecret dbus-x11 gnome-keyring
44
RUN dbus-uuidgen > /var/lib/dbus/machine-id
@@ -19,7 +19,7 @@ RUN yarn install --production
1919
RUN cp .yarnclean.prod .yarnclean && yarn autoclean --force
2020

2121
# Production image
22-
FROM node:16.15.1-alpine as production
22+
FROM node:18.15.0-alpine as production
2323

2424
RUN apk update && apk add bash libsecret dbus-x11 gnome-keyring
2525
RUN dbus-uuidgen > /var/lib/dbus/machine-id

configs/webpack.config.renderer.prod.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ import { version } from '../redisinsight/package.json';
1212
DeleteSourceMaps();
1313

1414
const htmlPagesNames = ['splash.ejs', 'index.ejs']
15+
const apiUrl = process.env.SERVER_TLS_CERT && process.env.SERVER_TLS_KEY
16+
? 'https://localhost'
17+
: 'http://localhost'
1518

1619
const devtoolsConfig =
1720
process.env.DEBUG_PROD === 'true'
@@ -201,8 +204,8 @@ const configuration: webpack.Configuration = {
201204
'process.env.NODE_ENV': JSON.stringify('development'),
202205
'process.env.APP_ENV': JSON.stringify('electron'),
203206
'process.env.API_PREFIX': JSON.stringify('api'),
204-
'process.env.BASE_API_URL': JSON.stringify('http://localhost'),
205-
'process.env.RESOURCES_BASE_URL': JSON.stringify('http://localhost'),
207+
'process.env.BASE_API_URL': JSON.stringify(apiUrl),
208+
'process.env.RESOURCES_BASE_URL': JSON.stringify(apiUrl),
206209
'process.env.SCAN_COUNT_DEFAULT': JSON.stringify('500'),
207210
'process.env.SCAN_TREE_COUNT_DEFAULT': JSON.stringify('10000'),
208211
'process.env.PIPELINE_COUNT_DEFAULT': JSON.stringify('5'),

configs/webpack.config.renderer.stage.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ import { version } from '../redisinsight/package.json';
77

88
DeleteSourceMaps();
99

10+
const apiUrl = process.env.SERVER_TLS_CERT && process.env.SERVER_TLS_KEY
11+
? 'https://localhost'
12+
: 'http://localhost'
13+
1014
export default merge(baseConfig, {
1115
...rendererProdConfig,
1216

@@ -20,8 +24,8 @@ export default merge(baseConfig, {
2024
'process.env.NODE_ENV': JSON.stringify('staging'),
2125
'process.env.APP_ENV': JSON.stringify('electron'),
2226
'process.env.API_PREFIX': JSON.stringify('api'),
23-
'process.env.BASE_API_URL': JSON.stringify('http://localhost'),
24-
'process.env.RESOURCES_BASE_URL': JSON.stringify('http://localhost'),
27+
'process.env.BASE_API_URL': JSON.stringify(apiUrl),
28+
'process.env.RESOURCES_BASE_URL': JSON.stringify(apiUrl),
2529
'process.env.SCAN_COUNT_DEFAULT': JSON.stringify('500'),
2630
'process.env.SCAN_TREE_COUNT_DEFAULT': JSON.stringify('10000'),
2731
'process.env.PIPELINE_COUNT_DEFAULT': JSON.stringify('5'),

electron-builder.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"type": "distribution",
3030
"hardenedRuntime": true,
3131
"darkModeSupport": true,
32-
"bundleVersion": "10",
32+
"bundleVersion": "20",
3333
"icon": "resources/icon.icns",
3434
"artifactName": "${productName}-${os}-${arch}.${ext}",
3535
"entitlements": "resources/entitlements.mac.plist",

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
],
8080
"homepage": "https://github.com/RedisInsight/RedisInsight#readme",
8181
"resolutions": {
82-
"**/node-sass": "^6.0.1",
82+
"**/node-sass": "^8.0.0",
8383
"**/trim": "0.0.3"
8484
},
8585
"devDependencies": {
@@ -155,7 +155,7 @@
155155
"cross-env": "^7.0.2",
156156
"css-loader": "^5.0.1",
157157
"css-minimizer-webpack-plugin": "^2.0.0",
158-
"electron": "19.0.7",
158+
"electron": "25.1.1",
159159
"electron-builder": "^23.6.0",
160160
"electron-builder-notarize": "^1.5.1",
161161
"electron-debug": "^3.2.0",
@@ -187,14 +187,14 @@
187187
"moment": "^2.29.3",
188188
"monaco-editor-webpack-plugin": "^6.0.0",
189189
"msw": "^0.45.0",
190-
"node-sass": "^6.0.1",
190+
"node-sass": "^8.0.0",
191191
"opencollective-postinstall": "^2.0.3",
192192
"react-hot-loader": "^4.13.0",
193193
"react-refresh": "^0.9.0",
194194
"redux-mock-store": "^1.5.4",
195195
"regenerator-runtime": "^0.13.5",
196196
"rimraf": "^3.0.2",
197-
"sass-loader": "^10.2.0",
197+
"sass-loader": "^13.2.2",
198198
"skip-postinstall": "^1.0.0",
199199
"socket.io-mock": "^1.3.2",
200200
"source-map-support": "^0.5.19",

redisinsight/api/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@
7171
"rxjs": "^7.5.6",
7272
"socket.io": "^4.4.0",
7373
"source-map-support": "^0.5.19",
74-
"sqlite3": "^5.0.11",
75-
"ssh2": "^1.11.0",
74+
"sqlite3": "5.1.6",
75+
"ssh2": "^1.14.0",
7676
"swagger-ui-express": "^4.1.4",
7777
"typeorm": "^0.3.9",
7878
"uuid": "^8.3.2",

redisinsight/api/src/modules/ssh/ssh-tunnel.provider.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ export class SshTunnelProvider {
2222
reject(new UnableToCreateLocalServerException(e.message));
2323
});
2424

25-
detectPort(50000)
25+
detectPort({
26+
hostname: '127.0.0.1',
27+
port: 50000,
28+
})
2629
.then((port) => {
2730
server.listen({
2831
host: '127.0.0.1',

redisinsight/api/test/test-runs/cloud-st/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ services:
88
TEST_CLOUD_API_KEY: ${TEST_CLOUD_API_KEY}
99
TEST_CLOUD_API_SECRET_KEY: ${TEST_CLOUD_API_SECRET_KEY}
1010
redis:
11-
image: node:16.15.1-alpine
11+
image: node:18.15.0-alpine
1212
entrypoint: [ "echo", "Dummy Service" ]

0 commit comments

Comments
 (0)