Skip to content

Commit 375a05e

Browse files
committed
#RI-5378 - fix telemetry events
1 parent 9f533b9 commit 375a05e

File tree

9 files changed

+26
-20
lines changed

9 files changed

+26
-20
lines changed

redisinsight/ui/src/pages/browser/modules/key-details/components/hash-details/HashDetails.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,11 @@ const HashDetails = (props: Props) => {
3131
onOpenAddItemPanel()
3232
}
3333

34-
const closeAddItemPanel = () => {
34+
const closeAddItemPanel = (isCancelled?: boolean) => {
3535
setIsAddItemPanelOpen(false)
36-
onCloseAddItemPanel()
36+
if (isCancelled) {
37+
onCloseAddItemPanel()
38+
}
3739
}
3840

3941
const Actions = ({ width }: { width: number }) => (

redisinsight/ui/src/pages/browser/modules/key-details/components/hash-details/add-hash-fields/AddHashFields.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@ import AddItemsActions from 'uiSrc/pages/browser/components/add-items-actions/Ad
2323

2424
import { stringToBuffer } from 'uiSrc/utils'
2525
import { AddFieldsToHashDto } from 'apiSrc/modules/browser/dto/hash.dto'
26-
import styles from '../styles.module.scss'
2726

2827
export interface Props {
29-
onCancel: (isCancelled?: boolean) => void;
28+
onCancel: (isCancelled?: boolean) => void
3029
}
3130

3231
export interface IHashFieldState {

redisinsight/ui/src/pages/browser/modules/key-details/components/list-details/ListDetails.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,11 @@ const ListDetails = (props: Props) => {
3636
onOpenAddItemPanel()
3737
}
3838

39-
const closeAddItemPanel = () => {
39+
const closeAddItemPanel = (isCancelled?: boolean) => {
4040
setIsAddItemPanelOpen(false)
41-
onCloseAddItemPanel()
41+
if (isCancelled) {
42+
onCloseAddItemPanel()
43+
}
4244
}
4345

4446
const closeRemoveItemPanel = () => {

redisinsight/ui/src/pages/browser/modules/key-details/components/list-details/add-list-elements/AddListElements.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { PushElementToListDto } from 'apiSrc/modules/browser/dto'
2525
import styles from '../styles.module.scss'
2626

2727
export interface Props {
28-
onCancel: (isCancelled?: boolean) => void;
28+
onCancel: (isCancelled?: boolean) => void
2929
}
3030

3131
export enum ListElementDestination {

redisinsight/ui/src/pages/browser/modules/key-details/components/list-details/remove-list-elements/RemoveListElements.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import {
4040
import styles from './styles.module.scss'
4141

4242
export interface Props {
43-
onCancel: () => void
43+
onCancel: (isCancelled?: boolean) => void
4444
onRemoveKey: () => void
4545
}
4646

@@ -278,7 +278,7 @@ const RemoveListElements = (props: Props) => {
278278
<EuiFlexGroup justifyContent="flexEnd" gutterSize="l">
279279
<EuiFlexItem grow={false}>
280280
<div>
281-
<EuiButton color="secondary" onClick={() => onCancel()} data-testid="cancel-elements-btn">
281+
<EuiButton color="secondary" onClick={() => onCancel(true)} data-testid="cancel-elements-btn">
282282
<EuiTextColor color="default">Cancel</EuiTextColor>
283283
</EuiButton>
284284
</div>

redisinsight/ui/src/pages/browser/modules/key-details/components/set-details/SetDetails.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,11 @@ const SetDetails = (props: Props) => {
3131
onOpenAddItemPanel()
3232
}
3333

34-
const closeAddItemPanel = () => {
34+
const closeAddItemPanel = (isCancelled?: boolean) => {
3535
setIsAddItemPanelOpen(false)
36-
onCloseAddItemPanel()
36+
if (isCancelled) {
37+
onCloseAddItemPanel()
38+
}
3739
}
3840

3941
const Actions = ({ width }: { width: number }) => (

redisinsight/ui/src/pages/browser/modules/key-details/components/set-details/add-set-members/AddSetMembers.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import AddItemsActions from 'uiSrc/pages/browser/components/add-items-actions/Ad
2222
import { AddZsetFormConfig as config } from 'uiSrc/pages/browser/components/add-key/constants/fields-config'
2323

2424
export interface Props {
25-
onCancel: (isCancelled?: boolean) => void;
25+
onCancel: (isCancelled?: boolean) => void
2626
}
2727

2828
export interface ISetMemberState {
@@ -154,7 +154,6 @@ const AddSetMembers = (props: Props) => {
154154
length={members.length}
155155
addItem={addMember}
156156
removeItem={removeMember}
157-
removeCanClear
158157
clearIsDisabled={isClearDisabled(item)}
159158
clearItemValues={clearMemberValues}
160159
loading={loading}

redisinsight/ui/src/pages/browser/modules/key-details/components/zset-details/ZSetDetails.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,12 @@ const ZSetDetails = (props: Props) => {
3131
onOpenAddItemPanel()
3232
}
3333

34-
const closeAddItemPanel = () => {
34+
const closeAddItemPanel = (isCancelled?: boolean) => {
3535
setIsAddItemPanelOpen(false)
36-
onCloseAddItemPanel()
36+
37+
if (isCancelled) {
38+
onCloseAddItemPanel()
39+
}
3740
}
3841

3942
const Actions = ({ width }: { width: number }) => (

redisinsight/ui/src/pages/browser/modules/key-details/components/zset-details/add-zset-members/AddZsetMembers.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ import { AddZsetFormConfig as config } from 'uiSrc/pages/browser/components/add-
2525
import AddItemsActions from 'uiSrc/pages/browser/components/add-items-actions/AddItemsActions'
2626

2727
export interface Props {
28-
onCancel: (isCancelled?: boolean) => void;
28+
onCancel: (isCancelled?: boolean) => void
2929
}
3030

3131
export interface IZsetMemberState {
32-
name: string;
33-
score: string;
34-
id: number;
32+
name: string
33+
score: string
34+
id: number
3535
}
3636

3737
export const INITIAL_ZSET_MEMBER_STATE: IZsetMemberState = {
@@ -222,7 +222,6 @@ const AddZsetMembers = (props: Props) => {
222222
length={members.length}
223223
addItem={addMember}
224224
removeItem={removeMember}
225-
removeCanClear
226225
clearIsDisabled={isClearDisabled(item)}
227226
addItemIsDisabled={members.some((item) => !item.score.length)}
228227
clearItemValues={clearMemberValues}

0 commit comments

Comments
 (0)