#RI-4567 - resolve pr comments

Author: egor-zalenski

redisinsight/api/src/modules/auth/window-auth/middleware/window.auth.middleware.ts

@@ -13,9 +13,9 @@ export class WindowAuthMiddleware implements NestMiddleware {
 
   async use(req: Request, res: Response, next: NextFunction): Promise<any> {
     const { windowId } = WindowAuthMiddleware.getWindowIdFromReq(req);
-    const isWindowExists = (await this.windowAuthService.getStrategy()?.isWindowExists(windowId)) ?? false;
+    const isAuthorized = (await this.windowAuthService.getStrategy()?.isAuthorized(windowId)) ?? false;
 
-    if (!isWindowExists) {
+    if (!isAuthorized) {
       this.throwError(req, ERROR_MESSAGES.UNDEFINED_WINDOW_ID);
     }
 

redisinsight/api/src/modules/auth/window-auth/strategies/abstract.window.auth.strategy.ts

@@ -1,3 +1,3 @@
 export abstract class AbstractWindowAuthStrategy {
-  abstract isWindowExists(data: any): Promise<boolean>;
+  abstract isAuthorized(data: any): Promise<boolean>;
 }

redisinsight/api/src/modules/auth/window-auth/window-auth.service.spec.ts

@@ -3,7 +3,7 @@ import { WindowAuthService } from './window-auth.service';
 import { AbstractWindowAuthStrategy } from './strategies/abstract.window.auth.strategy';
 
 export class TestAuthStrategy extends AbstractWindowAuthStrategy {
-  async isWindowExists(): Promise<boolean> {
+  async isAuthorized(): Promise<boolean> {
     return false;
   }
 }

redisinsight/desktop/src/lib/server/server.ts

@@ -14,7 +14,7 @@ import server from '../../../../api/dist/src/main'
 const port = config.defaultPort
 
 export class ElectronWindowAuthStrategy extends AbstractWindowAuthStrategy {
-  async isWindowExists(id: string): Promise<boolean> {
+  async isAuthorized(id: string): Promise<boolean> {
     return getWindows()?.has(id)
   }
 }