replacement of 'visibility' by 'exists'

Author: vlad-dargel

tests/e2e/helpers/database.ts

@@ -220,7 +220,7 @@ export async function clearDatabaseInCli(): Promise<void> {
 */
 export async function deleteDatabase(databaseName: string): Promise<void> {
     await t.click(myRedisDatabasePage.myRedisDBButton);
-    if (await addRedisDatabasePage.addDatabaseButton.visible) {
+    if (await addRedisDatabasePage.addDatabaseButton.exists) {
         await myRedisDatabasePage.deleteDatabaseByName(databaseName);
     }
 }
@@ -231,7 +231,7 @@ export async function deleteDatabase(databaseName: string): Promise<void> {
  * @param databaseName The database name
 */
 export async function acceptTermsAddDatabaseOrConnectToRedisStack(databaseParameters: AddNewDatabaseParameters, databaseName: string): Promise<void> {
-    if (await addRedisDatabasePage.addDatabaseButton.visible) {
+    if (await addRedisDatabasePage.addDatabaseButton.exists) {
         await acceptLicenseTermsAndAddDatabase(databaseParameters, databaseName);
     }
     else {

tests/e2e/helpers/pub-sub.ts

@@ -11,6 +11,6 @@ const pubSubPage = new PubSubPage();
 export async function verifyMessageDisplayingInPubSub(message: string, displayed: boolean): Promise<void> {
     const messageByText = pubSubPage.pubSubPageContainer.find(pubSubPage.cssSelectorMessage).withText(message);
     displayed
-        ? await t.expect(await messageByText.visible).ok(`"${message}" Message is not displayed`, { timeout: 5000 })
-        : await t.expect(await messageByText.visible).notOk(`"${message}" Message is still displayed`);
+        ? await t.expect(await messageByText.exists).ok(`"${message}" Message is not displayed`, { timeout: 5000 })
+        : await t.expect(await messageByText.exists).notOk(`"${message}" Message is still displayed`);
 }

tests/e2e/pageObjects/browser-page.ts

@@ -396,7 +396,7 @@ export class BrowserPage {
         await this.commonAddNewKey(keyName, TTL);
         await t.click(this.streamOption);
         // Verify that user can see Entity ID filled by * by default on add Stream key form
-        await t.expect(this.streamEntryId.withAttribute('value', '*').visible).ok('Preselected Stream Entity ID field')
+        await t.expect(this.streamEntryId.withAttribute('value', '*').exists).ok('Preselected Stream Entity ID field')
             .typeText(this.streamField, field, { replace: true, paste: true })
             .typeText(this.streamValue, value, { replace: true, paste: true });
         await t.expect(this.addKeyButton.withAttribute('disabled').exists).notOk('Clickable Add Key button');
@@ -448,11 +448,11 @@ export class BrowserPage {
      * @param groupName The group name
      */
     async selectFilterGroupType(groupName: string): Promise<void> {
-        if (await this.deleteFilterButton.visible) {
+        if (await this.deleteFilterButton.exists) {
             await t.click(this.deleteFilterButton);
         }
         await t.click(this.filterByKeyTypeDropDown)
-            .click(this.filterOptionType.withExactText(groupName));
+            .click((this.filterOptionType).withExactText(groupName));
     }
 
     /**
@@ -634,6 +634,15 @@ export class BrowserPage {
             .pressKey('enter');
     }
 
+    /**
+     * Search by the value in the key details
+     * @param value The value of the search parameter
+     */
+    async secondarySearchByTheValueInKeyDetails(value: string): Promise<void> {
+        await t.typeText(this.searchInput, value, { replace: true, paste: true })
+            .pressKey('enter');
+    }
+
     /**
      * Search by the value in the set key details
      * @param value The value of the search parameter
@@ -842,7 +851,7 @@ export class BrowserPage {
             const folderSelector = `${lastSelector}keys${delimiter}keys${delimiter}"]`;
             await t.click(Selector(folderSelector));
             const foundKeyName = `${folders[i].join(delimiter)}`;
-            await t.expect(Selector(`[data-testid*="key-${foundKeyName}"]`).visible).ok('Specific key');
+            await t.expect(Selector(`[data-testid*="key-${foundKeyName}"]`).exists).ok('Specific key');
             await t.click(array[0]);
         }
     }

tests/e2e/pageObjects/monitor-page.ts

@@ -71,7 +71,7 @@ export class MonitorPage {
      */
     async stopMonitor(): Promise<void> {
         await t.click(this.runMonitorToggle);
-        await t.expect(this.resetProfilerButton.visible).ok('Reset profiler button appeared');
+        await t.expect(this.resetProfilerButton.exists).ok('Reset profiler button appeared');
     }
 
     //Reset profiler

tests/e2e/pageObjects/my-redis-databases-page.ts

@@ -136,7 +136,7 @@ export class MyRedisDatabasePage {
      */
     async checkModulesOnPage(moduleList: Selector[]): Promise<void> {
         for (const item of moduleList) {
-            await t.expect(item.visible).ok(`${item} icon`);
+            await t.expect(item.exists).ok(`${item} icon`);
         }
     }
 

tests/e2e/pageObjects/user-agreement-page.ts

@@ -22,7 +22,7 @@ export class UserAgreementPage {
             await t.click(this.recommendedSwitcher);
             await t.click(this.switchOptionEula);
             await t.click(this.submitButton);
-            await t.expect(this.userAgreementsPopup.visible).notOk('The user agreements popup is not shown', { timeout: 2000 });
+            await t.expect(this.userAgreementsPopup.exists).notOk('The user agreements popup is not shown', { timeout: 2000 });
         }
     }
 

tests/e2e/tests/critical-path/a-first-start-form/user-agreements-form.e2e.ts

@@ -18,29 +18,29 @@ fixture `Agreements Verification`
 test('Verify that user should accept User Agreements to continue working with the application', async t => {
     await t.expect(userAgreementPage.userAgreementsPopup.exists).ok('User Agreements Popup is shown');
     await t.click(addRedisDatabasePage.addDatabaseButton);
-    //Verify that I still has agreements popup & cannot add a database
+    // Verify that I still has agreements popup & cannot add a database
     await t.expect(userAgreementPage.userAgreementsPopup.exists).ok('User Agreements Popup is shown');
     await t.expect(addRedisDatabasePage.addDatabaseManually.exists).notOk('User can\'t add a database');
 });
 test('Verify that the encryption enabled by default and specific message', async t => {
     const expectedPluginText = 'To avoid automatic execution of malicious code, when adding new Workbench plugins, use files from trusted authors only.';
-    //Verify that section with plugin warning is displayed
-    await t.expect(userAgreementPage.pluginSectionWithText.visible).ok('Plugin text is displayed');
-    //Verify that text that is displayed in window is 'While adding new visualization plugins, use files only from trusted authors to avoid automatic execution of malicious code.'
+    // Verify that section with plugin warning is displayed
+    await t.expect(userAgreementPage.pluginSectionWithText.exists).ok('Plugin text is not displayed');
+    // Verify that text that is displayed in window is 'While adding new visualization plugins, use files only from trusted authors to avoid automatic execution of malicious code.'
     const pluginText = userAgreementPage.pluginSectionWithText.innerText;
     await t.expect(pluginText).eql(expectedPluginText, 'Plugin text is incorrect');
     // Verify that encryption enabled by default
     await t.expect(userAgreementPage.switchOptionEncryption.withAttribute('aria-checked', 'true').exists).ok('Encryption enabled by default');
 });
 test('Verify that the Welcome page is opened after user agrees', async t => {
-    //Accept agreements
+    // Accept agreements
     await t.click(settingsPage.switchEulaOption);
     await t.click(settingsPage.submitConsentsPopupButton);
-    //Verify that I dont have an popup
+    // Verify that I dont have an popup
     await t.expect(userAgreementPage.userAgreementsPopup.exists).notOk('User Agreements Popup isn\'t shown after accept agreements');
-    //Verify that Welcome page is displayed after user agrees
+    // Verify that Welcome page is displayed after user agrees
     await t.expect(addRedisDatabasePage.welcomePageTitle.exists).ok('Welcome page is displayed');
-    //Verify I can work with the application
+    // Verify I can work with the application
     await t.click(addRedisDatabasePage.addDatabaseButton);
     await t.expect(addRedisDatabasePage.addDatabaseManually.exists).ok('User can add a database');
 });

tests/e2e/tests/critical-path/browser/bulk-delete.e2e.ts

@@ -37,7 +37,7 @@ test('Verify that user can access the bulk actions screen in the Browser', async
     await browserPage.selectFilterGroupType(KeyTypesTexts.Hash);
     // Open bulk actions
     await t.click(browserPage.bulkActionsButton);
-    await t.expect(bulkActionsPage.bulkActionsContainer.visible).ok('Bulk actions screen not opened');
+    await t.expect(bulkActionsPage.bulkActionsContainer.exists).ok('Bulk actions screen not opened');
     // Verify that user can see pattern summary of the keys selected: key type, pattern
     await t.expect(bulkActionsPage.infoFilter.innerText).contains('Key type:\nHASH', 'Key type is not correct');
     await t.expect(bulkActionsPage.infoSearch.innerText).contains('Pattern: *', 'Key pattern is not correct');
@@ -51,7 +51,7 @@ test('Verify that user can access the bulk actions screen in the Browser', async
     await t.click(bulkActionsPage.deleteButton);
     await t.expect(bulkActionsPage.bulkActionWarningTooltip.textContent).contains(warningTooltipTitle, 'Warning Tooltip title is not displayed or text is invalid');
     await t.expect(bulkActionsPage.bulkActionWarningTooltip.textContent).contains(warningTooltipMessage, 'Warning Tooltip message is not displayed or text is invalid');
-    await t.expect(bulkActionsPage.bulkApplyButton.visible).ok('Confirm deletion button not displayed');
+    await t.expect(bulkActionsPage.bulkApplyButton.exists).ok('Confirm deletion button not displayed');
 
 });
 test('Verify that user can see summary of scanned level', async t => {
@@ -82,8 +82,8 @@ test('Verify that user can see blue progress line during the process of bulk del
     await browserPage.selectFilterGroupType(KeyTypesTexts.Hash);
     await browserPage.searchByKeyName('hashKey*');
     await bulkActionsPage.startBulkDelete();
-    await t.expect(bulkActionsPage.progressLine.visible).ok('Blue progress line not displayed', { timeout: 5000 });
-    await t.expect(bulkActionsPage.bulkStatusInProgress.visible).ok('Progress value not displayed', { timeout: 5000 });
+    await t.expect(bulkActionsPage.progressLine.exists).ok('Blue progress line not displayed', { timeout: 5000 });
+    await t.expect(bulkActionsPage.bulkStatusInProgress.exists).ok('Progress value not displayed', { timeout: 5000 });
 });
 test
     .before(async() => {
@@ -100,7 +100,7 @@ test
         await t.click(myRedisDatabasePage.workbenchButton);
         // Go to Browser Page
         await t.click(myRedisDatabasePage.browserButton);
-        await t.expect(bulkActionsPage.bulkStatusInProgress.visible).ok('Progress value not displayed', { timeout: 5000 });
+        await t.expect(bulkActionsPage.bulkStatusInProgress.exists).ok('Progress value not displayed', { timeout: 5000 });
     });
 test
     .before(async() => {
@@ -114,7 +114,7 @@ test
         await bulkActionsPage.startBulkDelete();
         await t.click(bulkActionsPage.bulkStopButton);
         const stoppedProgress = parseInt((await bulkActionsPage.bulkStatusStopped.innerText).replace(/[^\d]/g, ''));
-        await t.expect(bulkActionsPage.bulkStatusStopped.visible).ok('Progress value not displayed');
+        await t.expect(bulkActionsPage.bulkStatusStopped.exists).ok('Progress value not displayed');
         // Verify that when user stop bulk deletion, he can see the percentage at which the operation was stopped
         await t.expect(stoppedProgress).gt(1, 'Progress value not displayed');
         await t.expect(stoppedProgress).lt(100, 'Progress value not correct');
@@ -123,10 +123,10 @@ test('Verify that when bulk deletion is completed, status Action completed is di
     // Filter by Hash keys
     await browserPage.selectFilterGroupType(KeyTypesTexts.Hash);
     await bulkActionsPage.startBulkDelete();
-    await t.expect(bulkActionsPage.bulkStatusCompleted.visible).ok('Bulk deletion not completed', { timeout: 15000 });
+    await t.expect(bulkActionsPage.bulkStatusCompleted.exists).ok('Bulk deletion not completed', { timeout: 15000 });
     await t.expect(bulkActionsPage.bulkStatusCompleted.textContent).eql('Action completed', 'Action completed text is not visible');
     // Verify that when bulk deletion is completed, button Delete changes to Start New
-    await t.expect(bulkActionsPage.bulkStartAgainButton.visible).ok('"Start New" button not displayed');
+    await t.expect(bulkActionsPage.bulkStartAgainButton.exists).ok('"Start New" button not displayed');
     // Verify that user can click on Start New and existed filter will be applied
     await t.click(bulkActionsPage.bulkStartAgainButton);
     await t.expect(bulkActionsPage.bulkDeleteSummary.innerText).contains('Scanned 100% (2/2) and found 1 keys', 'Bulk delete summary is not correct');
@@ -163,13 +163,13 @@ test('Verify that when user clicks on Close button when bulk delete is completed
     await t.click(bulkActionsPage.bulkCancelButton);
     await t.click(browserPage.bulkActionsButton);
     // Verify context not saved
-    await t.expect(bulkActionsPage.bulkDeleteCompletedSummary.visible).notOk('Bulk delete completed summary still displayed');
+    await t.expect(bulkActionsPage.bulkDeleteCompletedSummary.exists).notOk('Bulk delete completed summary still displayed');
     await t.expect(bulkActionsPage.bulkDeleteSummary.textContent).contains('Scanned 100% (2/2) and found 1 keys', 'Bulk delete summary is not correct');
     // Verify that when user clicks on cross icon when bulk delete is completed, panel is closed, no context is saved
     await bulkActionsPage.startBulkDelete();
     await t.click(bulkActionsPage.bulkClosePanelButton);
     await t.click(browserPage.bulkActionsButton);
     // Verify context not saved
-    await t.expect(bulkActionsPage.bulkDeleteCompletedSummary.visible).notOk('Bulk delete completed summary still displayed');
+    await t.expect(bulkActionsPage.bulkDeleteCompletedSummary.exists).notOk('Bulk delete completed summary still displayed');
     await t.expect(bulkActionsPage.bulkDeleteSummary.textContent).contains('Scanned 100% (2/2) and found 1 keys', 'Bulk delete summary is not correct');
 });

tests/e2e/tests/critical-path/browser/consumer-group.e2e.ts

@@ -30,7 +30,7 @@ fixture `Consumer group`
     })
     .afterEach(async t => {
         // Clear and delete database
-        if (await browserPage.closeKeyButton.visible, { timeout: 500 }) {
+        if (await browserPage.closeKeyButton.exists, { timeout: 500 }) {
             await t.click(browserPage.closeKeyButton);
         }
         await browserPage.deleteKeyByName(keyName);
@@ -124,7 +124,7 @@ test('Verify that user can see the Consumer information columns (Consumer Name,
         await t.expect(browserPage.scoreButton.nth(i).textContent).eql(consumerColumns[i], `The ${i} Consumers info column name not correct`);
     }
     // Verify that user can navigate to Consumer Groups screen using the link in the breadcrumbs
-    await t.expect(browserPage.streamTabs.visible).ok('Stream navigation tabs visibility');
+    await t.expect(browserPage.streamTabs.exists).ok('Stream navigation tabs visibility');
     await t.click(browserPage.streamTabGroups);
     await t.expect(browserPage.streamTabGroups.withAttribute('aria-selected', 'true').exists).ok('The Consumer Groups screen is not opened');
 });

tests/e2e/tests/critical-path/browser/context.e2e.ts

@@ -61,7 +61,7 @@ test('Verify that user can see saved filter per key type applied when he returns
     await t.click(myRedisDatabasePage.settingsButton);
     // Return back to Browser and check filter applied
     await t.click(myRedisDatabasePage.browserButton);
-    await t.expect(await browserPage.selectedFilterTypeString.visible).eql(true, 'Filter per key type is still applied');
+    await t.expect(browserPage.selectedFilterTypeString.exists).ok('Filter per key type is still applied');
     // Clear filter
     await t.click(browserPage.clearFilterButton);
     // Filter per key name and open Settings
@@ -70,7 +70,7 @@ test('Verify that user can see saved filter per key type applied when he returns
     // Return back to Browser and check filter applied
     await t.click(myRedisDatabasePage.browserButton);
     // Verify that user can see saved input entered into the filter per Key name when he returns back to Browser page
-    await t.expect(await browserPage.filterByPatterSearchInput.withAttribute('value', keyName).exists).ok('Filter per key name is still applied');
+    await t.expect(browserPage.filterByPatterSearchInput.withAttribute('value', keyName).exists).ok('Filter per key name is still applied');
 });
 test('Verify that user can see saved executed commands in CLI on Browser page when he returns back to Browser page', async t => {
     const commands = [