Refactor

create page file

Author: nmammadli

tests/e2e/common-actions/onboard-actions.ts

@@ -1,42 +1,45 @@
-import {Selector, t} from 'testcafe';
+import {t} from 'testcafe';
+import {OnboardingPage, BrowserPage} from '../pageObjects';
 
+const onboardingPage = new OnboardingPage();
+const browserPage = new BrowserPage();
 export class OnboardActions {
     /**
         @param stepName title of the step
         verify onboarding step visible based on title
     */
     async verifyStepVisible(stepName: string): Promise<void> {
-        await t.expect(Selector('[data-testid=step-title]').withText(stepName).exists).ok(`${stepName} step is not visible`);
+        await t.expect(onboardingPage.stepTitle.withText(stepName).exists).ok(`${stepName} step is not visible`);
     }
     /**
         click next step
     */
     async clickNextStep(): Promise<void> {
-        await t.click(Selector('[data-testid=next-btn]'));
+        await t.click(onboardingPage.nextButton);
     }
     /**
         start onboarding process
     */
     async startOnboarding(): Promise<void> {
-        await t.click(Selector('span').withText('Show me around'));
+        await t.click(onboardingPage.showMeAroundButton);
     }
     /**
         complete onboarding process
      */
-    async verifyOnbardingCompleted(): Promise<void> {
-        await t.expect(Selector('span').withText('Show me around').visible).notOk('show me around button still visible');
-        await t.expect(Selector('[data-testid=search-mode-switcher]').visible).ok('browser page is not opened');
+    async verifyOnboardingCompleted(): Promise<void> {
+        await t.expect(onboardingPage.showMeAroundButton.visible).notOk('show me around button still visible');
+        await t.expect(browserPage.patternModeBtn.visible).ok('browser page is not opened');
     }
     /**
         click back step
      */
     async clickBackStep(): Promise<void> {
-        await t.click(Selector('[data-testid=back-btn]'));
+        await t.click(onboardingPage.backButton);
     }
     /**
         click skip tour step
      */
     async clickSkipTour(): Promise<void> {
-        await t.click(Selector('[data-testid=skip-tour-btn]'));
+        await t.click(onboardingPage.skipTourButton);
     }
 }

tests/e2e/pageObjects/index.ts

@@ -16,6 +16,7 @@ import { OverviewPage } from './overview-page';
 import { PubSubPage } from './pub-sub-page';
 import { SlowLogPage } from './slow-log-page';
 import { NotificationPage } from './notification-page';
+import { OnboardingPage} from './onboarding-page';
 
 export {
     AddRedisDatabasePage,
@@ -35,5 +36,6 @@ export {
     OverviewPage,
     PubSubPage,
     SlowLogPage,
-    NotificationPage
+    NotificationPage,
+    OnboardingPage
 };

tests/e2e/pageObjects/onboarding-page.ts

@@ -0,0 +1,9 @@
+import { Selector } from 'testcafe';
+
+export class OnboardingPage {
+    backButton = Selector('[data-testid=back-btn]');
+    nextButton = Selector('[data-testid=next-btn]');
+    showMeAroundButton = Selector('span').withText('Show me around');
+    skipTourButton = Selector('[data-testid=skip-tour-btn]');
+    stepTitle = Selector('[data-testid=step-title]');
+}

tests/e2e/tests/regression/browser/onboarding.e2e.ts

@@ -31,9 +31,7 @@ fixture `Onboarding new user tests`
     .afterEach(async() => {
         await deleteDatabase(ossStandaloneConfig.databaseName);
     });
-test.skip('verify onboard new user steps', async t => {
-    // start onboarding process
-    // Verify that when user agree with the onboarding, can see the steps and logic described in the “Steps” table.
+test('Verify onbarding new user steps', async t => {
     await onBoardActions.startOnboarding();
     // verify browser step is visible
     await onBoardActions.verifyStepVisible('Browser');
@@ -87,9 +85,9 @@ test.skip('verify onboard new user steps', async t => {
     await onBoardActions.verifyStepVisible('Great job!');
     await onBoardActions.clickNextStep();
     // verify onboarding step completed successfully
-    await onBoardActions.verifyOnbardingCompleted();
+    await onBoardActions.verifyOnboardingCompleted();
 });
-test.skip('verify onboard new user skip tour', async() => {
+test('verify onboard new user skip tour', async() => {
     // start onboarding process
     await onBoardActions.startOnboarding();
     // verify browser step is visible
@@ -101,9 +99,9 @@ test.skip('verify onboard new user skip tour', async() => {
     // click skip tour
     await onBoardActions.clickSkipTour();
     // verify onboarding step completed successfully
-    await onBoardActions.verifyOnbardingCompleted();
+    await onBoardActions.verifyOnboardingCompleted();
     await common.reloadPage();
     // verify onboarding step still not visible after refresh page
-    await onBoardActions.verifyOnbardingCompleted();
+    await onBoardActions.verifyOnboardingCompleted();
 });