#RI-5609 - remove luaToFunctions and functionsWithKeyspace recommendations

Author: AmirAllayarovSofteq

redisinsight/api/src/common/constants/recommendations.ts

@@ -23,4 +23,3 @@ export const COMBINE_SMALL_STRINGS_TO_HASHES_RECOMMENDATION_KEYS_COUNT = 10;
 export const SEARCH_HASH_RECOMMENDATION_KEYS_FOR_CHECK = 50;
 export const SEARCH_HASH_RECOMMENDATION_KEYS_LENGTH = 2;
 export const RTS_KEYS_FOR_CHECK = 100;
-export const LUA_TO_FUNCTIONS_RECOMMENDATION_COUNT = 0;

redisinsight/api/src/constants/recommendations.ts

@@ -1,6 +1,5 @@
 export const RECOMMENDATION_NAMES = Object.freeze({
   LUA_SCRIPT: 'luaScript',
-  LUA_TO_FUNCTIONS: 'luaToFunctions',
   BIG_HASHES: 'bigHashes',
   BIG_STRINGS: 'bigStrings',
   BIG_SETS: 'bigSets',
@@ -21,7 +20,6 @@ export const RECOMMENDATION_NAMES = Object.freeze({
   STRING_TO_JSON: 'stringToJson',
   SEARCH_VISUALIZATION: 'searchVisualization',
   SEARCH_HASH: 'searchHash',
-  FUNCTIONS_WITH_KEYSPACE: 'functionsWithKeyspace',
   FUNCTIONS_WITH_STREAMS: 'functionsWithStreams',
 });
 

redisinsight/api/src/modules/database-recommendation/scanner/recommendation.provider.ts

@@ -19,8 +19,6 @@ import {
   CompressionForListStrategy,
   BigAmountConnectedClientsStrategy,
   FunctionsWithStreamsStrategy,
-  FunctionsWithKeyspaceStrategy,
-  LuaToFunctionsStrategy,
 } from 'src/modules/database-recommendation/scanner/strategies';
 
 @Injectable()
@@ -47,8 +45,6 @@ export class RecommendationProvider {
     this.strategies.set(RECOMMENDATION_NAMES.COMPRESSION_FOR_LIST, new CompressionForListStrategy());
     this.strategies.set(RECOMMENDATION_NAMES.BIG_AMOUNT_OF_CONNECTED_CLIENTS, new BigAmountConnectedClientsStrategy());
     this.strategies.set(RECOMMENDATION_NAMES.FUNCTIONS_WITH_STREAMS, new FunctionsWithStreamsStrategy(databaseService));
-    this.strategies.set(RECOMMENDATION_NAMES.LUA_TO_FUNCTIONS, new LuaToFunctionsStrategy(databaseService));
-    this.strategies.set(RECOMMENDATION_NAMES.FUNCTIONS_WITH_KEYSPACE, new FunctionsWithKeyspaceStrategy(databaseService));
   }
 
   getStrategy(type: string): IRecommendationStrategy {

redisinsight/api/src/modules/database-recommendation/scanner/strategies/functions-with-keyspace.strategy.spec.ts

@@ -14,5 +14,3 @@ export * from './big-string.strategy';
 export * from './compression-for-list.strategy';
 export * from './big-amount-connected-clients.strategy';
 export * from './functions-with-streams.strategy';
-export * from './lua-to-functions.strategy';
-export * from './functions-with-keyspace.strategy';

redisinsight/api/src/modules/database-recommendation/scanner/strategies/functions-with-keyspace.strategy.ts

@@ -93,20 +93,6 @@ describe('DatabaseConnectionService', () => {
         RECOMMENDATION_NAMES.BIG_AMOUNT_OF_CONNECTED_CLIENTS,
         mockRedisGeneralInfo,
       );
-      expect(recommendationService.check).toBeCalledWith(
-        mockCommonClientMetadata,
-        RECOMMENDATION_NAMES.LUA_TO_FUNCTIONS,
-        {
-          client: mockStandaloneRedisClient,
-          databaseId: mockCommonClientMetadata.databaseId,
-          info: mockRedisGeneralInfo,
-        },
-      );
-      expect(recommendationService.check).toBeCalledWith(
-        mockCommonClientMetadata,
-        RECOMMENDATION_NAMES.FUNCTIONS_WITH_KEYSPACE,
-        { client: mockStandaloneRedisClient, databaseId: mockCommonClientMetadata.databaseId },
-      );
     });
 
     it('should call databaseInfoProvider', async () => {

redisinsight/api/src/modules/database-recommendation/scanner/strategies/index.ts

@@ -66,16 +66,6 @@ export class DatabaseConnectionService {
       RECOMMENDATION_NAMES.BIG_AMOUNT_OF_CONNECTED_CLIENTS,
       generalInfo,
     );
-    this.recommendationService.check(
-      clientMetadata,
-      RECOMMENDATION_NAMES.LUA_TO_FUNCTIONS,
-      { client, databaseId: clientMetadata.databaseId, info: generalInfo },
-    );
-    this.recommendationService.check(
-      clientMetadata,
-      RECOMMENDATION_NAMES.FUNCTIONS_WITH_KEYSPACE,
-      { client, databaseId: clientMetadata.databaseId },
-    );
 
     this.collectClientInfo(clientMetadata, client, generalInfo?.version);