fixes for failed regression tests

Author: vlad-dargel

tests/e2e/tests/critical-path/database/clone-databases.e2e.ts

@@ -114,7 +114,6 @@ test
         await t.click(addRedisDatabasePage.testConnectionBtn);
         await t.expect(myRedisDatabasePage.databaseInfoMessage.textContent).contains('Connection is successful', 'Sentinel connection is not successful');
 
-        await t.click(addRedisDatabasePage.cloneDatabaseButton);
         // Verify that for Sentinel Host and Port fields are replaced with editable Primary Group Name field
         await t
             .expect(myRedisDatabasePage.editAliasButton.withText('Clone ').exists).ok('Clone panel is not displayed')

tests/e2e/tests/critical-path/workbench/scripting-area.e2e.ts

@@ -30,20 +30,21 @@ fixture `Scripting area at Workbench`
 // Update after resolving https://redislabs.atlassian.net/browse/RI-3299
 test('Verify that user can resize scripting area in Workbench', async t => {
     const commandForSend = 'info';
-    const offsetY = 200;
-    const inputHeightStart = await workbenchPage.queryInput.clientHeight;
-    const inputHeightEnd = inputHeightStart + 150;
+    const offsetY = 100;
 
     await workbenchPage.sendCommandInWorkbench(commandForSend);
     // Verify that user can run any script from CLI in Workbench and see the results
     await t.expect(workbenchPage.queryCardContainer.exists).ok('Query card was added');
     const sentCommandText = workbenchPage.queryCardCommand.withExactText(commandForSend);
     await t.expect(sentCommandText.exists).ok('Result of sent command exists');
 
+    const inputHeightStart = await workbenchPage.queryInput.clientHeight;
+
     await t.hover(workbenchPage.resizeButtonForScriptingAndResults);
-    await t.drag(workbenchPage.resizeButtonForScriptingAndResults, 0, offsetY, { speed: 0.01 });
+    await t.drag(workbenchPage.resizeButtonForScriptingAndResults, 0, offsetY, { speed: 0.4 });
     // Verify that user can resize scripting area
-    await t.expect(await workbenchPage.queryInput.clientHeight > inputHeightEnd).ok('Scripting area after resize has incorrect size');
+    const inputHeightEnd = inputHeightStart + 20;
+    await t.expect(await workbenchPage.queryInput.clientHeight).gt(inputHeightEnd, 'Scripting area after resize has incorrect size');
 });
 test('Verify that user when he have more than 10 results can request to view more results in Workbench', async t => {
     indexName = common.generateWord(5);

tests/e2e/tests/regression/browser/keys-all-databases.e2e.ts

@@ -1,4 +1,4 @@
-import { t } from 'testcafe';
+import { Selector, t } from 'testcafe';
 import { env, rte } from '../../../helpers/constants';
 import {
     acceptLicenseTermsAndAddDatabaseApi,
@@ -40,8 +40,9 @@ const verifyKeysAdded = async(): Promise<void> => {
     await t.expect(notification).contains('Key has been added', 'The notification not correct');
     // Check that new key is displayed in the list
     await browserPage.searchByKeyName(keyName);
-    const isKeyIsDisplayedInTheList = await browserPage.isKeyIsDisplayedInTheList(keyName);
-    await t.expect(isKeyIsDisplayedInTheList).ok('The key is not added');
+    const keyNameInTheList = Selector(`[data-testid="key-${keyName}"]`);
+    await common.waitForElementNotVisible(browserPage.loader);
+    await t.expect(keyNameInTheList.exists).ok(`${keyName} key is not added`);
 };
 
 fixture `Work with keys in all types of databases`

tests/e2e/tests/regression/browser/resize-columns.e2e.ts

@@ -19,21 +19,21 @@ const longFieldName = common.generateSentence(20);
 const keys = [
     {   type: 'Hash',
         name: `${keyName}:1`,
-        offsetX: 100,
+        offsetX: 50,
         fieldWidthStart: 0,
         fieldWidthEnd: 0
     },
     {
         type: 'List',
         name: `${keyName}:2`,
-        offsetX: 80,
+        offsetX: 40,
         fieldWidthStart: 0,
         fieldWidthEnd: 0
     },
     {
         type: 'Zset',
         name: `${keyName}:3`,
-        offsetX: 50,
+        offsetX: 30,
         fieldWidthStart: 0,
         fieldWidthEnd: 0
     }
@@ -75,7 +75,7 @@ test('Resize of columns in Hash, List, Zset Key details', async t => {
         // Remember initial column width
         key.fieldWidthStart = await field.clientWidth;
         await t.hover(tableHeaderResizeTrigger);
-        await t.drag(tableHeaderResizeTrigger, -key.offsetX, 0, { speed: 0.5 });
+        await t.drag(tableHeaderResizeTrigger, -key.offsetX, 0, { speed: 0.4 });
         // Remember last column width
         key.fieldWidthEnd = await field.clientWidth;
         // Verify that user can resize columns for Hash, List, Zset Keys
@@ -96,9 +96,9 @@ test('Resize of columns in Hash, List, Zset Key details', async t => {
     // Go to 2nd database
     await myRedisDatabasePage.clickOnDBByName(databasesForAdding[1].databaseName);
     // Verify that resize saved for specific data type
-    for(const key of keys) {
+    for (const key of keys) {
         await browserPage.openKeyDetails(key.name);
-        await t.expect(field.clientWidth).eql(key.fieldWidthEnd, `Resize context not saved for ${key.type} key when switching between databases`);
+        await t.expect(field.clientWidth).within(key.fieldWidthEnd - 5, key.fieldWidthEnd + 5, `Resize context not saved for ${key.type} key when switching between databases`);
     }
 
     // Change db index for 2nd database

tests/e2e/tests/regression/cli/cli-re-cluster.e2e.ts

@@ -1,4 +1,4 @@
-import { t } from 'testcafe';
+import { Selector, t } from 'testcafe';
 import { env, rte } from '../../../helpers/constants';
 import {
     acceptLicenseTermsAndAddOSSClusterDatabase,
@@ -32,8 +32,9 @@ const verifyCommandsInCli = async(): Promise<void> => {
     await t.pressKey('enter');
     // Check that the key is added
     await browserPage.searchByKeyName(keyName);
-    const isKeyIsDisplayedInTheList = await browserPage.isKeyIsDisplayedInTheList(keyName);
-    await t.expect(isKeyIsDisplayedInTheList).ok('The key is added');
+    const keyNameInTheList = Selector(`[data-testid="key-${keyName}"]`);
+    await common.waitForElementNotVisible(browserPage.loader);
+    await t.expect(keyNameInTheList.exists).ok(`${keyName} key is not added`);
 };
 
 fixture `Work with CLI in all types of databases`