Skip to content

Commit 4dac939

Browse files
Merge pull request #3564 from RedisInsight/fe/feature/update_statistics_page
update empty pipeline condition
2 parents c9aa94b + 718f9f2 commit 4dac939

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

redisinsight/ui/src/pages/rdi/statistics/StatisticsPage.spec.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -128,14 +128,8 @@ describe('StatisticsPage', () => {
128128
it('renders the empty state when pipeline data is empty', () => {
129129
(rdiPipelineStatusSelector as jest.Mock).mockReturnValueOnce({
130130
data: {
131-
components: { processor: 'not-ready' },
132-
pipelines: {
133-
default: {
134-
status: 'not-ready',
135-
state: 'some',
136-
tasks: 'none',
137-
}
138-
}
131+
components: {},
132+
pipelines: {}
139133
}
140134
})
141135
const { getByText } = render(<StatisticsPage />)

redisinsight/ui/src/pages/rdi/statistics/StatisticsPage.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { get } from 'lodash'
1+
import { isEmpty } from 'lodash'
22
import React, { useEffect } from 'react'
33
import { useDispatch, useSelector } from 'react-redux'
44
import { useParams } from 'react-router-dom'
@@ -11,7 +11,7 @@ import RdiInstancePageTemplate from 'uiSrc/templates/rdi-instance-page-template'
1111
import { formatLongName, Nullable, setTitle } from 'uiSrc/utils'
1212
import { setLastPageContext } from 'uiSrc/slices/app/context'
1313
import { PageNames } from 'uiSrc/constants'
14-
import { IPipelineStatus, PipelineStatus } from 'uiSrc/slices/interfaces'
14+
import { IPipelineStatus } from 'uiSrc/slices/interfaces'
1515
import Clients from './clients'
1616
import DataStreams from './data-streams'
1717
import Empty from './empty'
@@ -26,7 +26,7 @@ const isPipelineDeployed = (data: Nullable<IPipelineStatus>) => {
2626
return false
2727
}
2828

29-
return get(data, 'pipelines.default.status') !== PipelineStatus.NotReady
29+
return !isEmpty(data.pipelines)
3030
}
3131

3232
const StatisticsPage = () => {

redisinsight/ui/src/slices/interfaces/rdi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export enum PipelineStatus {
138138
export interface IPipelineStatus {
139139
components: Record<string, unknown>
140140
pipelines: {
141-
defaults: {
141+
defaults?: {
142142
status: PipelineStatus
143143
state: unknown
144144
tasks: unknown

0 commit comments

Comments
 (0)