Skip to content

Commit 4fa0194

Browse files
Merge pull request #2609 from RedisInsight/fe/feautre/RI-4962
#RI-4962 - send utm parameters from tutorials
2 parents fbccd2f + 8a6f8c4 commit 4fa0194

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

redisinsight/api/src/__mocks__/cloud-common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ export const mockCapiUnauthorizedError = {
77

88
export const mockUtm = {
99
source: 'redisinsight',
10-
medium: 'app',
10+
medium: 'sso',
1111
campaign: 'workbench',
1212
};

redisinsight/api/src/modules/cloud/common/models/cloud-request-utm.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ export class CloudRequestUtm {
1919
@IsOptional()
2020
@IsString()
2121
@IsNotEmpty()
22-
@Default('app')
23-
medium? = 'app';
22+
@Default('sso')
23+
medium? = 'sso';
2424

2525
@ApiPropertyOptional({
2626
type: String,

redisinsight/ui/src/slices/interfaces/cloud.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export enum CloudSsoUtmCampaign {
8282
BrowserSearch = 'redisinsight_browser_search',
8383
BrowserOverview = 'redisinsight_browser_overview',
8484
BrowserFilter = 'browser_filter',
85-
GuidesAndTutorials = 'redisinsight_doc_guide',
85+
Tutorial = 'tutorial',
8686
TriggersAndFunctions = 'redisinsight_triggers_and_functions',
8787
Unknown = 'other',
8888
}

redisinsight/ui/src/utils/oauth/cloudSsoUtm.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@ export const getCloudSsoUtmCampaign = (source?: string | null): CloudSsoUtmCampa
2222
return CloudSsoUtmCampaign.WelcomeScreen
2323
case OAuthSocialSource.TriggersAndFunctions:
2424
return CloudSsoUtmCampaign.TriggersAndFunctions
25-
// todo: not implemented yet
26-
// case OAuthSocialSource.Guides:
27-
// return CloudSsoUtmCampaign.GuidesAndTutorials
25+
case OAuthSocialSource.Tutorials:
26+
return CloudSsoUtmCampaign.Tutorial
2827
default:
2928
return CloudSsoUtmCampaign.Unknown
3029
}
@@ -33,6 +32,6 @@ export const getCloudSsoUtmCampaign = (source?: string | null): CloudSsoUtmCampa
3332
// Create search query utm parameters
3433
export const getCloudSsoUtmParams = (source?: string | null): URLSearchParams => new URLSearchParams([
3534
['source', 'redisinsight'],
36-
['medium', 'app'], // todo: distinguish between electron and web?
35+
['medium', 'sso'], // todo: distinguish between electron and web?
3736
['campaign', getCloudSsoUtmCampaign(source)],
3837
])

redisinsight/ui/src/utils/tests/oauth/cloudSsoUtm.spec.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ const getCloudSsoUtmCampaignTestCases = [
1414
[OAuthSocialSource.BrowserFiltering, CloudSsoUtmCampaign.BrowserFilter],
1515
[OAuthSocialSource.WelcomeScreen, CloudSsoUtmCampaign.WelcomeScreen],
1616
[OAuthSocialSource.TriggersAndFunctions, CloudSsoUtmCampaign.TriggersAndFunctions],
17+
[OAuthSocialSource.Tutorials, CloudSsoUtmCampaign.Tutorial],
1718
[null, CloudSsoUtmCampaign.Unknown],
1819
[undefined, CloudSsoUtmCampaign.Unknown],
1920
]
@@ -24,7 +25,7 @@ describe('getCloudSsoUtmCampaign', () => {
2425
(input, expected) => {
2526
expect(getCloudSsoUtmParams(input)).toEqual(new URLSearchParams([
2627
['source', 'redisinsight'],
27-
['medium', 'app'],
28+
['medium', 'sso'],
2829
['campaign', expected],
2930
]))
3031
}

0 commit comments

Comments
 (0)