Skip to content

Commit 51a2a04

Browse files
committed
#RI-3558 - fix pr comments
1 parent 33dd9df commit 51a2a04

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

redisinsight/ui/src/pages/databaseAnalysis/components/analysis-data-view/AnalysisDataView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { isNull } from 'lodash'
44
import { useParams } from 'react-router-dom'
55
import { sendEventTelemetry, TelemetryEvent } from 'uiSrc/telemetry'
66
import { Nullable } from 'uiSrc/utils'
7-
import { EmptyMessage } from 'uiSrc/pages/databaseAnalysis/constants'
7+
import { DEFAULT_EXTRAPOLATION, EmptyMessage } from 'uiSrc/pages/databaseAnalysis/constants'
88
import {
99
TopKeys,
1010
EmptyAnalysisMessage,
@@ -24,7 +24,7 @@ export interface Props {
2424

2525
const AnalysisDataView = (props: Props) => {
2626
const { loading, reports = [], data } = props
27-
const [extrapolation, setExtrapolation] = useState(1)
27+
const [extrapolation, setExtrapolation] = useState(DEFAULT_EXTRAPOLATION)
2828

2929
const { instanceId } = useParams<{ instanceId: string }>()
3030

redisinsight/ui/src/pages/databaseAnalysis/components/analysis-ttl-view/ExpirationGroupsView.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import AutoSizer from 'react-virtualized-auto-sizer'
44
import { useDispatch, useSelector } from 'react-redux'
55
import cx from 'classnames'
66

7+
import { DEFAULT_EXTRAPOLATION } from 'uiSrc/pages/databaseAnalysis'
78
import { extrapolate, formatBytes, formatExtrapolation, Nullable } from 'uiSrc/utils'
89
import { AreaChart } from 'uiSrc/components/charts'
910
import { AreaChartData, AreaChartDataType, DEFAULT_MULTIPLIER_GRID } from 'uiSrc/components/charts/area-chart/AreaChart'
@@ -29,7 +30,7 @@ const ExpirationGroupsView = (props: Props) => {
2930
const dispatch = useDispatch()
3031

3132
useEffect(() => {
32-
setIsExtrapolated(extrapolation !== 1)
33+
setIsExtrapolated(extrapolation !== DEFAULT_EXTRAPOLATION)
3334
}, [extrapolation])
3435

3536
useEffect(() => {
@@ -80,7 +81,7 @@ const ExpirationGroupsView = (props: Props) => {
8081
<EuiTitle className="section-title">
8182
<h4>MEMORY LIKELY TO BE FREED OVER TIME</h4>
8283
</EuiTitle>
83-
{extrapolation !== 1 && (
84+
{extrapolation !== DEFAULT_EXTRAPOLATION && (
8485
<EuiSwitch
8586
compressed
8687
color="subdued"

redisinsight/ui/src/pages/databaseAnalysis/components/summary-per-data/SummaryPerData.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { DonutChart } from 'uiSrc/components/charts'
66
import { ChartData } from 'uiSrc/components/charts/donut-chart/DonutChart'
77
import { KeyIconSvg, MemoryIconSvg } from 'uiSrc/components/database-overview/components/icons'
88
import { GROUP_TYPES_COLORS, GroupTypesColors } from 'uiSrc/constants'
9+
import { DEFAULT_EXTRAPOLATION } from 'uiSrc/pages/databaseAnalysis'
910
import { extrapolate, formatBytes, getGroupTypeDisplay, Nullable } from 'uiSrc/utils'
1011
import { getPercentage, numberWithSpaces } from 'uiSrc/utils/numbers'
1112

@@ -43,7 +44,7 @@ const SummaryPerData = ({ data, loading, extrapolation, onSwitchExtrapolation }:
4344
}
4445

4546
useEffect(() => {
46-
setIsExtrapolated(extrapolation !== 1)
47+
setIsExtrapolated(extrapolation !== DEFAULT_EXTRAPOLATION)
4748
}, [data, extrapolation])
4849

4950
useEffect(() => {
@@ -122,7 +123,7 @@ const SummaryPerData = ({ data, loading, extrapolation, onSwitchExtrapolation }:
122123
<EuiTitle className="section-title">
123124
<h4>SUMMARY PER DATA TYPE</h4>
124125
</EuiTitle>
125-
{extrapolation !== 1 && (
126+
{extrapolation !== DEFAULT_EXTRAPOLATION && (
126127
<EuiSwitch
127128
compressed
128129
color="subdued"

redisinsight/ui/src/pages/databaseAnalysis/components/top-namespace/TopNamespace.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React, { useEffect, useState } from 'react'
22
import cx from 'classnames'
33
import { EuiButton, EuiSwitch, EuiTitle } from '@elastic/eui'
44
import { Nullable } from 'uiSrc/utils'
5-
import { TableView } from 'uiSrc/pages/databaseAnalysis'
5+
import { DEFAULT_EXTRAPOLATION, TableView } from 'uiSrc/pages/databaseAnalysis'
66
import { TableLoader } from 'uiSrc/pages/databaseAnalysis/components'
77
import { DatabaseAnalysis } from 'apiSrc/modules/database-analysis/models'
88

@@ -22,7 +22,7 @@ const TopNamespace = (props: Props) => {
2222
const [isExtrapolated, setIsExtrapolated] = useState<boolean>(true)
2323

2424
useEffect(() => {
25-
setIsExtrapolated(extrapolation !== 1)
25+
setIsExtrapolated(extrapolation !== DEFAULT_EXTRAPOLATION)
2626
}, [data, extrapolation])
2727

2828
if (loading) {
@@ -61,7 +61,7 @@ const TopNamespace = (props: Props) => {
6161
>
6262
by Number of Keys
6363
</EuiButton>
64-
{extrapolation !== 1 && (
64+
{extrapolation !== DEFAULT_EXTRAPOLATION && (
6565
<EuiSwitch
6666
compressed
6767
color="subdued"

redisinsight/ui/src/pages/databaseAnalysis/constants.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,5 @@ export type Content = {
1515
title: string
1616
text: (path: string) => ReactNode
1717
}
18+
19+
export const DEFAULT_EXTRAPOLATION = 1

0 commit comments

Comments
 (0)