#RI-4810 - fix unit tests

Author: egor-zalenski

redisinsight/ui/src/components/live-time-recommendations/components/recommendation/Recommendation.spec.tsx

@@ -9,6 +9,7 @@ import { Pages } from 'uiSrc/constants'
 import { updateRecommendation } from 'uiSrc/slices/recommendations/recommendations'
 import { INSTANCE_ID_MOCK } from 'uiSrc/mocks/handlers/instances/instancesHandlers'
 import { MOCK_RECOMMENDATIONS } from 'uiSrc/constants/mocks/mock-recommendations'
+import { openNewWindowDatabase } from 'uiSrc/utils'
 import Recommendation, { IProps } from './Recommendation'
 
 const recommendationsContent = MOCK_RECOMMENDATIONS
@@ -24,6 +25,11 @@ jest.mock('uiSrc/telemetry', () => ({
   sendEventTelemetry: jest.fn(),
 }))
 
+jest.mock('uiSrc/utils', () => ({
+  ...jest.requireActual('uiSrc/utils'),
+  openNewWindowDatabase: jest.fn(),
+}))
+
 let store: typeof mockedStore
 beforeEach(() => {
   cleanup()
@@ -88,10 +94,10 @@ describe('Recommendation', () => {
     sendEventTelemetry.mockRestore()
   })
 
-  it('should properly push history on workbench page to specific guide', () => {
+  it('should properly call openNewWindowDatabase and open a new window on workbench page to specific guide', () => {
     // will be improved
-    const pushMock = jest.fn()
-    reactRouterDom.useHistory = jest.fn().mockReturnValue({ push: pushMock })
+    const openNewWindowDatabaseMock = jest.fn();
+    (openNewWindowDatabase as jest.Mock).mockImplementation(() => openNewWindowDatabaseMock)
 
     const { container } = render(
       <Recommendation
@@ -106,7 +112,7 @@ describe('Recommendation', () => {
     fireEvent.click(container.querySelector('[data-test-subj="searchJSON-button"]') as HTMLButtonElement)
     fireEvent.click(screen.getByTestId('searchJSON-to-tutorial-btn'))
 
-    expect(pushMock)
+    expect(openNewWindowDatabase)
       .toHaveBeenCalledWith(`${Pages.workbench(INSTANCE_ID_MOCK)}?guidePath=quick-guides/working-with-hash.html`)
     expect(sendEventTelemetry).toBeCalledWith({
       event: TelemetryEvent.INSIGHTS_RECOMMENDATION_TUTORIAL_CLICKED,
@@ -117,12 +123,13 @@ describe('Recommendation', () => {
       }
     })
     sendEventTelemetry.mockRestore()
+    openNewWindowDatabase.mockRestore()
   })
 
   it('should properly push history on workbench page to specific tutorial', () => {
     // will be improved
-    const pushMock = jest.fn()
-    reactRouterDom.useHistory = jest.fn().mockReturnValue({ push: pushMock })
+    const openNewWindowDatabaseMock = jest.fn();
+    (openNewWindowDatabase as jest.Mock).mockImplementation(() => openNewWindowDatabaseMock)
 
     const { container } = render(
       <Recommendation
@@ -137,7 +144,7 @@ describe('Recommendation', () => {
     fireEvent.click(container.querySelector('[data-test-subj="searchJSON-button"]') as HTMLButtonElement)
     fireEvent.click(screen.getByTestId('searchJSON-to-tutorial-btn'))
 
-    expect(pushMock)
+    expect(openNewWindowDatabase)
       .toHaveBeenCalledWith(`${Pages.workbench(INSTANCE_ID_MOCK)}?guidePath=/redis_stack/working_with_json.md`)
     expect(sendEventTelemetry).toBeCalledWith({
       event: TelemetryEvent.INSIGHTS_RECOMMENDATION_TUTORIAL_CLICKED,
@@ -148,6 +155,7 @@ describe('Recommendation', () => {
       }
     })
     sendEventTelemetry.mockRestore()
+    openNewWindowDatabase.mockRestore()
   })
 
   it('should render hide/unhide button', () => {

redisinsight/ui/src/components/oauth/oauth-connect-free-db/OAuthConnectFreeDb.spec.tsx

@@ -56,7 +56,7 @@ describe('OAuthConnectFreeDb', () => {
       }
     })
 
-    const expectedActions = [setDefaultInstance(), resetConnectedInstance()]
+    const expectedActions = [setDefaultInstance()]
     expect(store.getActions()).toEqual(expectedActions)
   })
 

redisinsight/ui/src/pages/databaseAnalysis/components/recommendations-view/Recommendations.spec.tsx

@@ -1,18 +1,23 @@
 import React from 'react'
-import reactRouterDom from 'react-router-dom'
 import { fireEvent, render, screen } from 'uiSrc/utils/test-utils'
 import { dbAnalysisSelector } from 'uiSrc/slices/analytics/dbAnalysis'
 import { INSTANCE_ID_MOCK } from 'uiSrc/mocks/handlers/analytics/clusterDetailsHandlers'
 import { sendEventTelemetry, TelemetryEvent } from 'uiSrc/telemetry'
 import { recommendationsSelector } from 'uiSrc/slices/recommendations/recommendations'
 
 import { MOCK_RECOMMENDATIONS } from 'uiSrc/constants/mocks/mock-recommendations'
+import { openNewWindowDatabase } from 'uiSrc/utils'
 import Recommendations from './Recommendations'
 
 const recommendationsContent = MOCK_RECOMMENDATIONS
 const mockdbAnalysisSelector = jest.requireActual('uiSrc/slices/analytics/dbAnalysis')
 const mockRecommendationsSelector = jest.requireActual('uiSrc/slices/recommendations/recommendations')
 
+jest.mock('uiSrc/utils', () => ({
+  ...jest.requireActual('uiSrc/utils'),
+  openNewWindowDatabase: jest.fn(),
+}))
+
 jest.mock('uiSrc/telemetry', () => ({
   ...jest.requireActual('uiSrc/telemetry'),
   sendEventTelemetry: jest.fn(),
@@ -470,8 +475,8 @@ describe('Recommendations', () => {
   })
 
   it('should call proper telemetry after click go tutorial button', () => {
-    const pushMock = jest.fn()
-    reactRouterDom.useHistory = jest.fn().mockReturnValue({ push: pushMock });
+    const openNewWindowDatabaseMock = jest.fn();
+    (openNewWindowDatabase as jest.Mock).mockImplementation(() => openNewWindowDatabaseMock);
 
     (dbAnalysisSelector as jest.Mock).mockImplementation(() => ({
       ...mockdbAnalysisSelector,
@@ -485,6 +490,7 @@ describe('Recommendations', () => {
     expect(screen.getByTestId('bigHashes-to-tutorial-btn')).toBeInTheDocument()
     fireEvent.click(screen.getByTestId('bigHashes-to-tutorial-btn'))
 
-    expect(pushMock).toBeCalledWith('/instanceId/workbench?guidePath=/quick-guides/document/introduction.md')
+    expect(openNewWindowDatabase).toBeCalledWith('/instanceId/workbench?guidePath=/quick-guides/document/introduction.md')
+    openNewWindowDatabase.mockRestore()
   })
 })

redisinsight/ui/src/pages/databaseAnalysis/components/recommendations-view/Recommendations.tsx

@@ -28,14 +28,14 @@ import { resetWorkbenchEASearch, setWorkbenchEAMinimized } from 'uiSrc/slices/ap
 import { EXTERNAL_LINKS } from 'uiSrc/constants/links'
 import { RecommendationVoting, RecommendationCopyComponent } from 'uiSrc/components'
 import { recommendationsSelector } from 'uiSrc/slices/recommendations/recommendations'
+import { openNewWindowDatabase } from 'uiSrc/utils'
 
 import {
   sortRecommendations,
   renderRecommendationBadgesLegend,
   renderRecommendationBadges,
   renderRecommendationContent,
 } from 'uiSrc/utils/recommendation/utils'
-import { openNewWindowDatabase } from 'uiSrc/utils'
 
 import styles from './styles.module.scss'