Skip to content

Commit 56ddb7d

Browse files
rdi fixes
1 parent 21d0cfd commit 56ddb7d

File tree

4 files changed

+17
-19
lines changed

4 files changed

+17
-19
lines changed

redisinsight/api/src/modules/rdi/client/api.rdi.client.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,11 @@ export class ApiRdiClient extends RdiClient {
110110
}
111111
}
112112

113-
async dryRunJob(data: RdiDryRunJobDto): Promise<RdiDryRunJobResponseDto> {
113+
async dryRunJob(dto: RdiDryRunJobDto): Promise<RdiDryRunJobResponseDto> {
114114
try {
115-
const response = await this.client.post(RdiUrl.DryRunJob, data);
116-
return response.data;
115+
const { data } = await this.client.post(RdiUrl.DryRunJob, dto);
116+
117+
return data;
117118
} catch (e) {
118119
throw wrapRdiPipelineError(e);
119120
}
@@ -134,20 +135,21 @@ export class ApiRdiClient extends RdiClient {
134135

135136
async getPipelineStatus(): Promise<any> {
136137
try {
137-
const response = await this.client.get(RdiUrl.GetPipelineStatus);
138+
const { data } = await this.client.get(RdiUrl.GetPipelineStatus);
138139

139-
return response.data;
140+
return data;
140141
} catch (e) {
141142
throw wrapRdiPipelineError(e);
142143
}
143144
}
144145

145146
async getStatistics(sections?: string): Promise<RdiStatisticsResult> {
146147
try {
147-
const response = await this.client.get(RdiUrl.GetStatistics, { params: { sections } });
148+
const { data } = await this.client.get(RdiUrl.GetStatistics, { params: { sections } });
149+
148150
return {
149151
status: RdiStatisticsStatus.Success,
150-
data: plainToClass(RdiStatisticsData, convertKeysToCamelCase(response.data)),
152+
data: plainToClass(RdiStatisticsData, convertKeysToCamelCase(data)),
151153
};
152154
} catch (e) {
153155
return { status: RdiStatisticsStatus.Fail, error: e.message };

redisinsight/api/src/modules/rdi/models/rdi.client.metadata.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Session, SessionMetadata } from 'src/common/models/session';
1+
import { SessionMetadata } from 'src/common/models/session';
22
import { Type } from 'class-transformer';
33
import {
44
IsNotEmpty,
@@ -7,7 +7,7 @@ import {
77

88
export class RdiClientMetadata {
99
@IsNotEmpty()
10-
@Type(() => Session)
10+
@Type(() => SessionMetadata)
1111
sessionMetadata: SessionMetadata;
1212

1313
@IsNotEmpty()

redisinsight/ui/src/pages/rdi/statistics/StatisticsPage.tsx

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { isEmpty } from 'lodash'
1+
import { get } from 'lodash'
22
import React, { useEffect } from 'react'
33
import { useDispatch, useSelector } from 'react-redux'
44
import { useParams } from 'react-router-dom'
@@ -12,7 +12,7 @@ import RdiInstancePageTemplate from 'uiSrc/templates/rdi-instance-page-template'
1212
import { formatLongName, Nullable, setTitle } from 'uiSrc/utils'
1313
import { setLastPageContext } from 'uiSrc/slices/app/context'
1414
import { PageNames } from 'uiSrc/constants'
15-
import { IPipelineStatus } from 'uiSrc/slices/interfaces'
15+
import { IPipelineStatus, PipelineStatus } from 'uiSrc/slices/interfaces'
1616
import Clients from './clients'
1717
import DataStreams from './data-streams'
1818
import Empty from './empty'
@@ -22,13 +22,9 @@ import TargetConnections from './target-connections'
2222

2323
import styles from './styles.module.scss'
2424

25-
const isPipelineDeployed = (data: Nullable<IPipelineStatus>) => {
26-
if (!data) {
27-
return false
28-
}
29-
30-
return !isEmpty(data.pipelines)
31-
}
25+
const isPipelineDeployed = (
26+
data: Nullable<IPipelineStatus>
27+
) => get(data, ['pipelines', 'default', 'status']) === PipelineStatus.Ready
3228

3329
const StatisticsPage = () => {
3430
const { rdiInstanceId } = useParams<{ rdiInstanceId: string }>()

redisinsight/ui/src/slices/interfaces/rdi.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export enum PipelineStatus {
138138
export interface IPipelineStatus {
139139
components: Record<string, unknown>
140140
pipelines: {
141-
defaults?: {
141+
default?: {
142142
status: PipelineStatus
143143
state: unknown
144144
tasks: unknown

0 commit comments

Comments
 (0)