Skip to content

Commit 57a72eb

Browse files
Merge pull request #2704 from RedisInsight/fe/bugfix/RI-5034
#RI-5034 - fix image for wb
2 parents 98bc9f6 + d2fdf6f commit 57a72eb

File tree

2 files changed

+29
-25
lines changed

2 files changed

+29
-25
lines changed

redisinsight/ui/src/pages/workbench/components/wb-results/WBResults/WBResults.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, { useContext } from 'react'
22
import cx from 'classnames'
3-
import { EuiButtonEmpty, EuiIcon, EuiText } from '@elastic/eui'
3+
import { EuiButtonEmpty, EuiText } from '@elastic/eui'
44

55
import { Theme } from 'uiSrc/constants'
66
import { ProfileQueryType } from 'uiSrc/pages/workbench/constants'
@@ -49,11 +49,13 @@ const WBResults = (props: Props) => {
4949

5050
const NoResults = (
5151
<div className={styles.noResults} data-testid="wb_no-results">
52-
<EuiIcon className={styles.arrowToGuides} type={ArrowToGuidesIcon} size="original" />
53-
<EuiIcon
52+
<ArrowToGuidesIcon
53+
className={styles.arrowToGuides}
54+
/>
55+
<img
5456
className={styles.noResultsIcon}
55-
type={theme === Theme.Dark ? TelescopeDark : TelescopeLight}
56-
size="original"
57+
src={theme === Theme.Dark ? TelescopeDark : TelescopeLight}
58+
alt="no results"
5759
data-testid="wb_no-results__icon"
5860
/>
5961
<EuiText className={styles.noResultsTitle} data-testid="wb_no-results__title">

redisinsight/ui/src/utils/tests/plugins.spec.ts

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,26 +2,28 @@ import { getVisualizationsByCommand } from 'uiSrc/utils'
22
import { IPluginVisualization } from 'uiSrc/slices/interfaces'
33

44
describe('getVisualizationsByCommand', () => {
5-
it('should return proper visualizations by query', () => {
6-
const visualizations = [
7-
{ matchCommands: ['ft.search', 'ft.get'] },
8-
{ matchCommands: ['ft._list'] },
9-
{ matchCommands: ['ft.*'] },
10-
{ matchCommands: ['get'] }
11-
] as IPluginVisualization[]
5+
const getVisualizationsByCommandTests: [string, number][] = [
6+
['ft.search sa', 2],
7+
['ft.get zxc', 2],
8+
['command ft. zxc zxcz ft', 0],
9+
['command ft', 0],
10+
['any command', 0],
11+
['get key', 1],
12+
]
1213

13-
const query1 = 'ft.search sa'
14-
const query2 = 'ft.get zxc'
15-
const query3 = 'command ft. zxc zxcz ft'
16-
const query4 = 'command ft'
17-
const query5 = 'any command'
18-
const query6 = 'get key'
14+
const visualizations = [
15+
{ matchCommands: ['ft.search', 'ft.get'] },
16+
{ matchCommands: ['ft._list'] },
17+
{ matchCommands: ['ft.*'] },
18+
{ matchCommands: ['get'] }
19+
] as IPluginVisualization[]
1920

20-
expect(getVisualizationsByCommand(query1, visualizations)).toHaveLength(2)
21-
expect(getVisualizationsByCommand(query2, visualizations)).toHaveLength(2)
22-
expect(getVisualizationsByCommand(query3, visualizations)).toHaveLength(0)
23-
expect(getVisualizationsByCommand(query4, visualizations)).toHaveLength(0)
24-
expect(getVisualizationsByCommand(query5, visualizations)).toHaveLength(0)
25-
expect(getVisualizationsByCommand(query6, visualizations)).toHaveLength(1)
26-
})
21+
test.each(getVisualizationsByCommandTests)(
22+
'for %j, should be %i',
23+
(input, expected) => {
24+
// @ts-ignore
25+
const result = getVisualizationsByCommand(input, visualizations)
26+
expect(result).toHaveLength(expected)
27+
}
28+
)
2729
})

0 commit comments

Comments
 (0)