#RI-4567 - Refactoring main.dev.js

Author: egor-zalenski

.eslintrc.js

@@ -1,17 +1,63 @@
 module.exports = {
   root: true,
+  env: {
+    node: true,
+  },
   extends: ['airbnb-typescript'],
   plugins: ['@typescript-eslint'],
   parser: '@typescript-eslint/parser',
   rules: {
-    'max-len': ['warn', 120],
+    semi: ['error', 'never'],
+    quotes: [2, 'single', { avoidEscape: true }],
+    'max-len': ['error', { ignoreComments: true, ignoreStrings: true, ignoreRegExpLiterals: true, code: 120 }],
     'class-methods-use-this': 'off',
     'import/no-extraneous-dependencies': 'off', // temporary disabled
+    '@typescript-eslint/semi': ['error', 'never'],
+    'object-curly-newline': 'off',
+    'import/prefer-default-export': 'off',
+    '@typescript-eslint/comma-dangle': 'off',
+    'implicit-arrow-linebreak': 'off',
+    'import/order': [
+      1,
+      {
+        groups: [
+          'external',
+          'builtin',
+          'internal',
+          'sibling',
+          'parent',
+          'index',
+        ],
+        pathGroups: [
+          {
+            pattern: 'desktopSrc/**',
+            group: 'internal',
+            position: 'after'
+          },
+          {
+            pattern: 'uiSrc/**',
+            group: 'internal',
+            position: 'after'
+          },
+          {
+            pattern: 'apiSrc/**',
+            group: 'internal',
+            position: 'after'
+          },
+        ],
+        warnOnUnassignedImports: true,
+        pathGroupsExcludedImportTypes: ['builtin']
+      },
+    ],
   },
   parserOptions: {
     project: './tsconfig.json',
+    ecmaVersion: 2020,
+    sourceType: 'module',
+    createDefaultProgram: true,
   },
   ignorePatterns: [
     'redisinsight/ui',
+    'redisinsight/api',
   ],
-};
+}

.gitignore

@@ -36,7 +36,6 @@ lerna-debug.log*
 .vscode
 
 # App packaged
-redisinsight/electron/preload.js
 release
 main.prod.js
 main.prod.js.map

configs/webpack.config.base.ts

@@ -35,11 +35,6 @@ const configuration: webpack.Configuration =  {
     extensions: ['.js', '.jsx', '.json', '.ts', '.tsx', '.scss'],
     modules: [webpackPaths.apiPath, 'node_modules'],
     plugins: [new TsconfigPathsPlugins()],
-    alias: {
-      src: webpackPaths.apiSrcPath,
-      apiSrc: webpackPaths.apiSrcPath,
-      uiSrc: webpackPaths.uiSrcPath,
-    },
   },
 
   plugins: [

configs/webpack.config.main.prod.ts

@@ -24,16 +24,8 @@ export default merge(baseConfig, {
   target: 'electron-main',
 
   entry: {
-    main: path.join(webpackPaths.electronPath, 'main.dev.ts'),
-    preload: path.join(webpackPaths.electronPath, 'preload.ts'),
-  },
-
-  resolve: {
-    alias: {
-      ['apiSrc']: webpackPaths.apiSrcPath,
-      ['src']: webpackPaths.apiSrcPath,
-    },
-    extensions: ['.tsx', '.ts', '.js', '.jsx'],
+    main: path.join(webpackPaths.desktopPath, 'index.ts'),
+    preload: path.join(webpackPaths.desktopPath, 'preload.ts'),
   },
 
   output: {

configs/webpack.config.preload.dev.ts

@@ -12,7 +12,7 @@ const configuration: webpack.Configuration = {
 
   target: 'electron-preload',
 
-  entry: path.join(webpackPaths.electronPath, 'preload.ts'),
+  entry: path.join(webpackPaths.desktopPath, 'preload.ts'),
 
   output: {
     path: webpackPaths.dllPath,

configs/webpack.config.renderer.dev.dll.ts

@@ -54,7 +54,7 @@ export default merge(baseConfig, {
     new webpack.LoaderOptionsPlugin({
       debug: true,
       options: {
-        context: webpackPaths.electronPath,
+        context: webpackPaths.desktopPath,
         output: {
           path: webpackPaths.dllPath,
         },

configs/webpack.config.renderer.dev.ts

@@ -51,22 +51,14 @@ const configuration: webpack.Configuration = {
   ],
 
   output: {
-    path: webpackPaths.electronPath,
+    path: webpackPaths.desktopPath,
     publicPath: '/',
     filename: 'renderer.dev.js',
     library: {
       type: 'umd',
     },
   },
 
-  resolve: {
-    alias: {
-      src: webpackPaths.apiSrcPath,
-      apiSrc: webpackPaths.apiSrcPath,
-      uiSrc: webpackPaths.uiSrcPath,
-    },
-  },
-
   module: {
     rules: [
       {
@@ -243,7 +235,7 @@ const configuration: webpack.Configuration = {
 
     new HtmlWebpackPlugin({
       filename: path.join('index.html'),
-      template: path.join(webpackPaths.electronPath, 'index.ejs'),
+      template: path.join(webpackPaths.desktopPath, 'index.ejs'),
       minify: {
         collapseWhitespace: true,
         removeAttributeQuotes: true,

configs/webpack.config.renderer.prod.ts

@@ -189,7 +189,7 @@ const configuration: webpack.Configuration = {
 
     new HtmlWebpackPlugin({
       filename: 'index.html',
-      template: path.join(webpackPaths.electronPath, 'index.ejs'),
+      template: path.join(webpackPaths.desktopPath, 'index.ejs'),
       isBrowser: false,
       isDevelopment: false,
     }),

configs/webpack.config.web.common.ts

@@ -6,6 +6,7 @@ import webpack from 'webpack';
 import HtmlWebpackPlugin from 'html-webpack-plugin';
 import TsconfigPathsPlugin from 'tsconfig-paths-webpack-plugin';
 import MonacoWebpackPlugin from 'monaco-editor-webpack-plugin';
+import webpackPaths from './webpack.paths';
 import { dependencies as externals } from '../redisinsight/package.json';
 import { dependencies as externalsApi } from '../redisinsight/api/package.json';
 
@@ -18,12 +19,11 @@ export default {
     rules: [
       {
         test: /\.(js|jsx|ts|tsx)?$/,
-        // exclude: /node_modules/,
-        include: [path.resolve(__dirname, '../redisinsight/ui')],
+        include: [webpackPaths.uiPath],
         exclude: [
           /node_modules/,
-          path.resolve(__dirname, '../redisinsight/api'),
-          path.resolve(__dirname, '../redisinsight/electron'),
+          webpackPaths.apiPath,
+          webpackPaths.desktopPath,
         ],
         use: {
           loader: 'babel-loader',
@@ -44,8 +44,7 @@ export default {
     ],
   },
 
-  // context: path.resolve(__dirname, '../redisinsight/api/src'),
-  context: path.resolve(__dirname, '../redisinsight/ui'),
+  context: webpackPaths.uiPath,
 
   /**
    * Determine the array of extensions that should be used to resolve modules.

configs/webpack.paths.ts

@@ -8,10 +8,10 @@ const apiPath = path.join(riPath, 'api');
 const uiPath = path.join(riPath, 'ui');
 const apiSrcPath = path.join(apiPath, 'src');
 const uiSrcPath = path.join(uiPath, 'src');
-const electronPath = path.join(riPath, 'electron');
-const srcMainPath = path.join(electronPath, 'main');
+const desktopPath = path.join(riPath, 'desktop');
+const desktopSrcPath = path.join(desktopPath, 'src');
 
-const dllPath = path.join(electronPath, 'dll');
+const dllPath = path.join(desktopPath, 'dll');
 
 const releasePath = path.join(rootPath, 'release');
 const appPackagePath = path.join(riPath, 'package.json');
@@ -32,9 +32,9 @@ export default {
   riPath,
   apiSrcPath,
   uiSrcPath,
-  srcMainPath,
   releasePath,
-  electronPath,
+  desktopPath,
+  desktopSrcPath,
   appPackagePath,
   appNodeModulesPath,
   srcNodeModulesPath,