RI-6299 - Total count keys can be -1 (#4142)

* RI-6299 - Total count keys can be -1

Also fixed TS errors and linting across the file. The actual fix is on line 245

* cleanup

Author: Kristiyan Ivanov

redisinsight/ui/src/slices/browser/keys.ts

@@ -238,11 +238,11 @@ const keysSlice = createSlice({
       state.deleting = false
     },
     deletePatternKeyFromList: (state, { payload }) => {
-      remove(state.data?.keys, (key) => isEqualBuffers(key.name, payload))
+      remove(state.data?.keys, (key) => isEqualBuffers(key.name as RedisResponseBuffer, payload))
 
       state.data = {
         ...state.data,
-        total: state.data.total - 1,
+        total: Math.max(state.data.total - 1, 0),
         scanned: state.data.scanned - 1,
       }
     },
@@ -271,9 +271,12 @@ const keysSlice = createSlice({
     },
     editPatternKeyFromList: (state, { payload }) => {
       const keys = state.data.keys.map((key) => {
-        if (isEqualBuffers(key.name, payload?.key)) {
-          key.name = payload?.newKey
-          key.nameString = bufferToString(payload?.newKey)
+        if (isEqualBuffers(key.name as RedisResponseBuffer, payload?.key)) {
+          return {
+            ...key,
+            name: payload?.newKey,
+            nameString: bufferToString(payload?.newKey)
+          }
         }
         return key
       })
@@ -286,7 +289,7 @@ const keysSlice = createSlice({
 
     editPatternKeyTTLFromList: (state, { payload: [key, ttl] }: PayloadAction<[RedisResponseBuffer, number]>) => {
       const keys = state.data.keys.map((keyData) => {
-        if (isEqualBuffers(keyData.name, key)) {
+        if (isEqualBuffers(keyData.name as RedisResponseBuffer, key)) {
           keyData.ttl = ttl
         }
         return keyData
@@ -348,12 +351,12 @@ const keysSlice = createSlice({
       state.filter = payload
     },
 
-    changeKeyViewType: (state, { payload }:{ payload: KeyViewType }) => {
+    changeKeyViewType: (state, { payload }: { payload: KeyViewType }) => {
       state.viewType = payload
       localStorageService?.set(BrowserStorageItem.browserViewType, payload)
     },
 
-    changeSearchMode: (state, { payload }:{ payload: SearchMode }) => {
+    changeSearchMode: (state, { payload }: { payload: SearchMode }) => {
       state.searchMode = payload
     },
 
@@ -541,7 +544,7 @@ export function fetchPatternKeysAction(
       if (isStatusSuccessful(status)) {
         dispatch(
           loadKeysSuccess({
-            data: parseKeysListResponse({}, data),
+            data: parseKeysListResponse({}, data as never[]),
             isSearched: !!match,
             isFiltered: !!type,
           })
@@ -571,7 +574,8 @@ export function fetchPatternKeysAction(
         }
         onSuccess?.(data)
       }
-    } catch (error) {
+    } catch (_err) {
+      const error = _err as AxiosError
       if (!axios.isCancel(error)) {
         const errorMessage = getApiErrorMessage(error)
         dispatch(addErrorNotification(error))
@@ -632,7 +636,8 @@ export function fetchMorePatternKeysAction(oldKeys: IKeyPropTypes[] = [], cursor
           }
         })
       }
-    } catch (error) {
+    } catch (_err) {
+      const error = _err as AxiosError
       if (!axios.isCancel(error)) {
         const errorMessage = getApiErrorMessage(error)
         dispatch(addErrorNotification(error))
@@ -732,10 +737,12 @@ export function refreshKeyInfoAction(key: RedisResponseBuffer) {
         dispatch(refreshKeyInfoSuccess(data))
         dispatch(updateSelectedKeyRefreshTime(Date.now()))
       }
-    } catch (error) {
+    } catch (_err) {
+      const error = _err as AxiosError
       dispatch(refreshKeyInfoFail())
       dispatch(addErrorNotification(error))
-      if (isStatusNotFoundError(get(error, ['response', 'status']))) {
+      const status = get(error, ['response', 'status'])
+      if (status && isStatusNotFoundError(status)) {
         dispatch(resetKeyInfo())
         dispatch(deleteKeyFromList(key))
       }
@@ -783,7 +790,8 @@ function addTypedKey(
           }
         })
       }
-    } catch (error) {
+    } catch (_err) {
+      const error = _err as AxiosError
       if (onFailAction) {
         onFailAction()
       }
@@ -885,7 +893,8 @@ export function deleteSelectedKeyAction(
         onSuccessAction?.()
         dispatch(addMessageNotification(successMessages.DELETED_KEY(key)))
       }
-    } catch (error) {
+    } catch (_err) {
+      const error = _err as AxiosError
       const errorMessage = getApiErrorMessage(error as AxiosError)
       dispatch(addErrorNotification(error as AxiosError))
       dispatch(deleteSelectedKeyFailure(errorMessage))
@@ -920,7 +929,8 @@ export function deleteKeyAction(
         onSuccessAction?.()
         dispatch(addMessageNotification(successMessages.DELETED_KEY(key)))
       }
-    } catch (error) {
+    } catch (_err) {
+      const error = _err as AxiosError
       dispatch(addErrorNotification(error as AxiosError))
       dispatch(deleteKeyFailure())
     }
@@ -953,7 +963,8 @@ export function editKey(
         dispatch<any>(editKeyFromList({ key, newKey }))
         onSuccess?.()
       }
-    } catch (error) {
+    } catch (_err) {
+      const error = _err as AxiosError
       const errorMessage = getApiErrorMessage(error)
       dispatch(addErrorNotification(error))
       dispatch(defaultSelectedKeyActionFailure(errorMessage))
@@ -1000,7 +1011,8 @@ export function editKeyTTL(key: RedisResponseBuffer, ttl: number) {
         }
         dispatch(defaultSelectedKeyActionSuccess())
       }
-    } catch (error) {
+    } catch (_err) {
+      const error = _err as AxiosError
       const errorMessage = getApiErrorMessage(error)
       dispatch(addErrorNotification(error))
       dispatch(defaultSelectedKeyActionFailure(errorMessage))
@@ -1055,7 +1067,7 @@ export function fetchKeysMetadataTree(
           state.connections.instances?.connectedInstance?.id,
           ApiEndpoints.KEYS_METADATA
         ),
-        { keys: keys.map(([,nameBuffer]) => nameBuffer), type: filter || undefined },
+        { keys: keys.map(([, nameBuffer]) => nameBuffer), type: filter || undefined },
         { params: { encoding: state.app.info.encoding }, signal }
       )