mock github link

Author: irinaAbramova-dev

redisinsight/api/src/common/validators/github-link.validator.ts

@@ -2,16 +2,10 @@ import {
   ValidatorConstraint,
   ValidatorConstraintInterface,
 } from 'class-validator';
-import config from 'src/utils/config';
-
-const SERVER_CONFIG = config.get('server');
 
 @ValidatorConstraint({ name: 'GitHubLink', async: false })
 export class GitHubLink implements ValidatorConstraintInterface {
   validate(value: any) {
-    // TODO: temporary solution for integration tests
-    if (SERVER_CONFIG.env === 'test') return true;
-
     // Regular expression to match any GitHub URL
     const githubUrlRegex = /^https:\/\/github\.com(?:\/[^\s/]+(?:\/[^\s/]+)*)?\/?$/;
     return typeof value === 'string' && githubUrlRegex.test(value);

redisinsight/api/test/api/custom-tutorials/POST-custom-tutorials.test.ts

@@ -9,9 +9,10 @@ import {
   path,
   serverConfig, requirements,
   before,
+  nock,
   _,
 } from '../deps';
-import { getBaseURL } from '../../helpers/server';
+import * as fs from 'fs-extra'
 const { server, request, localDb } = deps;
 
 // create endpoint
@@ -107,12 +108,17 @@ const globalManifest = {
   children: [],
 };
 
+const nockScope = nock('https://github.com/somerepo');
+
 describe('POST /custom-tutorials', () => {
   requirements('rte.serverType=local');
 
   before(async () => {
     await fsExtra.remove(customTutorialsFolder);
     await (await localDb.getRepository(localDb.repositories.CUSTOM_TUTORIAL)).clear();
+
+    const zip = fs.readFileSync(path.join(staticsFolder, 'test.zip'))
+    nockScope.get('/test.zip').reply(200, zip);
   });
 
   describe('Common', () => {
@@ -197,7 +203,7 @@ describe('POST /custom-tutorials', () => {
 
     it('should import tutorial from the external link with manifest', async () => {
       const zip = new AdmZip(path.join(staticsFolder, 'test.zip'));
-      const link = `${getBaseURL()}/static/test.zip`;
+      const link = `https://github.com/somerepo/test.zip`;
 
       await validateApiCall({
         endpoint: creatEndpoint,