Skip to content

Commit 613d1a8

Browse files
remove skip
1 parent 9030fb2 commit 613d1a8

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

tests/e2e/helpers/constants.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,3 +81,9 @@ export enum ExploreTabs {
8181
Tips = 'Tips',
8282
}
8383

84+
export enum Compatibility {
85+
SearchAndQuery = 'search',
86+
Json = 'json',
87+
TimeSeries = 'time-series'
88+
}
89+
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import { Selector, t } from 'testcafe';
2+
import { Compatibility } from '../../helpers/constants';
23

34
export class CompatibilityPromotion {
4-
compatibilityLinks = Selector('[data-testid*=capability-promotion-]').find('div');
5-
5+
linkMask = '[data-testid="guide-icon-$name"]';
66
/**
77
* Click on link
88
* @param name Name of the compatibility
99
*/
10-
async clickOnLinkByName(name: string): Promise<void> {
11-
const link = this.compatibilityLinks.withText(name);
10+
async clickOnLinkByName(name: Compatibility): Promise<void> {
11+
const link = Selector(this.linkMask.replace(/\$name/g, name));
1212
await t.click(link);
1313
}
1414
}

tests/e2e/tests/web/regression/insights/open-insights-panel.e2e.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { BrowserPage, MyRedisDatabasePage, WelcomePage, WorkbenchPage } from '../../../../pageObjects';
2-
import { ExploreTabs, rte } from '../../../../helpers/constants';
2+
import { Compatibility, ExploreTabs, rte } from '../../../../helpers/constants';
33
import { DatabaseHelper } from '../../../../helpers/database';
44
import {
55
commonUrl,
@@ -70,8 +70,8 @@ test
7070
await t.expect(await browserPage.InsightsPanel.existsCompatibilityPopover.textContent).contains('time series', 'popover is not displayed');
7171
await t.expect(tab.preselectArea.textContent).contains('REDIS FOR TIME SERIES', 'the tutorial is incorrect');
7272
});
73-
// the test is skipped until https://redislabs.atlassian.net/browse/RI-5345 is finished
74-
test.skip
73+
74+
test
7575
.before(async t => {
7676
await databaseAPIRequests.deleteAllDatabasesApi();
7777
await databaseHelper.acceptLicenseTermsAndAddDatabaseApi(ossStandaloneConfig);
@@ -83,7 +83,7 @@ test.skip
8383
const myRedisTutorial = 'Time series';
8484

8585
await t.click(browserPage.NavigationPanel.myRedisDBButton);
86-
await myRedisDatabasePage.CompatibilityPromotion.clickOnLinkByName(myRedisTutorial);
86+
await myRedisDatabasePage.CompatibilityPromotion.clickOnLinkByName(Compatibility.TimeSeries);
8787
await t.expect(await myRedisDatabasePage.InsightsPanel.getActiveTabName()).eql(ExploreTabs.Explore);
8888
let tab = await myRedisDatabasePage.InsightsPanel.setActiveTab(ExploreTabs.Explore);
8989
await t.expect(tab.preselectArea.textContent).contains(myRedisTutorial, 'the tutorial is incorrect');
@@ -93,7 +93,7 @@ test.skip
9393
await myRedisDatabasePage.InsightsPanel.togglePanel(false);
9494
await myRedisDatabasePage.deleteAllDatabases();
9595

96-
await welcomePage.CompatibilityPromotion.clickOnLinkByName(welcomeTutorial);
96+
await welcomePage.CompatibilityPromotion.clickOnLinkByName(Compatibility.Json);
9797
await t.expect(await welcomePage.InsightsPanel.getActiveTabName()).eql(ExploreTabs.Explore);
9898
tab = await welcomePage.InsightsPanel.setActiveTab(ExploreTabs.Explore);
9999
await t.expect(tab.preselectArea.textContent).contains(welcomeTutorial, 'the tutorial is incorrect');

0 commit comments

Comments
 (0)