Skip to content

Commit 645c976

Browse files
Merge pull request #3428 from RedisInsight/e2e/feature/RI-4616-rdi-support
add edit instance verification
2 parents 5de82f2 + 589fc51 commit 645c976

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

tests/e2e/tests/web/critical-path/rdi/add-rdi-instance.e2e.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,33 +8,35 @@ import { commonUrl } from '../../../../helpers/conf';
88
import { RdiPopoverOptions, RedisOverviewPage } from '../../../../helpers/constants';
99
import { MyRedisDatabasePage } from '../../../../pageObjects';
1010
import { DatabaseHelper } from '../../../../helpers';
11+
import { RdiApiRequests } from '../../../../helpers/api/api-rdi';
1112

1213
const rdiInstancesListPage = new RdiInstancesListPage();
1314
const browserActions = new BrowserActions();
1415
const rdiInstancePage = new RdiInstancePage();
1516
const myRedisDatabasePage = new MyRedisDatabasePage();
1617
const databaseHelper = new DatabaseHelper();
18+
const rdiApiRequests = new RdiApiRequests();
1719

1820
const rdiInstance: RdiInstance = {
1921
alias: 'Alias',
20-
url: 'url',
22+
url: 'http://localhost:4000',
2123
username: 'username',
22-
password: 'password',
24+
password: 'passwordPassword',
2325
version: '1.2'
2426
};
2527
const rdiInstance2: RdiInstance = {
2628
alias: 'test',
27-
url: 'http://test',
29+
url: 'http://localhost:4000',
2830
username: 'name',
29-
password: 'pass',
31+
password: 'pass2024',
3032
version: '1.2'
3133
};
3234

3335
const rdiInstance3: RdiInstance = {
3436
alias: 'first',
35-
url: 'http://localhost:8080/',
37+
url: 'http://localhost:4000',
3638
username: 'name',
37-
password: 'pass',
39+
password: 'passPassword2024',
3840
version: '1.2'
3941
};
4042
//skip the tests until rdi integration is added
@@ -44,6 +46,7 @@ fixture.skip `Rdi instance`
4446
.page(commonUrl)
4547
.beforeEach(async() => {
4648
await databaseHelper.acceptLicenseTerms();
49+
await rdiApiRequests.deleteAllRdiApi();
4750
await myRedisDatabasePage.setActivePage(RedisOverviewPage.Rdi);
4851

4952
})
@@ -120,6 +123,12 @@ test('Verify that user has the same sorting if db name is changed', async t => {
120123
await t.click(rdiInstancesListPage.AddRdiInstance.addInstanceButton);
121124

122125
rdiInstance.alias = newAliasName;
126+
const addRdiInstance = await rdiInstancesListPage.getRdiInstanceValuesByIndex(1);
127+
128+
await t.expect(addRdiInstance.alias).eql(rdiInstance.alias, 'added alias is not corrected');
129+
await t.expect(addRdiInstance.lastConnection?.length).gt(1, 'last connection is not displayed');
130+
await t.expect(addRdiInstance.url).eql(rdiInstance.url, 'added alias is not corrected');
131+
await t.expect(addRdiInstance.version).eql(rdiInstance.version, 'added alias is not corrected');
123132

124133
const sortedByAliasTypeUpdated = [rdiInstance3.alias, rdiInstance.alias, rdiInstance2.alias];
125134
actualDatabaseList = await rdiInstancesListPage.getAllRdiNames();

tests/e2e/tests/web/critical-path/rdi/configuration.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ test('Verify that user can test connection', async() => {
5959
await rdiInstancePage.TestConnectionPanel.expandOrCollapseSection(TextConnectionSection.Failed, true);
6060

6161
// TODO check expected value
62-
await t.expect(await rdiInstancePage.TestConnectionPanel.getSectionRowTextByIndex(TextConnectionSection.Failed, 0)).contains('redis', 'endpoint is not empty');
62+
await t.expect(await rdiInstancePage.TestConnectionPanel.getSectionRowTextByIndex(TextConnectionSection.Failed, 0)).contains(' ', 'error test is empty');
6363
await t.click(rdiInstancePage.TestConnectionPanel.closeSection);
6464
await t.expect(rdiInstancePage.TestConnectionPanel.sidePanel.exists).notOk('the panel is not closed');
6565
});

0 commit comments

Comments
 (0)