Skip to content

Commit 64a1ab0

Browse files
committed
#RI-5033 - fix pr comment
1 parent 987cdde commit 64a1ab0

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

redisinsight/ui/src/pages/browser/modules/key-details-header/KeyDetailsHeader.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,8 @@ const KeyDetailsHeader = ({
8484
dispatch(editKey(oldKey, newKey, () => onEditKey(oldKey, newKey), onFailure))
8585
}
8686

87-
const handleDeleteKey = (key: RedisResponseBuffer, type: string) => {
88-
dispatch(deleteSelectedKeyAction(key,
89-
() => {
90-
if (type === KeyTypes.String) {
91-
dispatch(resetStringValue())
92-
}
93-
onRemoveKey()
94-
}))
87+
const handleDeleteKey = (key: RedisResponseBuffer) => {
88+
dispatch(deleteSelectedKeyAction(key, onRemoveKey))
9589
}
9690

9791
const handleEnableAutoRefresh = (enableAutoRefresh: boolean, refreshRate: string) => {

redisinsight/ui/src/pages/browser/modules/key-details-header/components/key-details-header-delete/KeyDetailsHeaderDelete.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
import styles from './styles.module.scss'
1919

2020
export interface Props {
21-
onDelete: (key: RedisResponseBuffer, type: string) => void
21+
onDelete: (key: RedisResponseBuffer) => void
2222
}
2323

2424
const KeyDetailsHeaderDelete = ({ onDelete }: Props) => {
@@ -88,7 +88,7 @@ const KeyDetailsHeaderDelete = ({ onDelete }: Props) => {
8888
size="s"
8989
color="warning"
9090
iconType="trash"
91-
onClick={() => onDelete(keyBuffer, type)}
91+
onClick={() => onDelete(keyBuffer)}
9292
className={styles.popoverDeleteBtn}
9393
data-testid="delete-key-confirm-btn"
9494
>

redisinsight/ui/src/pages/browser/modules/key-details/components/string-details/StringDetails.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,15 @@ import {
1818
import { KeyDetailsHeader, KeyDetailsHeaderProps } from 'uiSrc/pages/browser/modules'
1919
import { RedisResponseBuffer } from 'uiSrc/slices/interfaces'
2020
import { IFetchKeyArgs } from 'uiSrc/constants/prop-types/keys'
21-
import { stringDataSelector, stringSelector } from 'uiSrc/slices/browser/string'
21+
import { resetStringValue, stringDataSelector, stringSelector } from 'uiSrc/slices/browser/string'
2222
import { isFormatEditable, isFullStringLoaded } from 'uiSrc/utils'
2323
import { StringDetailsTable } from './string-details-table'
2424
import { EditItemAction } from '../key-details-actions'
2525

2626
export interface Props extends KeyDetailsHeaderProps {}
2727

2828
const StringDetails = (props: Props) => {
29+
const { onRemoveKey } = props
2930
const keyType = KeyTypes.String
3031

3132
const { loading, viewFormat: viewFormatProp } = useSelector(selectedKeySelector)
@@ -46,6 +47,11 @@ const StringDetails = (props: Props) => {
4647
dispatch(refreshKey(key, type, args))
4748
}
4849

50+
const handleRemoveKey = () => {
51+
dispatch(resetStringValue())
52+
onRemoveKey()
53+
}
54+
4955
const Actions = () => (
5056
<EditItemAction
5157
title="Edit Value"
@@ -61,6 +67,7 @@ const StringDetails = (props: Props) => {
6167
{...props}
6268
key="key-details-header"
6369
keyType={keyType}
70+
onRemoveKey={handleRemoveKey}
6471
Actions={Actions}
6572
/>
6673
<div className="key-details-body" key="key-details-body">

0 commit comments

Comments
 (0)