Merge pull request #377 from RedisInsight/bugfix/RI-2499-avoid_using_common_id_for_non_tracking

Avoid using common id for non-tracking events such as APPLICATION_STA…

Author: arthosofteq

redisinsight/api/src/modules/core/services/analytics/analytics.service.spec.ts

@@ -115,7 +115,7 @@ describe('AnalyticsService', () => {
       });
 
       expect(mockAnalyticsTrack).toHaveBeenCalledWith({
-        anonymousId: NON_TRACKING_ANONYMOUS_ID,
+        anonymousId: mockAnonymousId,
         integrations: { Amplitude: { session_id: sessionId } },
         event: TelemetryEvents.ApplicationStarted,
         properties: {},

redisinsight/api/src/modules/core/services/analytics/analytics.service.ts

@@ -61,7 +61,7 @@ export class AnalyticsService {
         'agreements.analytics',
         false,
       );
-      if (isAnalyticsGranted) {
+      if (isAnalyticsGranted || nonTracking) {
         this.analytics.track({
           anonymousId: this.anonymousId,
           integrations: { Amplitude: { session_id: this.sessionId } },
@@ -70,15 +70,6 @@ export class AnalyticsService {
             ...eventData,
           },
         });
-      } else if (nonTracking) {
-        this.analytics.track({
-          anonymousId: NON_TRACKING_ANONYMOUS_ID,
-          integrations: { Amplitude: { session_id: this.sessionId } },
-          event,
-          properties: {
-            ...eventData,
-          },
-        });
       }
     } catch (e) {
       // continue regardless of error