Skip to content

Commit 68eb629

Browse files
committed
in PrivateRoute, redirect to notFound page when route is behind feature flag
1 parent 7a3e494 commit 68eb629

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

redisinsight/ui/src/components/onboarding-features/OnboardingFeatures.spec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import {
3131
import { InsightsPanelTabs, SidePanels } from 'uiSrc/slices/interfaces/insights'
3232
import { ONBOARDING_FEATURES } from './OnboardingFeatures'
3333

34-
// const { setOnboardNextStep, setOnboardPrevStep } = featureSlice
3534
jest.mock('uiSrc/slices/app/features', () => ({
3635
...jest.requireActual('uiSrc/slices/app/features'),
3736
appFeatureOnboardingSelector: jest.fn().mockReturnValue({

redisinsight/ui/src/utils/routerWithSubRoutes.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Redirect, Route } from 'react-router-dom'
33
import { useSelector } from 'react-redux'
44
import { userSettingsSelector } from 'uiSrc/slices/user/user-settings'
55
import { appFeatureFlagsFeaturesSelector } from 'uiSrc/slices/app/features'
6-
import { IRoute, FeatureFlags } from 'uiSrc/constants'
6+
import { IRoute, FeatureFlags, Pages } from 'uiSrc/constants'
77

88
const PrivateRoute = (route: IRoute) => {
99
const { path, exact, routes, featureFlag, redirect } = route
@@ -29,7 +29,7 @@ const PrivateRoute = (route: IRoute) => {
2929
}
3030

3131
return haveToAcceptAgreements || feature?.flag === false
32-
? <Redirect to="/" />
32+
? <Redirect to={Pages.notFound} />
3333
: (
3434
// pass the sub-routes down to keep nesting
3535
// @ts-ignore

0 commit comments

Comments
 (0)