#RI-4132 add workaround for displaying logical database switcher for users without permissions to config command

Author: Artem

redisinsight/api/src/modules/database/providers/database-info.provider.spec.ts

@@ -209,6 +209,35 @@ describe('DatabaseInfoProvider', () => {
     });
   });
 
+  describe('getDatabaseCountFromKeyspace', () => {
+    it('should return 1 since db0 keys presented only', async () => {
+      const result = await service['getDatabaseCountFromKeyspace']({
+        db0: 'keys=11,expires=0,avg_ttl=0',
+      });
+
+      expect(result).toBe(1);
+    });
+    it('should return 7 since db6 is the last logical databases with known keys', async () => {
+      const result = await service['getDatabaseCountFromKeyspace']({
+        db0: 'keys=21,expires=0,avg_ttl=0',
+        db1: 'keys=31,expires=0,avg_ttl=0',
+        db6: 'keys=41,expires=0,avg_ttl=0',
+      });
+
+      expect(result).toBe(7);
+    });
+    it('should return 1 when empty keySpace provided', async () => {
+      const result = await service['getDatabaseCountFromKeyspace']({});
+
+      expect(result).toBe(1);
+    });
+    it('should return 1 when incorrect keySpace provided', async () => {
+      const result = await service['getDatabaseCountFromKeyspace'](null);
+
+      expect(result).toBe(1);
+    });
+  });
+
   describe('determineDatabaseModules', () => {
     it('get modules by using MODULE LIST command', async () => {
       when(mockIORedisClient.call)

redisinsight/api/src/modules/database/providers/database-info.provider.ts

@@ -211,7 +211,7 @@ export class DatabaseInfoProvider {
     const clientsInfo = info['clients'];
     const statsInfo = info['stats'];
     const replicationInfo = info['replication'];
-    const databases = await this.getDatabasesCount(client);
+    const databases = await this.getDatabasesCount(client, keyspaceInfo);
     return {
       version: serverInfo?.redis_version,
       databases,
@@ -243,10 +243,30 @@ export class DatabaseInfoProvider {
     }));
   }
 
-  public async getDatabasesCount(client: any): Promise<number> {
+  public async getDatabasesCount(client: any, keyspaceInfo?: object): Promise<number> {
     try {
       const reply = await client.call('config', ['get', 'databases']);
       return reply.length ? parseInt(reply[1], 10) : 1;
+    } catch (e) {
+      return this.getDatabaseCountFromKeyspace(keyspaceInfo);
+    }
+  }
+
+  /**
+   * Try to determine number of logical database from the `info keyspace`
+   *
+   * Note: This is unreliable method which may return less logical databases count that database has
+   * However this is needed for workaround when `config` command is disabled to understand if we need
+   * to show logical database switcher on UI
+   * @param keyspaceInfo
+   * @private
+   */
+  private getDatabaseCountFromKeyspace(keyspaceInfo: object): number {
+    try {
+      const keySpaces = Object.keys(keyspaceInfo);
+      const matches = keySpaces[keySpaces.length - 1].match(/(\d+)/);
+
+      return matches[0] ? parseInt(matches[0], 10) + 1 : 1;
     } catch (e) {
       return 1;
     }

redisinsight/api/test/api/database/GET-databases-id-info.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, deps, validateApiCall, before, expect, getMainCheckFn } from '../deps';
+import { describe, deps, before, expect, getMainCheckFn, requirements } from '../deps';
 import { Joi } from '../../helpers/test';
 const { localDb, request, server, constants, rte } = deps;
 
@@ -61,4 +61,55 @@ describe(`GET /databases/:id/info`, () => {
       },
     },
   ].map(mainCheckFn);
+
+
+
+  describe('ACL', () => {
+    requirements('rte.acl', 'rte.type=STANDALONE', '!rte.re');
+    before(async () => rte.data.setAclUserRules('~* +@all'));
+    beforeEach(rte.data.truncate);
+
+    [
+      {
+        name: 'Should return 1 for empty databases',
+        endpoint: () => endpoint(constants.TEST_INSTANCE_ACL_ID),
+        before: () => rte.data.setAclUserRules('~* +@all -config'),
+        responseBody: {
+          databases: 1,
+          // ...other fields
+        },
+        statusCode: 200,
+      },
+      {
+        name: 'Should return 1 for database with keys created for db0 only',
+        endpoint: () => endpoint(constants.TEST_INSTANCE_ACL_ID),
+        before: async () => {
+          await rte.data.setAclUserRules('~* +@all -config')
+          await rte.data.generateStrings();
+        },
+        responseBody: {
+          databases: 1,
+          // ...other fields
+        },
+        statusCode: 200,
+      },
+      {
+        name: 'Should return > 1 databases since data persists there',
+        endpoint: () => endpoint(constants.TEST_INSTANCE_ACL_ID),
+        before: async () => {
+          await rte.data.setAclUserRules('~* +@all -config')
+
+          // generate data in > 0 logical database
+          await rte.data.executeCommand('select', `${constants.TEST_REDIS_DB_INDEX}`);
+          await rte.data.executeCommand('set', 'some', 'key');
+          await rte.data.executeCommand('select', '0');
+        },
+        responseBody: {
+          databases: constants.TEST_REDIS_DB_INDEX + 1,
+          // ...other fields
+        },
+        statusCode: 200,
+      },
+    ].map(mainCheckFn);
+  });
 });