Merge pull request #1995 from RedisInsight/be/bugfix/RI-4436-close_connection_after_import

#RI-4436 close connection after import

Author: arthosofteq

redisinsight/api/src/modules/bulk-actions/bulk-import.service.spec.ts

@@ -5,7 +5,7 @@ import {
   mockClientMetadata,
   mockDatabaseConnectionService,
   mockIORedisClient,
-  mockIORedisCluster, MockType
+  mockIORedisCluster, MockType,
 } from 'src/__mocks__';
 import { MemoryStoredFile } from 'nestjs-form-data';
 import { BulkActionSummary } from 'src/modules/bulk-actions/models/bulk-action-summary';
@@ -195,6 +195,7 @@ describe('BulkImportService', () => {
         },
         duration: jasmine.anything(),
       });
+      expect(mockIORedisClient.disconnect).toHaveBeenCalled();
     });
 
     it('should throw an error in case of global error', async () => {
@@ -205,6 +206,7 @@ describe('BulkImportService', () => {
 
         fail();
       } catch (e) {
+        expect(mockIORedisClient.disconnect).not.toHaveBeenCalled();
         expect(e).toBeInstanceOf(NotFoundException);
       }
     });

redisinsight/api/src/modules/bulk-actions/bulk-import.service.ts

@@ -80,8 +80,10 @@ export class BulkImportService {
 
     let parseErrors = 0;
 
+    let client;
+
     try {
-      const client = await this.databaseConnectionService.createClient(clientMetadata);
+      client = await this.databaseConnectionService.createClient(clientMetadata);
 
       const stream = Readable.from(dto.file.buffer);
       let batch = [];
@@ -126,9 +128,12 @@ export class BulkImportService {
 
       this.analyticsService.sendActionStopped(result);
 
+      client.disconnect();
+
       return result;
     } catch (e) {
       this.logger.error('Unable to process an import file', e);
+      client?.disconnect();
       throw wrapHttpError(e);
     }
   }