Rework the test cases to be compatible with the latest bugfix suggestion

Author: GnaneshKunal

redisinsight/api/src/modules/certificate/ca-certificate.controller.ts

@@ -38,9 +38,7 @@ export class CaCertificateController {
   @Delete(':id')
   @ApiOperation({ description: 'Delete Ca Certificate by id' })
   @ApiParam({ name: 'id', type: String })
-  async delete(
-    @Param('id') id: string,
-  ): Promise<void> {
+  async delete(@Param('id') id: string): Promise<void> {
     await this.service.delete(id);
   }
 }

redisinsight/api/src/modules/certificate/ca-certificate.service.spec.ts

@@ -5,12 +5,9 @@ import {
   mockCaCertificate,
   mockCaCertificateRepository, mockCreateCaCertificateDto,
   MockType,
-  mockSessionMetadata,
-  mockDatabaseRepository,
   mockRedisClientStorage,
 } from 'src/__mocks__';
 import { CaCertificateRepository } from 'src/modules/certificate/repositories/ca-certificate.repository';
-import { DatabaseRepository } from 'src/modules/database/repositories/database.repository';
 import { RedisClientStorage } from 'src/modules/redis/redis.client.storage';
 import { pick } from 'lodash';
 import { KeytarEncryptionErrorException } from 'src/modules/encryption/exceptions';
@@ -29,10 +26,6 @@ describe('CaCertificateService', () => {
           provide: CaCertificateRepository,
           useFactory: mockCaCertificateRepository,
         },
-        {
-          provide: DatabaseRepository,
-          useFactory: mockDatabaseRepository,
-        },
         {
           provide: RedisClientStorage,
           useFactory: mockRedisClientStorage,
@@ -101,13 +94,13 @@ describe('CaCertificateService', () => {
 
   describe('delete', () => {
     it('should delete ca certificate', async () => {
-      expect(await service.delete(mockSessionMetadata, mockCaCertificate.id)).toEqual(undefined);
+      expect(await service.delete(mockCaCertificate.id)).toEqual(undefined);
     });
     it('should throw encryption error', async () => {
       repository.delete.mockRejectedValueOnce(new KeytarEncryptionErrorException());
 
       try {
-        await service.delete(mockSessionMetadata, mockCaCertificate.id);
+        await service.delete(mockCaCertificate.id);
         fail();
       } catch (e) {
         expect(e).toBeInstanceOf(KeytarEncryptionErrorException);
@@ -117,7 +110,7 @@ describe('CaCertificateService', () => {
       repository.delete.mockRejectedValueOnce(new Error());
 
       try {
-        await service.delete(mockSessionMetadata, mockCaCertificate.id);
+        await service.delete(mockCaCertificate.id);
         fail();
       } catch (e) {
         expect(e).toBeInstanceOf(InternalServerErrorException);

redisinsight/api/src/modules/certificate/client-certificate.controller.ts

@@ -39,9 +39,7 @@ export class ClientCertificateController {
   @Delete(':id')
   @ApiOperation({ description: 'Delete Client Certificate pair by id' })
   @ApiParam({ name: 'id', type: String })
-  async deleteClientCertificatePair(
-    @Param('id') id: string,
-  ): Promise<void> {
+  async deleteClientCertificatePair(@Param('id') id: string): Promise<void> {
     await this.service.delete(id);
   }
 }

redisinsight/api/src/modules/certificate/client-certificate.service.spec.ts

@@ -6,14 +6,11 @@ import {
   mockClientCertificate,
   mockClientCertificateRepository, mockCreateClientCertificateDto,
   MockType,
-  mockSessionMetadata,
-  mockDatabaseRepository,
   mockRedisClientStorage,
 } from 'src/__mocks__';
 import { KeytarEncryptionErrorException } from 'src/modules/encryption/exceptions';
 import { ClientCertificateService } from 'src/modules/certificate/client-certificate.service';
 import { ClientCertificateRepository } from 'src/modules/certificate/repositories/client-certificate.repository';
-import { DatabaseRepository } from 'src/modules/database/repositories/database.repository';
 import { RedisClientStorage } from 'src/modules/redis/redis.client.storage';
 
 describe('ClientCertificateService', () => {
@@ -29,10 +26,6 @@ describe('ClientCertificateService', () => {
           provide: ClientCertificateRepository,
           useFactory: mockClientCertificateRepository,
         },
-        {
-          provide: DatabaseRepository,
-          useFactory: mockDatabaseRepository,
-        },
         {
           provide: RedisClientStorage,
           useFactory: mockRedisClientStorage,
@@ -101,13 +94,13 @@ describe('ClientCertificateService', () => {
 
   describe('delete', () => {
     it('should delete client certificate', async () => {
-      expect(await service.delete(mockSessionMetadata, mockClientCertificate.id)).toEqual(undefined);
+      expect(await service.delete(mockClientCertificate.id)).toEqual(undefined);
     });
     it('should throw encryption error', async () => {
       repository.delete.mockRejectedValueOnce(new KeytarEncryptionErrorException());
 
       try {
-        await service.delete(mockSessionMetadata, mockClientCertificate.id);
+        await service.delete(mockClientCertificate.id);
         fail();
       } catch (e) {
         expect(e).toBeInstanceOf(KeytarEncryptionErrorException);
@@ -117,7 +110,7 @@ describe('ClientCertificateService', () => {
       repository.delete.mockRejectedValueOnce(new Error());
 
       try {
-        await service.delete(mockSessionMetadata, mockClientCertificate.id);
+        await service.delete(mockClientCertificate.id);
         fail();
       } catch (e) {
         expect(e).toBeInstanceOf(InternalServerErrorException);