Skip to content

Commit 79dbe91

Browse files
authored
Merge pull request #1134 from RedisInsight/e2e/bugfix/confirm-iframe-fix
confirm iframe fix
2 parents cc98e85 + f03cb66 commit 79dbe91

File tree

5 files changed

+12
-15
lines changed

5 files changed

+12
-15
lines changed

tests/e2e/tests/critical-path/workbench/command-results.e2e.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ test('Verify that user can see the results found in the table view by default fo
7272
await t.expect(await workbenchPage.queryCardContainer.nth(0).find(workbenchPage.cssTableViewTypeOption).visible).ok(`The table view is selected by default for command ${command}`);
7373
}
7474
});
75-
test
76-
.meta({ env: env.desktop })('Verify that user can switches between views and see results according to the view rules in Workbench in results', async t => {
75+
test('Verify that user can switches between views and see results according to the view rules in Workbench in results', async t => {
7776
indexName = chance.word({ length: 5 });
7877
const commands = [
7978
'hset doc:10 title "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud" url "redis.io" author "Test" rate "undefined" review "0" comment "Test comment"',
@@ -92,9 +91,8 @@ test
9291
await workbenchPage.selectViewTypeText();
9392
await t.expect(await workbenchPage.queryCardContainer.nth(0).find(workbenchPage.cssQueryTextResult).visible).ok('The result is displayed in Text view');
9493
});
95-
//skipped due the inaccessibility of the iframe
96-
test.skip
97-
.meta({ env: env.desktop })('Verify that user can switches between Table and Text for Client List and see results corresponding to their views', async t => {
94+
// Skipped due to issue https://redislabs.atlassian.net/browse/RI-3524
95+
test.skip('Verify that user can switches between Table and Text for Client List and see results corresponding to their views', async t => {
9896
const command = 'CLIENT LIST';
9997
//Send command and check table view is default
10098
await workbenchPage.sendCommandInWorkbench(command);

tests/e2e/tests/critical-path/workbench/default-scripts-area.e2e.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ fixture `Default scripts area at Workbench`
2727
await deleteStandaloneDatabaseApi(ossStandaloneRedisearch);
2828
});
2929
test
30-
.meta({ env: env.desktop, rte: rte.standalone })('Verify that user can edit and run automatically added "FT._LIST" and "FT.INFO {index}" scripts in Workbench and see the results', async t => {
30+
.meta({ rte: rte.standalone })('Verify that user can edit and run automatically added "FT._LIST" and "FT.INFO {index}" scripts in Workbench and see the results', async t => {
3131
indexName = chance.word({ length: 5 });
3232
keyName = chance.word({ length: 5 });
3333
const commandsForSend = [
@@ -55,7 +55,7 @@ test
5555
await t.expect(workbenchPage.queryColumns.textContent).contains('name', 'The result of the FT.INFO command');
5656
});
5757
test
58-
.meta({ env: env.desktop, rte: rte.standalone })('Verify that user can edit and run automatically added "Search" script in Workbench and see the results', async t => {
58+
.meta({ rte: rte.standalone })('Verify that user can edit and run automatically added "Search" script in Workbench and see the results', async t => {
5959
indexName = chance.word({ length: 5 });
6060
keyName = chance.word({ length: 5 });
6161
const commandsForSend = [
@@ -80,7 +80,7 @@ test
8080
await t.expect(name.exists).ok('The added key name field is in the Search result');
8181
});
8282
test
83-
.meta({ env: env.desktop, rte: rte.standalone })('Verify that user can edit and run automatically added "Aggregate" script in Workbench and see the results', async t => {
83+
.meta({ rte: rte.standalone })('Verify that user can edit and run automatically added "Aggregate" script in Workbench and see the results', async t => {
8484
indexName = chance.word({ length: 5 });
8585
const aggregationResultField = 'max_price';
8686
const commandsForSend = [

tests/e2e/tests/regression/workbench/command-results.e2e.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ const commandsForIndex = [
1919
'HMSET product:1 price 20',
2020
'HMSET product:2 price 100'
2121
];
22-
// skip due to errors of FT.SEARCH issue https://redislabs.atlassian.net/browse/RI-3501
23-
fixture.skip `Command results at Workbench`
22+
23+
fixture `Command results at Workbench`
2424
.meta({type: 'regression', rte: rte.standalone })
2525
.page(commonUrl)
2626
.beforeEach(async t => {
@@ -72,8 +72,8 @@ test
7272
await t.switchToIframe(workbenchPage.iframe);
7373
await t.expect(await workbenchPage.queryTableResult.exists).ok('The table view is not switched for command FT.AGGREGATE');
7474
});
75-
// skip due to inaccessibility of CLIENT LIST in plugin
76-
test
75+
// Skipped due to issue https://redislabs.atlassian.net/browse/RI-3524
76+
test.skip
7777
.meta({ env: env.web })('Verify that user can switches between views and see results according to this view in full mode in Workbench', async t => {
7878
const command = 'CLIENT LIST';
7979
//Send command and check table view is default in full mode

tests/e2e/tests/regression/workbench/raw-mode.e2e.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,7 @@ test
100100
await t.switchToMainWindow();
101101
await workbenchPage.sendCommandInWorkbench(`FT.DROPINDEX ${indexName} DD`);
102102
await deleteStandaloneDatabaseApi(ossStandaloneRedisearch);
103-
})
104-
.meta({ env: env.desktop })('Display Raw mode for plugins', async t => {
103+
})('Display Raw mode for plugins', async t => {
105104
const commandsForSend = [
106105
`FT.CREATE ${indexName} ON HASH PREFIX 1 product: SCHEMA name TEXT`,
107106
`HMSET product:1 name "${unicodeValue}"`,

tests/e2e/tests/regression/workbench/scripting-area.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const settingsPage = new SettingsPage();
1515
const indexName = chance.word({ length: 5 });
1616
let keyName = chance.word({ length: 10 });
1717

18-
fixture`Scripting area at Workbench`
18+
fixture `Scripting area at Workbench`
1919
.meta({ type: 'regression' })
2020
.page(commonUrl)
2121
.beforeEach(async t => {

0 commit comments

Comments
 (0)