RI-2790-remove db index validation (#634)

* RI-2790-remove db index validation

Author: AmirAllayarovSofteq

redisinsight/api/src/modules/instances/dto/database-instance.dto.ts

@@ -212,7 +212,6 @@ export class ConnectionOptionsDto extends EndpointDto {
     example: 0,
   })
   @IsInt()
-  @Max(15)
   @Min(0)
   @Type(() => Number)
   @IsOptional()
@@ -403,15 +402,13 @@ export class AddDatabaseInstanceDto extends ConnectionOptionsDto {
 
 export class ConnectToRedisDatabaseIndexDto {
   @ApiPropertyOptional({
-    description: 'Databases index. Redis databases are numbered from 0 to 15.',
+    description: 'Databases index.',
     type: Number,
     minimum: 0,
-    maximum: 15,
     default: 0,
   })
   @IsInt()
   @Min(0)
-  @Max(15)
   @Type(() => Number)
   @IsNotEmpty()
   dbNumber?: number;

redisinsight/api/src/modules/instances/dto/redis-sentinel.dto.ts

@@ -64,7 +64,6 @@ export class AddSentinelMasterDto {
     example: 0,
   })
   @IsInt()
-  @Max(15)
   @Min(0)
   @Type(() => Number)
   @IsOptional()

redisinsight/ui/src/components/input-field-sentinel/InputFieldSentinel.tsx

@@ -3,7 +3,7 @@ import { omit } from 'lodash'
 import React, { useState } from 'react'
 import cx from 'classnames'
 import { useDebouncedEffect } from 'uiSrc/services'
-import { validateDatabaseNumber } from 'uiSrc/utils'
+import { validateNumber } from 'uiSrc/utils'
 
 import styles from './styles.module.scss'
 
@@ -77,7 +77,7 @@ const InputFieldSentinel = (props: Props) => {
           compressed
           type="text"
           value={value}
-          onChange={(e) => handleChange(validateDatabaseNumber(e.target?.value))}
+          onChange={(e) => handleChange(validateNumber(e.target?.value))}
           data-testid="sentinel-input-number"
         />
       )}

redisinsight/ui/src/pages/home/components/AddInstanceForm/InstanceForm/InstanceForm.tsx

@@ -33,11 +33,10 @@ import { FormikErrors, useFormik } from 'formik'
 import cx from 'classnames'
 import {
   MAX_PORT_NUMBER,
-  MAX_DATABASE_INDEX_NUMBER,
+  validateNumber,
   validateCertName,
   validateField,
   validatePortNumber,
-  validateDatabaseNumber,
 } from 'uiSrc/utils/validations'
 import {
   ConnectionType,
@@ -753,7 +752,7 @@ const AddStandaloneForm = (props: Props) => {
               { [styles.dbInputBig]: !flexItemClassName }
             )}
           >
-            <EuiFormRow label="Database Index" helpText="Should not exceed 15.">
+            <EuiFormRow label="Database Index">
               <EuiFieldNumber
                 name="db"
                 id="db"
@@ -765,12 +764,11 @@ const AddStandaloneForm = (props: Props) => {
                 onChange={(e: ChangeEvent<HTMLInputElement>) => {
                   formik.setFieldValue(
                     e.target.name,
-                    validateDatabaseNumber(e.target.value.trim())
+                    validateNumber(e.target.value.trim())
                   )
                 }}
                 type="text"
                 min={0}
-                max={MAX_DATABASE_INDEX_NUMBER}
               />
             </EuiFormRow>
           </EuiFlexItem>

redisinsight/ui/src/pages/sentinelDatabases/SentinelDatabasesPage.tsx

@@ -11,7 +11,7 @@ import { useHistory } from 'react-router-dom'
 import { useDispatch, useSelector } from 'react-redux'
 
 import { Pages } from 'uiSrc/constants'
-import { MAX_DATABASE_INDEX_NUMBER, setTitle } from 'uiSrc/utils'
+import { setTitle } from 'uiSrc/utils'
 import { sendEventTelemetry, TelemetryEvent } from 'uiSrc/telemetry'
 import {
   createMastersSentinelAction,
@@ -235,7 +235,6 @@ const SentinelDatabasesPage = () => {
           <div role="presentation">
             <InputFieldSentinel
               min={0}
-              max={MAX_DATABASE_INDEX_NUMBER}
               className={styles.dbInfo}
               value={`${db}` || '0'}
               name={`db-${id}`}

redisinsight/ui/src/pages/sentinelDatabasesResult/SentinelDatabasesResultPage.tsx

@@ -25,7 +25,7 @@ import {
   createMastersSentinelAction,
   resetDataSentinel,
 } from 'uiSrc/slices/instances/sentinel'
-import { MAX_DATABASE_INDEX_NUMBER, removeEmpty, setTitle } from 'uiSrc/utils'
+import { removeEmpty, setTitle } from 'uiSrc/utils'
 import { ApiStatusCode, Pages } from 'uiSrc/constants'
 import { ApiEncryptionErrors } from 'uiSrc/constants/apiErrors'
 import { InputFieldSentinel } from 'uiSrc/components'
@@ -299,7 +299,6 @@ const SentinelDatabasesResultPage = () => {
             <InputFieldSentinel
               min={0}
               disabled={loading}
-              max={MAX_DATABASE_INDEX_NUMBER}
               className={styles.dbInfo}
               value={`${db}` || '0'}
               name={`db-${id}`}

redisinsight/ui/src/utils/tests/validations.spec.ts

@@ -8,8 +8,6 @@ import {
   validateCountNumber,
   validateScoreNumber,
   validateTTLNumberForAddKey,
-  MAX_DATABASE_INDEX_NUMBER,
-  validateDatabaseNumber,
   validateCertName,
   validateRefreshRateNumber,
   MAX_REFRESH_RATE,
@@ -134,28 +132,6 @@ describe('Validations utils', () => {
     })
   })
 
-  describe('validateDatabaseNumber', () => {
-    it('validateDatabaseNumber should return only numbers between 0 and MAX_DATABASE_INDEX_NUMBER', () => {
-      const expectedResponse1 = `${MAX_DATABASE_INDEX_NUMBER}`
-      const expectedResponse2 = `${MAX_DATABASE_INDEX_NUMBER}`
-      const expectedResponse4 = ''
-      const expectedResponse5 = ''
-      const expectedResponse6 = `${MAX_DATABASE_INDEX_NUMBER}`
-      const expectedResponse7 = `${MAX_DATABASE_INDEX_NUMBER}`
-      const expectedResponse8 = `${MAX_DATABASE_INDEX_NUMBER}`
-      const expectedResponse13 = '5'
-
-      expect(validateDatabaseNumber(text1)).toEqual(expectedResponse1)
-      expect(validateDatabaseNumber(text2)).toEqual(expectedResponse2)
-      expect(validateDatabaseNumber(text4)).toEqual(expectedResponse4)
-      expect(validateDatabaseNumber(text5)).toEqual(expectedResponse5)
-      expect(validateDatabaseNumber(text6)).toEqual(expectedResponse6)
-      expect(validateDatabaseNumber(text7)).toEqual(expectedResponse7)
-      expect(validateDatabaseNumber(text8)).toEqual(expectedResponse8)
-      expect(validateDatabaseNumber(text13)).toEqual(expectedResponse13)
-    })
-  })
-
   describe('validateEmail', () => {
     it('validateEmail should return "true" only for email format text', () => {
       expect(validateEmail(text1)).toBeFalsy()

redisinsight/ui/src/utils/validations.ts

@@ -2,7 +2,6 @@ import { floor } from 'lodash'
 
 export const MAX_TTL_NUMBER = 2147483647
 export const MAX_PORT_NUMBER = 65535
-export const MAX_DATABASE_INDEX_NUMBER = 99
 export const MAX_SCORE_DECIMAL_LENGTH = 15
 export const MAX_REFRESH_RATE = 999.9
 export const MIN_REFRESH_RATE = 1.0
@@ -61,8 +60,6 @@ export const validateEmail = (email: string) => {
 }
 
 export const validatePortNumber = (initValue: string) => validateNumber(initValue, MAX_PORT_NUMBER)
-export const validateDatabaseNumber = (initValue: string) =>
-  validateNumber(initValue, MAX_DATABASE_INDEX_NUMBER)
 
 export const validateNumber = (initValue: string, maxNumber: number = Infinity, minNumber: number = 0) => {
   const positiveNumbers = /[^0-9]+/gi